From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE147C282EC for ; Mon, 17 Mar 2025 18:19:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DAFA280003; Mon, 17 Mar 2025 14:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 366C4280001; Mon, 17 Mar 2025 14:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E0C0280003; Mon, 17 Mar 2025 14:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F24B4280001 for ; Mon, 17 Mar 2025 14:18:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B6AFEB696A for ; Mon, 17 Mar 2025 18:18:59 +0000 (UTC) X-FDA: 83231854398.16.D9B5F84 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf05.hostedemail.com (Postfix) with ESMTP id AF8A7100012 for ; Mon, 17 Mar 2025 18:18:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="COPvp2/V"; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742235537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fs5FRMsdqp/BT81c+IUYvUcJpd3cBpM8V6qAiLgpjPs=; b=iLrsClktcce6nJUpmDYVxTgeebE6DjnfRWxTlJNGSiEEeKRef4t9bPRa2SVimAlImZ3JFs dO/WKVySfGri7V6nT51VyZIM0RqcTvPPkQS2zfzlBKJvgjAQvBnitEb29AymxtY0h0HyZq F93u07kaQ5TRT7Dw1qTgCtSIHt9TC8U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="COPvp2/V"; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742235537; a=rsa-sha256; cv=none; b=W0CerkcLFvI77ZIjjOy0TB/a3L5ARWNxNMgvVAsmZla4s4lcX3pPUobijaNf3I6EQwieEs hqwEYNdxzTVnEGr8aQRRLUpbrVX1dbN9ojEzNzF3n6229wyCqT4+dtLwVIRmP3M2q3fSR1 HFDaoaxdLP7zQATuuTHlS2D55foWQY8= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6e904f53151so38969636d6.3 for ; Mon, 17 Mar 2025 11:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1742235536; x=1742840336; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fs5FRMsdqp/BT81c+IUYvUcJpd3cBpM8V6qAiLgpjPs=; b=COPvp2/VxAdyiWtQ/pttd3x5GDwXM9Sw7O50nk7Bjuc2F1jZ1PFwg/aZOFTBB4ntKq xtbrIwp98uNFOV1H5SAVmsishGtiBTuzZU+KTBkRtqYjMCNmmoTXvGdn1PGV6qpNgb0d ddHUTTm2zM+5RJjVOlhdBlyWrDETuy7gju3dB80mKBv0jZ5tKo0CDCQGhp44ERo4Pt3T XAapNR6lE7i94BCBSuCiRsrkhRUyGoy3H6xCZ9C+kyxVCmhrvY5djKJ76xnyA0kT/FbY 8hQFCCw2Q5ONLn+dl6OVQXzPNilOqQXNtW6yvcbt1fBdvcyQhJnpF2PLNV8pNwLoHheh Tqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742235536; x=1742840336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fs5FRMsdqp/BT81c+IUYvUcJpd3cBpM8V6qAiLgpjPs=; b=kjHXBIdvl0JWum4Eu7L9nazudie/KiaJxW4uN65yPF3I7MkH5iKD0H3hZiqo2tFpUQ vaR/9LQwJPDlmBukobGfRkm4QDJygKTaPan7HVdIMqBWx7+UkLANjkxOMDTkn/64jDAr zN910KUrg89L0Epd3RKMMmmIhkLf5rLK1idc40GuQjk/KhXvt57lj+sfZzAKnnEkFMzQ 6sRXMSJqQTema8We8rHFGLf0cZsDrDl/z4Li4pIF7IKe5XQqawPrwPxgJwPWD0W9dyvK 2/hj6CGPnAfb+X6s3TKe1NPoDSe9JqsXcYjFLOolU1olo0r1LSPQnbE44g08OS/M7sjs psvQ== X-Forwarded-Encrypted: i=1; AJvYcCWoiCKzAGmmkcNh4xQWQyH+ETmHXXH72dfnnVWAgZYjvCmS4o4WBD5o9lN8YjFc3XNtd8nWlpNU9Q==@kvack.org X-Gm-Message-State: AOJu0YyHBR/tq1xeqWbRxy/BoE+246uTs/I147Pg07w7MngaAy6L5pEB SThVA+HfBRg0AqGjmXJJneJQ3W4g7nX0ObtUNIJ1+MfrfPCYuw8aXZOscgZZDqs= X-Gm-Gg: ASbGncvVV0ad5h568fwG8pWylauZ55tPaKcWSm7Tj4xiN27HQZLT4rH3R9/2hro04BJ 50DZfFN6wu7JSxBPsUknjHKCoeumJRJEuEifSbFCrPsgBTx8Bu03jPZUDtWpxjFzKDf7aapmZKn o50Sy/RaIpOcToWKrxkjWveYUH7FBicH25DJe/CM635IpaAqQOLT7gz/T3AXAhiWnPJ9u20Qsvq rAYz+/mmo5mheAe2m3vOzzOg8NkIrqghnNduiQc6Kcl75X+adHfbrBgGyviams6jzjO80uLrik+ FWpZLYL73WFlCe2JA58XrE637EaZ+z/9H5WCb1Tcv2tCCCqdWm9dow== X-Google-Smtp-Source: AGHT+IGDO7z/jJycwpThPXWNMRYFlUkK/xin8Ffvpsmfo+RNv6m+nTJPfrYCHQRCo7pCvqqjyD58VQ== X-Received: by 2002:a05:6214:1d25:b0:6e8:9086:261 with SMTP id 6a1803df08f44-6eaea996d8dmr195571526d6.3.1742235536659; Mon, 17 Mar 2025 11:18:56 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6eade254502sm57587546d6.59.2025.03.17.11.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 11:18:55 -0700 (PDT) Date: Mon, 17 Mar 2025 14:18:51 -0400 From: Johannes Weiner To: Hugh Dickins Cc: Andrew Morton , Johannes Weiner , Vlastimil Babka , Mel Gorman , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] mm: compaction: push watermark into compaction_suitable() callers Message-ID: <20250317181851.GA1694060@cmpxchg.org> References: <20250313210647.1314586-1-hannes@cmpxchg.org> <20250313210647.1314586-2-hannes@cmpxchg.org> <005ace8b-07fa-01d4-b54b-394a3e029c07@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <005ace8b-07fa-01d4-b54b-394a3e029c07@google.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AF8A7100012 X-Stat-Signature: gqrke6udgozzgn74p6iqxn3g7fqf7t8d X-HE-Tag: 1742235537-146909 X-HE-Meta: U2FsdGVkX19WcuPF2gkL4resKaxwaURBuSQdX0xkr87c4c6nCHeDkHEYwEtctKyrNVbQYVh0MaRqTvXLPBNEQqYFcuZNWpMCXBJBYKnV5h3EEN3FqCzGxkRkeCwHd9nibtaSGz+udfHCKxzsC4NGH1uaijUuw9MsNF7y9wIU/rOdRi1r/5OUF3ow9JZhr36wmSkyutGl8/ql2RQcWILxLl5O01ssGXOxdi5MJuA4uqo2seQcJTprJPd20VgqxSyCMA2TCeULbz4wxb8RDHy5so9EzXa39sTyaB9oOK9ja1KylqXeFqWQKAhw4SxxYVAk9+9aJgnKcezHgn3rSBrbOQ4lWZv19K9c9u5MoSr16Brd1ZvKEIczv4g1YRB1o5dv6QzJUgjP9LMEpOAc3qvd65oOgRCSAh7ogyrvKH4IKWGIA5r2IycFiQnkEeQmrsXe4i2ysJ9qKz3gQPbnfVrsreOXWtowIDe7PKgfigVaWKomgjeUgC3qTk6kzXxPjIiqiLw0MS73XVo6qSJoGpcoho2BipYYu+NDB8DN9DRpegyPROdSoiRQf0UIDcdeoiEn6t/TM1PXvZOrlTJa8KMc3g9UXHww8KFXC+Lngg+Z6viyLWaYd6V8Hygns2/vF2SkSODIEBPuPLaXPX9bDsVj3uhaJ2NL9pyYfubAuK87a7mo8cwyL+uAmZ3Kvdbw5dBdGOXYCDh2G92mJzd3xcAUpRPMmZ/dxup2PurWGUbUiUPcz/jPeODfRFSxUAlb5TQp6P9J7dDKmGjpgcdPg79Yk9htJZXgpL2CrX5/68CzLloLPwfCtXeWrk+ccXeSVhBUVAd4gv+4osgBN6QBc3CGGmsau4nAaEcVihYdtJs51YLkEmE8ilc1K/rcezbxDujipuYvuM6QGmxgfgxZpjSCOawRMc2Y+bTLFea6vGLPY2fjeG8wSclaaCijahCQcS+EIF8yc9tt/hPYmvrMfbm QdMzGwmP YMfJfQyTjO6pirBpBmoehX/SWQvtjy6D6nmfLwDdhKyqF1asS1z4w5DjXYchl1aPFmd7KQNqPtiGPJOTmGdIeUaMGffKvstmZeCQ5VIEQdnk2Eo+KNBn2E0Iqqa6eaX8oay+NtllHlE4ZTwNNB51uqQzKHSBMrm7/uLwto3ehGS2KrRSv8+mHBaMmh5oVmYsF/LzWznyeVsCyFauT+PCfjRo1coDs1gyHf5j9w3YDuLtKDq2oYsngdNa6OBVcjoluOgCI7Um3wIlyVWYXzUwJUyKrcgF2xVgs8jgEpmtOC1s0E0uUbBtndY39Wb2DA09tBNyuSQ6Okdt6pEBd9OYpa4LtOl0r+gl5kpHq2cT3kJ5tDLSsMqFHRvGpSBKH6NSkHW2LVwh5iB76Ncj5Yu4eeiMShXkhWA7nm2n6BXoxq0ql8eM7Ou9Gun49Ar1rV7g6pQh2lsktH+GNr1a9JLjY9nX5QMik4HYAB41G2iApfjOqIPz9dOHD36g9DwQzCkpJy4r9ewH6HVr8YRabixG+lmjTQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 15, 2025 at 09:28:16PM -0700, Hugh Dickins wrote: > [PATCH] mm: compaction: push watermark into compaction_suitable() callers fix > > Stop oops on out-of-range highest_zoneidx: compaction_suitable() pass > args to __compaction_suitable() in the order which it is expecting. > > Signed-off-by: Hugh Dickins > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 4a2ccb82d0b2..b5c9e8fd39f1 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2433,7 +2433,7 @@ bool compaction_suitable(struct zone *zone, int order, unsigned long watermark, > enum compact_result compact_result; > bool suitable; > > - suitable = __compaction_suitable(zone, order, highest_zoneidx, watermark, > + suitable = __compaction_suitable(zone, order, watermark, highest_zoneidx, > zone_page_state(zone, NR_FREE_PAGES)); Ouch, thanks for the fix Hugh. This obviously didn't crash for me, but I re-ran the benchmarks with your fix in my test environment. This affects the direct compaction path, and I indeed see a minor uptick in direct compaction, with a larger reduction in daemon work. Compact daemon scanned migrate 2455570.93 ( +0.00%) 1770142.33 ( -27.91%) Compact daemon scanned free 2429309.20 ( +0.00%) 1604744.00 ( -33.94%) Compact direct scanned migrate 40136.60 ( +0.00%) 58326.67 ( +45.32%) Compact direct scanned free 22127.13 ( +0.00%) 52216.93 ( +135.98%) Compact total migrate scanned 2495707.53 ( +0.00%) 1828469.00 ( -26.74%) Compact total free scanned 2451436.33 ( +0.00%) 1656960.93 ( -32.41%) It doesn't change the overall A/B picture between baseline and the series, so I'm comfortable keeping the current changelog results.