From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26357C282EC for ; Mon, 17 Mar 2025 13:44:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4931F280003; Mon, 17 Mar 2025 09:44:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4415D280001; Mon, 17 Mar 2025 09:44:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309BC280003; Mon, 17 Mar 2025 09:44:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A4AC280001 for ; Mon, 17 Mar 2025 09:44:47 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 74B291A1F1D for ; Mon, 17 Mar 2025 13:44:46 +0000 (UTC) X-FDA: 83231163372.16.1773E17 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id C4B0BA000B for ; Mon, 17 Mar 2025 13:44:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ILjGPW3O; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742219084; a=rsa-sha256; cv=none; b=6AJDmHPF/U8GrFTfH44jT1Ez8QKgOhfAbGW+gk0tNPY0y9BgRcBocs3CPNsztMh1fwwD+F jXjtDu92HvWBEo53DYlAT9yq+Q4Z+3gOMGU9SGEG0sYVV4KfZIf9MNKlwCXspRWb/1h5qj 4NT6T8/z9Z2l55TT7xFh+4BfNrOMio0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ILjGPW3O; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742219084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e6VvJGMoHaQ/7+tlz8AsQMqYqoDcq3BWKhvW6SNdsfA=; b=f7MluHj/CKu8+cEeb+TEwFUVX0qPIOOxEPPNWpHhuS/vEb4wGJr8PDWBTEV18p68zHUxSZ t5DMp2tHB1osAFDy+4H+lchZ/K7NDUyIQtFftwrfooybYCpwGcxRP+j+KEJrcD/1fDYjL0 79Go3Qeht6Dx83aLOgGy4IpU/1cKi70= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 494C0A429E5; Mon, 17 Mar 2025 13:39:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE2E6C4CEE3; Mon, 17 Mar 2025 13:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742219083; bh=Nivyt0eviFTvQGhEOEf8ZZpxVSrnlmwhnY5tRfaE3Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ILjGPW3OLQcmOrkMv5AH8aq1hrAnpRAPMTAQgLR7RHFsJF2bLoRw3BTOgmHBq56Li RCNNwy/ccowtgdxyVVPCv0ACNvWo78Z/Cvu5jcsLgefi4PUDEch8eU1Oviz3EuYzg5 XUIEGSx2UA3cLHJWgIltL+b6l4V15ww+2bB6RDXFXhGG+65hftuhRbA0B/Wi3ffTrq 1vQsHc29chbUvptRWKtzZwyE1x1581v27MnBNJCKTXUw8791ZidkW0v3U8o4LXMJS3 W5yBnsLldEWaxyxVsmdLLyDaZrnHRHhHavJ+TGx31Iv9mQtnnuwHaY0Ofdxp9EFxBU dA3ZPdJHhLs9A== Date: Mon, 17 Mar 2025 15:44:39 +0200 From: Leon Romanovsky To: Niklas Schnelle Cc: Christoph Hellwig , Jason Gunthorpe , Robin Murphy , Jens Axboe , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v7 03/17] iommu: generalize the batched sync after map interface Message-ID: <20250317134439.GX1322339@unreal> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: tmeeu3e961bgptjomttpn1tsdgzfimjr X-Rspamd-Queue-Id: C4B0BA000B X-HE-Tag: 1742219084-652166 X-HE-Meta: U2FsdGVkX18E2S79fb76dK19WmnV9Ll8isRJozsxX8LSBwx16AuvYKTgzt7kw5tODInaNiZf7EjgaDp48umjOk8LIbZYZSiKrLOF/ellqcUiwnO+GR8u84jC3dtBL78dSSStcIfs/2sRkdVIWP7Y9rp9SzcIGHWx9WmMann5+rv1O68HI+esZgVZTBVgUvYu/DwuqISVqw/UYfrNftUQb6XJ3YcKGVcEtGIM4A2sdhX3UxZSezeVfAYCXjV8n9C09sN3sACA7cPF6nT+qDKuUk7TpcQ3i7LSo28h/6LUIxOABNdPlbhaYjRdAEPBZ2S/wdDAbNnkF4vEEu/s5eBOaxAUq4lUPsqiMiRudP5i/4V8L4+9lQ3ItpR+okn7qPQ5xfQV5WMS7rxDyVMqoZWQaiheTTYtw2ETlXQR0H1B/SzKhxhbef2kXCY3sSj/ss5zlmzHZOW67P/AHAPuIgQ0xcosv3LSly3qAOMrqf4Yzq+5g63bYt/nXdaD2gloI42IvXszzMp97zSFSyK8mK+2kcE4IEKDqhE+maiNuHzFg/kHvyYfJA1ITY+V0c09eXk9BG6bVwOyniAVAs/m+vO/IlFuxHPFOdqNDric2rExvUezE7j5kDVDljbEFGhFwmngX/gSNkqLvihBNUl41GQ6Hs9JMNuP4cbA5jcXw5SaO3XIC/u2knaudarQCI6OdI4YBi9+HfAQbYx4Wrv3UC2o5nxTdj8gFiPofiwTDtlWoTpWU8A7DTL8VjCXNWuw5xhY+Jt0M3q4rJ5Uw3QXjYmat+2+CFnApW9z37HhA7gd2eoNcTSPcExNTTHowp0k3QjRhrTwrD+0YO3tOJKyyObbCU/uyDX/ekWHQZYhnOC0TsrucXbylngIjJdtKRjHyQQYlM2RxFmhkf8qsV4N91j6PxdyyD5gl8gbhQuRMis3y2usWQm/yeVhYt/dOp4g5cr0609OEWKgTs1zKvm1DTQ pCgRXx+e ZYDhOsYeD5Qb6qdSmQvklvtvmkzE0c1+EwDsGjk12mpb5Bv7WBXN23A90JdIEZ+7/AN/5dI63w56Vls1UUs8hTygdxV7jPu7p+n8QjFUx+F3jwlP4cX8axSEBftWtd4JNMFsDIR85Z2x4IFdiWYK84eSVmmvWHC3n7UwSc4fbiEGL4kXDSkE10D7XR1eHWriids832CponQdzRuHQT8F5mC6RDdM0q3RuvPKzCiPO21JklurU6OdIwbzTcWZt/ydY2/TA8jWz1MSA5LLwK4gdW+gFi34JNvGtodBYMg5F/FKLmwo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 17, 2025 at 10:52:11AM +0100, Niklas Schnelle wrote: > On Wed, 2025-02-05 at 16:40 +0200, Leon Romanovsky wrote: > > From: Christoph Hellwig > > > > For the upcoming IOVA-based DMA API we want to use the interface batch the > > sync after mapping multiple entries from dma-iommu without having a > > scatterlist. > > > > For that move more sanity checks from the callers into __iommu_map and > > make that function available outside of iommu.c as iommu_map_nosync. > > > > Add a wrapper for the map_sync as iommu_sync_map so that callers don't > > need to poke into the methods directly. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: Will Deacon > > Signed-off-by: Leon Romanovsky > > --- > > drivers/iommu/iommu.c | 65 +++++++++++++++++++------------------------ > > include/linux/iommu.h | 4 +++ > > 2 files changed, 33 insertions(+), 36 deletions(-) > > > > > --- snip --- > > + > > return mapped; > > > > out_err: > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > > index 38c65e92ecd0..7ae9aa3a1894 100644 > > --- a/include/linux/iommu.h > > +++ b/include/linux/iommu.h > > @@ -857,6 +857,10 @@ extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev); > > extern struct iommu_domain *iommu_get_dma_domain(struct device *dev); > > extern int iommu_map(struct iommu_domain *domain, unsigned long iova, > > phys_addr_t paddr, size_t size, int prot, gfp_t gfp); > > +int iommu_map_nosync(struct iommu_domain *domain, unsigned long iova, > > + phys_addr_t paddr, size_t size, int prot, gfp_t gfp); > > +int iommu_sync_map(struct iommu_domain *domain, unsigned long iova, > > + size_t size); > > There are two different word orders in the function names. > iommu_sync_map() vs iommu_map_nosync(). I'd prefer to be consistent > with e.g. iommu_map_sync() vs iommu_map_nosync(). The naming came from refactoring different functions, one was simple *_map() and another was iotlb_*_sync(), but yes we can name it consistently. Thanks > > > extern size_t iommu_unmap(struct iommu_domain *domain, unsigned long iova, > > size_t size); > > extern size_t iommu_unmap_fast(struct iommu_domain *domain, >