From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011FFC282EC for ; Mon, 17 Mar 2025 13:07:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073C1280002; Mon, 17 Mar 2025 09:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 024EC280001; Mon, 17 Mar 2025 09:07:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E074B280002; Mon, 17 Mar 2025 09:07:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D900280001 for ; Mon, 17 Mar 2025 09:07:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E52EA58244 for ; Mon, 17 Mar 2025 13:07:24 +0000 (UTC) X-FDA: 83231069208.04.54D77E6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 6E6A91C0012 for ; Mon, 17 Mar 2025 13:07:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aymI4rjE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Elm4+EKo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1ph23rw9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lyvw16is; spf=pass (imf21.hostedemail.com: domain of iivanov@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=iivanov@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742216842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wXVXYrKcw75VaVyW6xiQ1XmUEA3pjJuZesMTcpr9rww=; b=uROJYUJO6gkRWNhHuS4BoN4IqfJJQ6Yt2KiNnxP36oA9CeRxZ2xRMOLOs8+5eve0jaQNH3 xLFyvijSkiuooR0T0lq/uI4U5yuTErDt3Qc4Xu+w9R9XMSVzQ2M6jkdQMhiCkclQTVFxRV Z+u4nTEVmVWKMyj0qzwLrkwKnKItojo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aymI4rjE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Elm4+EKo; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1ph23rw9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lyvw16is; spf=pass (imf21.hostedemail.com: domain of iivanov@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=iivanov@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742216842; a=rsa-sha256; cv=none; b=0tCkHNaKLRN/4ZW+9iXyO3fMA6qn0VLF9suwuB1NH9shj7UDDI05zZzAdSqbhNxOfFOG6c StcBIRMyXNW1l1TkjqlIgpwHKEY+ICbUiQRmkdWPQ+TUsc2gNVtiU+cXvUOIY92fz9PnGZ n5xIW9XFL52Hn6pEnMA+E7eiHZ9Fcro= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C58421BFD; Mon, 17 Mar 2025 13:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742216840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXVXYrKcw75VaVyW6xiQ1XmUEA3pjJuZesMTcpr9rww=; b=aymI4rjEu3+nyRw0beZ1bFpJRmJaQS4GQXQ3EPzIDqGhzLpfTgDf3aCHSd/44MI36rZtMy T6jGhqeQg1k7bfh+/lac+3fgWFKGsTTQXFSrY4MH7WO/JvXf/O/yAQU58SDkCIhKOkiXBw l8NZtZwN+I3pGFUM9499NfJQ+tXP9rg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742216840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXVXYrKcw75VaVyW6xiQ1XmUEA3pjJuZesMTcpr9rww=; b=Elm4+EKoFdGcV0RQQb+KJqh6pX+QUsvYagvqOK9wjZYibOyahb4FzgdlExVwI4AfaB2wKA VtKMy9hq4iUuqZBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742216839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXVXYrKcw75VaVyW6xiQ1XmUEA3pjJuZesMTcpr9rww=; b=1ph23rw9GLfhlqnKiCJHfeHKxX6n/zT2ZxQIu/lkktJ8Vpag7s91+UevBrvoVOHhxAobaG sUARymTKGZj8Lx+EBDoz6POfmD3N3l3pP+3rD91Vik4vSlU8W/7/2HrwiHf2C30uB6iyxo WSJcd6rpyTQ1VAoG8QAooM54k+b0yB0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742216839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wXVXYrKcw75VaVyW6xiQ1XmUEA3pjJuZesMTcpr9rww=; b=lyvw16iswgg2RubQR4i0BrLVvr2zvTbD+NhrXCGQCXVFyVx31fJbQ4CfXKdBZndvCjNhwt tdQEcv7VVXk8XYCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2929D139D2; Mon, 17 Mar 2025 13:07:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id G4IECoce2GfCUwAAD6G6ig (envelope-from ); Mon, 17 Mar 2025 13:07:19 +0000 Date: Mon, 17 Mar 2025 15:07:18 +0200 From: "Ivan T. Ivanov" To: Piotr Jaroszynski Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Robin Murphy , Alistair Popple , Raghavendra Rao Ananta , SeongJae Park , Jason Gunthorpe , John Hubbard , Nicolin Chen , iommu@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] [arm64/tlb] Fix mmu notifiers for range-based invalidates Message-ID: <20250317130718.a5wals252gymjlsk@localhost.localdomain> References: <20250304085127.2238030-1-pjaroszynski@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304085127.2238030-1-pjaroszynski@nvidia.com> X-Rspamd-Action: no action X-Stat-Signature: h7jnr3dqfatf4u9mafftjj7tifyqbs58 X-Rspamd-Queue-Id: 6E6A91C0012 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1742216841-248144 X-HE-Meta: U2FsdGVkX196vD9lhooPjmODEXLArodj0pFbdGEH+Hr9AaYXVdv7TxZ6biSTsw4Vq1TjYixRCKaHVHY+x6vhD/LxgqNY/s+/M4sxk2ct9Kd7QA35JiPHBDeOvbl3wsWLPXl+9R7hjNLiloiiTE8XDZ1R4axhBu2N4RZWvqhdRseUE2S8NcUSEj+PDtACHnfrrYamDA9pKRo1BJ8dSin67TaUvWFyN8q9JUFQqZ9sk3ui4d+55shrz/sBC72qvdhvAoktOQwasQCc26UpK03T1UaJARy3kMqS0qfWgi23qTsro7ylYNF99LQho61WpAgK0ABu3+cIlzUFs/kXuwSqzneamkj4gdBRkHvno6AYg8TOZR9wF+2iYOS2HFghMszaxn1rQ4RwWlSsq6f5+U7AQEbVzMiHjEIazrAoS9d1YaFOYAkhuzu0O01UXYbgsKqrREaIxgcnuxeDdcXkKm1QOpWDzsI3GUG8UYzWgLdQ22KF+FSj6mz87apmfFnUqOUGifr+6MV0Gj1pTpyT5FHw4xG9/BphoeFjySBNJb3MCbOUCdd/S8s3N+rgFdsTLukba/WXvGF+KEg4w6chy3iOXpjIifdPOUP1Y0tTLyQeC7KXtyzoI/CukOxEb4FCCy+Zc8j5MtPbidmpv0+t+9JqomMnzA1b4dcpTBcMildNXpjOncnwRDiqjwbO7389GZx7R5/4aNLL/SFN0VDafRGcCmHgPTszYENt2LloelZoUIJAseXNuF97WHqEddl1n7YkDvWwtjNIqeXlrXBlwYZ40rGZ0z4z7TykrdEJgNLDDXaACHszAA1QVloMIaKBxayfwPM4QrR8vG59MdzlmidC3EtiWoJXlrRkvbQjfGjKfcj2CtqxtBXK61oWXm7jZqr2KLHrIdQK/+dtGETyvg6q2Q+5j5PyI8lqwQdvuTa5rj8K8tuQgXl+vf5D2ecCDWo59VqzTo98No7N6/8Xkxh YVTSuZmR ecGDLlRz1oXYPJBdgh93x2ygj4VZPWKx52xgrZhIVMxuE2iMTToko3Hufr3eXNqn5oshUVAsjjHHW9F3T6MZ1PegnrRZiCmmj+fZf+VdpKIFOGl/3Z/WJohG/78By7SUUENEsOIqch/fxvaxfYAsa0BABMd5L7fFsaLQjNj9CAjxHu8SoSNWV+Rn7mKZHw9hGLS412ALeRP6JUhGx0SSqQY5ZIsEV6uE6XR07YhlEdbJKJxISe8oSZSGBoLkyOoPu4IiscHgYRCu1agY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 03-04 00:51, Piotr Jaroszynski wrote: > > Update the __flush_tlb_range_op macro not to modify its parameters as > these are unexepcted semantics. In practice, this fixes the call to > mmu_notifier_arch_invalidate_secondary_tlbs() in > __flush_tlb_range_nosync() to use the correct range instead of an empty > range with start=end. The empty range was (un)lucky as it results in > taking the invalidate-all path that doesn't cause correctness issues, > but can certainly result in suboptimal perf. > > This has been broken since commit 6bbd42e2df8f ("mmu_notifiers: call > invalidate_range() when invalidating TLBs") when the call to the > notifiers was added to __flush_tlb_range(). It predates the addition of > the __flush_tlb_range_op() macro from commit 360839027a6e ("arm64: tlb: > Refactor the core flush algorithm of __flush_tlb_range") that made the > bug hard to spot. > > Fixes: 6bbd42e2df8f ("mmu_notifiers: call invalidate_range() when invalidating TLBs") I think that strictly speaking this should be: Fixes: 360839027a6e ("arm64: tlb: Refactor the core flush algorithm of __flush_tlb_range") Regards, Ivan