From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6DCC282EC for ; Mon, 17 Mar 2025 08:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB0E5280003; Mon, 17 Mar 2025 04:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3627280001; Mon, 17 Mar 2025 04:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB165280003; Mon, 17 Mar 2025 04:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8FE6C280001 for ; Mon, 17 Mar 2025 04:24:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1364B1CCCD7 for ; Mon, 17 Mar 2025 08:24:14 +0000 (UTC) X-FDA: 83230355628.02.FEED17B Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf09.hostedemail.com (Postfix) with ESMTP id 1F0F8140003 for ; Mon, 17 Mar 2025 08:24:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742199852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uXM8ZE9wVHZZ71vjoCHKJam/4XuB7pUl9UIdnw5dxXk=; b=F220mNE7F8kLUNh18vRr4PaUo3JqdIwY3V884nEUj58sEEQVMrDsN8T1q1kaZb5NLBqMB6 /ySaxV/COOVEfVGzpIn53tiZc7WCgpeKPwHIU3wX7jxYqVlhA8dUkxRlotRvH3mfvn0fd6 iz8m7w8DHGw+iCbc5aOreRy/bQ2qjBE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742199852; a=rsa-sha256; cv=none; b=l9ocHaPGTQnTTkAhmvCJIi85wrG56++0ZicgJqx1hKpz90VJf18KlYtLXTzvtF7TWIZEIz eoT7bFfQJaVRvqZtpB3iB5TAFKxZjnEJHwQlYaTOkIt8YDY5TfmY30SI7zkUxIQ+u4FtMV Fdgx+gPI0Q+sXEwNidCem5IEPF2odTI= X-AuditID: a67dfc5b-681ff7000002311f-07-67d7dc2aa1fe From: Rakie Kim To: Gregory Price Cc: Rakie Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Jonathan Cameron Subject: Re: [PATCH v2 1/4] mm/mempolicy: Fix memory leaks in mempolicy_sysfs_init() Date: Mon, 17 Mar 2025 17:24:00 +0900 Message-ID: <20250317082406.818-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsXC9ZZnka7WnevpBg+OmVvMWb+GzWL61AuM Fj/vHme3WLXwGpvF8a3z2C3OzzrFYnF51xw2i3tr/rNarF6T4cDpsXPWXXaP7rbL7B4tR96y eize85LJY9OnSeweJ2b8ZvHY+dDS4/MmuQCOKC6blNSczLLUIn27BK6MV+0f2QqWcFWsP/eH rYHxL3sXIyeHhICJxLO7P1lg7IWznwPZHBxsAkoSx/bGgJgiAqoSbVfcuxi5OJgFHjJJ3Jox gRmkXFggRGLdrcVgY1iAat5PuAkW5xUwlni14TwrxEhNiYZL95hAbE4BM4m7l16A2UICPEA1 +xkh6gUlTs58AnYCs4C8RPPW2cwgyyQErrNJdHVOYYMYJClxcMUNlgmM/LOQ9MxC0rOAkWkV o1BmXlluYmaOiV5GZV5mhV5yfu4mRmBoL6v9E72D8dOF4EOMAhyMSjy8BuuvpQuxJpYVV+Ye YpTgYFYS4WXZcT1diDclsbIqtSg/vqg0J7X4EKM0B4uSOK/Rt/IUIYH0xJLU7NTUgtQimCwT B6dUA+OSm99cS875mFwQYlrHwRA4W//fC2tV3q8zfJ+ELGtujv1i5TpNhblW9cj2L2ErYtKm xdtYfT3c9eYcJ+tPQdMfl8QU7I8dP79y1gnOy40dGmFLr9T6LluYWfbgbJ/B5cboGaVLihM7 JE4eEvj/PHk9n2tKWc2UvPCsHP3PWrH37jYz/fWYcECJpTgj0VCLuag4EQDklfQQaQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsXCNUNNS1frzvV0g08PdC3mrF/DZjF96gVG i593j7NbfH72mtli1cJrbBbHt85jtzg89ySrxflZp1gsLu+aw2Zxb81/VotD156zWqxek2Hx e9sKNgdej52z7rJ7dLddZvdoOfKW1WPxnpdMHps+TWL3ODHjN4vHzoeWHt9ue3gsfvGByePz JrkArigum5TUnMyy1CJ9uwSujFftH9kKlnBVrD/3h62B8S97FyMnh4SAicTC2c9Zuhg5ONgE lCSO7Y0BMUUEVCXarrh3MXJxMAs8ZJK4NWMCM0i5sECIxLpbi8FaWYBq3k+4CRbnFTCWeLXh PCvESE2Jhkv3mEBsTgEzibuXXoDZQgI8QDX7GSHqBSVOznzCAmIzC8hLNG+dzTyBkWcWktQs JKkFjEyrGEUy88pyEzNzTPWKszMq8zIr9JLzczcxAsN5We2fiTsYv1x2P8QowMGoxMNrsP5a uhBrYllxZe4hRgkOZiURXpYd19OFeFMSK6tSi/Lji0pzUosPMUpzsCiJ83qFpyYICaQnlqRm p6YWpBbBZJk4OKUaGFc/C6494HwxtPZMhWbY1vJ5csYtB5pLIgWua00R/p66wMJO6Zblrse1 00ItFKOmfclcZjvvu9jGt4fPFO2Xqa9IeeVz6X+15izWqxWKP4OOvVd+0WEzN3Sf++YTb5g5 6hWkbLd9uKHzO29u0eWn98+13chyCl35ldUlaaf/Jqlwvf5JO7y7bZVYijMSDbWYi4oTAUP0 dDFjAgAA X-CFilter-Loop: Reflected X-Stat-Signature: 1in3ie395tubrdwpusn1nwx7gpwpqs5a X-Rspamd-Queue-Id: 1F0F8140003 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1742199851-286893 X-HE-Meta: U2FsdGVkX1/Vb+8avQJHzIZrQiTcyyQEFrtAQzD281Y1PVc4TnELGSG4zJ3I/77Jky0s2NWlUiYuE/lgY1ljxgnPQFadvEz47Q9ljXbxJoSBcStBuc/46SJJeVaSG6cW6RwpHas4faOL0r8nD9Fvvg+vvf9RRnBzJn9BHTVzwk4WxLahro11DvXgmay0Stb0wOjyqHfiTl7gAKx9mBBMjsnA3ymmYyOlNLhKYc04dtB0zPXe4DcSmcCPLX1Xn6/ZpqucSN/aw51A2SRJJYz4w0/8s4XLIH3okOdFcniZsyLiG743PFdfPt3vmoVFDLSR54GFvP0q/S70OAJmqK3EATmHRZKQLvDuaXHYRopmvExBrWp1v8ijUIHqhzasC+9xjhP+UsC8FkpWOFsKbB2MBhU9ve3rgWCSOe+uYYi8qchv/zz/3G4TMQRBG8SqwmexkmNLkl69wNd5RTY5b1bTNtktlIlhKVlwMlF7Sb9pW+7+aM+xX4WqckSxfutn3o/swMU9Vmg6IqLurDs1+Mwh3QFm0jTP+uYHrv0KLNusfXWp4fxSjlscufxzsOcII80V3UkS8GUzD/s1CR6VnU4etALo9jumb3eQ76LnUen3gc3hG4viPuZ8nCqdYdfyQcQqfDeq2DUJSEsgMF9QNNXpjL0ho2px0gIGvLPPp83FQ327FzvS3hQvmP6JGqsqzullRHEcwhB+nYc/DGGVomkmv7FwRNAeYlusN5hu6acR7jcZzmZUFHEdjNC8pwa16T9zxgQUGUiYLbnIzloomnK6efdPJhH0EMAds+pSEq5XCGKBTB81sWENBlinCN/q1HCHurBjeD3JqMtqDVgj1dousexrg4JU9/jzn8J49oIjYxIlj2m/O7CnB+DwhwuT21DMdhF0NuSdyOnkd4UN5/9HMAjdSaGTuxgXvdzISHdV39a2kV9IOzz8+b7T1nlHgTL+nBAku3NGtYjpLV6FrjW +MpfCSev B1BS8BbMQ+FtL1Rjfuw33D32Hy0C8zNONReGDSl5TRTEHRXkSWUqPAVz0iCQPoiiC+Tk8mB7O/mZ9Z9vrgn4Q8C3U0fwm4MatE2yNSlEjLNIb+LljQs53qZQKuLWzJZF5v9FB3+Ztp3Kl702YHAe2YqaHow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Mar 2025 09:42:31 -0400 Gregory Price wrote: > On Fri, Mar 14, 2025 at 10:55:00AM +0000, Jonathan Cameron wrote: > > > > > > 1) allocate node_attrs and mempolicy_kobj up front and keep your > > > reordering, this lets us clean up allocations on failure before > > > kobject_init is called > > > > > > 2) after this remove all the other code and just let > > > mempolicy_kobj_release clean up node_attrs > > > > > > 3) Add a (%d) to the error message to differentiate failures > > > > Given how unlikely (and noisy) a memory allocation failure is, > > maybe just drop the printing at all in those paths - allowing > > early returns. > > > > The lifetime rules around node_attrs in here are making readability > > poor. It is implicitly owned by the mempolicy_kobj, but no direct association. > > Maybe just encapsulating the kobject in a structure that contains > > this as a [] array at the end. Then we end up with single allocation of > > stuff that is effectively one thing. > > > > Even better recommendation, lets do as Jonathan suggests. <3 > > ~Gregory Hi Gregory I will revise the next version based on Jonathan's feedback. Moreover, I'll separate this patch from the hotplug series and make it an independent patch. Rakie