From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77675C28B2F for ; Mon, 17 Mar 2025 00:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC230280002; Sun, 16 Mar 2025 20:50:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70D3280001; Sun, 16 Mar 2025 20:50:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A8A280002; Sun, 16 Mar 2025 20:50:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B495E280001 for ; Sun, 16 Mar 2025 20:50:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D69A1A1218 for ; Mon, 17 Mar 2025 00:50:35 +0000 (UTC) X-FDA: 83229212430.21.7F243C5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3158120003 for ; Mon, 17 Mar 2025 00:50:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="mpzZndO/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742172633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tqL70+lNHeHrrpmf9uP9nGuWiBIcujSbh6NoKQHXGRs=; b=3HDva0bgChqDSMiK3IXYkTiCh92aUMXrZWf9zevw2ad24vtm7EiHpWIDHvJKRgpjs79LZx P/tgsN0VYRGAZSUb+r0beTcyqfG8vhNYg3uiT5hDTlZhM6hJtx9tnyaIbKvy94zGb3Su/Z VgBNjEt8E6xzQoEFQ0sp/bC9Q/IJBfw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742172633; a=rsa-sha256; cv=none; b=Mn5HmeKXqECgbMB/Qnk4mAeGKY1L9pccEdAR7bnMtsrLKIifLznmTQTeV4D3Q/r+jkbjOE fRgc/ZJh9u3Skj3e9b9MeK0A8N2BRcs+fkeQFIt41Vyq08tiIMa8RZNd6NjyHlkEEPTF27 K2bri9gcRs2ZEge+Dj+vxWT9gEWXWVU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="mpzZndO/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D7475C062B; Mon, 17 Mar 2025 00:48:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF3B7C4CEDD; Mon, 17 Mar 2025 00:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1742172631; bh=/AOSe7aq0nChqdQRh86alo+MWwYHvaes5E17kFYiFIA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mpzZndO/iEMbjsNstWhXiw29qloZefDjGCjbdLzVbu8AWoIP3rbYu8gvByPEebqZO NQ94QS0uXpMoe4gHl20GGVqOEHi5wEnf+zVu6U5DIoTK8/zhixuSeyc7J4gmPPZhtv jLgyPg2YA52XiVmTXCDcz7B6AaOcaYYiNRKZnq6w= Date: Sun, 16 Mar 2025 17:50:30 -0700 From: Andrew Morton To: Hugh Dickins Cc: Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jann Horn , Peter Zijlstra , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , linux-arch@vger.kernel.org Subject: Re: [PATCH v4] mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables() Message-Id: <20250316175030.e929cab808c976995ec662b2@linux-foundation.org> In-Reply-To: <61e3ea6a-368a-640f-a050-b56c8d3232b5@google.com> References: <20250127195321.35779-1-roman.gushchin@linux.dev> <61e3ea6a-368a-640f-a050-b56c8d3232b5@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3158120003 X-Stat-Signature: 53u8hayjtt11u3pgug574iaceodk1z93 X-HE-Tag: 1742172633-317032 X-HE-Meta: U2FsdGVkX19+L/uV0NIJ/z61l4/w0d+72TLsDf+xqUsi9OGC0H7xXTgShBKSmjwmzR3YbV9djgzgUvDYYRfIoQlRxj9/MLSUiS/DtudDPMRz66lMCw1nowCKsfSZDcNyA4mlnjw8jTwvvyJxkG1iztOYxsbf9wxjqeCIiKAJlLwqRnprF4FUCKwOWtXhH1NUcWy8HL2wtm12QeE8gwcuHR9gfwUYszHuQs/bUfMis7wl6kGyxNMg096dwweChiDGgrRlKO01xZ5pyXFu+qNKX2U80vUUvgBo0gvx7/cLXcDeqo0NiZXB6Nm5jcEWvE+AHcjxPz0JV1VVLc9aWHZx1wBVjDFE4Gx3LxUbDZqw/s9SaDH6w5e0xIB/fVKidcR7Vw0KSgLcF9ji2le7UBVp/YrOlXYJELaums0m6lLsTzSssNrGYGs9N2xMuEBiexohsfUWzy6GC++cbo45YJP4sCncRYMQH+6cgfYmDXXYoGs5FryqKY8EPUKYwFkljVK+tpB8VCmreU83EzYHDL62SIh9VmcNQk9R0gmNckbFKS7o+GY4oPvS8Ixpd8zra55S+rkKm5gdgttIXUo7B7Cl6Mk9C2/l4Uwpsc383VZ0pfiKzfZorujkOgXxQ9+tIV8aoX6kTvpEonOFLbEe8ElA9Zd7P22rODEkS/UHx3eqglcb65+N5aNTRDkzFThqN7n0qwKfiJOyaoxb+AEu0BItITGweirRnriCsX1sNmsPanWNtbtHApFmhtk17LclrnOGe+s8dGoZzSc/IRUTy9PILAJ/gECKBxvS3S4ePu+P1MuRAVnao53eBGk+KisD/tCTBULLSbc73khuBYNFgIl/XUyVYn9Xi9bFm8sLoB0LtIPALsMwBtyZEA0B1KRmcgvCp9a9RevUj85OQ+aYuDSzW4n+4/2f0tFxVPVLUjEVx/hooNpoFdCj9zTI+2SuSquHUvnav2KaxKQ3sIIYhxF aOraxUW9 1daGa2/jr54SXqvMG+1xIcMZPlhRT4aNSr0PKvJAM3pTjzHwwNsnYR2gEtQP8k7bYytYJ5awepJj/EApeYWlgOE0gwStUday1iw1SiXOHt7Wj6FXO6lJVqhmfK5egKtD7gqceGSPczqb15/mq2/2BXjmQF5KWAesp0rouzxKzDXi0zVplMoruP+j8DMiqQy5J1xZC1T+bsFOW19ykRv6dR3Era0PCva6i/EifEVx8aT2S0XfHDc17hpK2L8WBJYUNfprWo9mYHcs4F2dJ6fHNtdXIS99bwkFVIXBaTGa0bv8rfH29qTo4RbrKNWrDf/gKOQz6SyYInbSynqp9hktvL3Tq7HNC0fDzhsFaijBI9+WfHT6cUK5ZXI4jfZQArFjOHIq0/1jUNMCThrYNHhzj4sGn3GCiFndXH+sp2sG6LfgJMMOOnrqV/WPpeANka4zJTmNkq8I3mjPT+AobPw9R1lCp9X9+vU15rSBHVDFkvffyFUX4sS3w+lhrtfR9dp0IWwi1HFg0QX1cdYg+qM8NC77VTsHyLgFvSVGjUgm35KO2wuA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 27 Jan 2025 12:55:11 -0800 (PST) Hugh Dickins wrote: > > Fix this by moving the tlb flush out of tlb_end_vma() into > > free_pgtables(), somewhat similar to the stable version of the > > original commit: e.g. stable commit 895428ee124a ("mm: Force TLB flush > > for PFNMAP mappings before unlink_file_vma()"). > > > > Note, that if tlb->fullmm is set, no flush is required, as the whole > > mm is about to be destroyed. > > > > Signed-off-by: Roman Gushchin > > Cc: Jann Horn > > Cc: Peter Zijlstra > > Cc: Will Deacon > > Cc: "Aneesh Kumar K.V" > > Cc: Andrew Morton > > Cc: Nick Piggin > > Cc: Hugh Dickins > > Cc: linux-arch@vger.kernel.org > > Cc: linux-mm@kvack.org > > > > --- > > > > v4: > > - naming/comments update (by Peter Z.) > > - check vma->vma->vm_flags in tlb_free_vma() (by Peter Z.) > > Let me just put on record: you were absolutely right not to extend to > this the Ack I gave to v3, this v4 is silly (tlb_free_vma() and its > multiple calls, necessary only because of the unnecessary extra test); > but I don't see it as doing any actual damage, so I'll stop short of > NAKking it. I think I'll just drop this. Let's revisit in the next -rc cycle, if Roman is motivated.