From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCF6C282DE for ; Sun, 16 Mar 2025 03:58:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBDF5280002; Sat, 15 Mar 2025 23:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C85280001; Sat, 15 Mar 2025 23:58:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5B12280002; Sat, 15 Mar 2025 23:58:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98505280001 for ; Sat, 15 Mar 2025 23:58:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 532C8160564 for ; Sun, 16 Mar 2025 03:58:04 +0000 (UTC) X-FDA: 83226056088.27.8B1969D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 8E327C0004 for ; Sun, 16 Mar 2025 03:58:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IxhMmR7P; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742097482; a=rsa-sha256; cv=none; b=iCyvPJipE3jOQvg1np5kiqKugLuX+0IUl/LIM4Y8Xtj4+GznUam+6Ir7hKLHpg8WbfmgSS +lA+rM7MuD1KCXCV65b725RZS5qL9wuQFOlWg/huEXBQAfPSQVj1vfD9npjtMMbasQaVaw gItV08FH2yhVpg3DQWtMjDY5CmpQiOA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IxhMmR7P; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742097482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I8FUVmRWNUzntcfsq7AZFfXMbN3CD9+rR/UPHYPhcSg=; b=EsUXr4qMuYHtQiDPRXW47KiRM7KCdJQzJrJ5JFiscgJTezta5COCGplEcHy6iN91MsuN78 pjF+heXh+hGnfRj6Ulslx2knIqET+OIVA+6lp6K/fp7AYKRej8rKdOBhwAS5OHEGMOYBg6 hWvrh4ho1FkGq4xlgUfMYEQLQAf5ME8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 059A2A4571C; Sun, 16 Mar 2025 03:52:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ED42C4CEDD; Sun, 16 Mar 2025 03:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1742097481; bh=9FGAGyH1LQtzxfMA7xgcYqIxmi2gZlRJ+AD9AfajveY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IxhMmR7Pjglyh5HkeMOcVf8apu8/nF7EdVW8Cxpnv4SAAtW2l6N53sXuhJnhTtSCT Kh0X7xTw149zzQ9JY1nveMUeR9IvIRF4iOCjw+950g8xDHLyCImdOWxTmVGX57U8Dv DyQzCL+Rw2epAYaxwjcKCqcym24hLCANDKnGKk0g= Date: Sat, 15 Mar 2025 20:57:59 -0700 From: Andrew Morton To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 0/9] memcg: cleanup per-cpu stock Message-Id: <20250315205759.c9f9cdfc2c20467e4106c41a@linux-foundation.org> In-Reply-To: <20250315174930.1769599-1-shakeel.butt@linux.dev> References: <20250315174930.1769599-1-shakeel.butt@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 8E327C0004 X-Stat-Signature: 1t6es9kq8idww71agg569h351h9kcnma X-Rspamd-Server: rspam06 X-HE-Tag: 1742097482-843410 X-HE-Meta: U2FsdGVkX19uTPU6xxcoH9X/mslJwYhh4GPCR1bLNzqV6fIoMKlQiG07UgGxIH78dMUKKpgWmJImpXsEXwvM5RB/lxYpMmXioWl04DFLZ+qv7SvLYpY5A95IteWRA6bYhCI+JnKDIGVlEuff/PCkgcl/bhhFkD4aH/WBdRPoT3TUBRiDPTLZwXzTioNfjU2TOPzu78fbG/GLzddvfrPHlhOzIUCM1/E50Sj14akzAniFBXhTMT+LTP2f4eNLyhIz/q5GIIYsrg139j+SX18MV66QBsQJ95WudtK9oWEHVXjvd0PYs8t6N9Y5OgzcYl57dL9jhS90yGCHrd9scuYeYiGswieCXdv0ZWlESlPMTl6Os+SNLYdQjf6wHn0r/q+z+7Rfu9r9kau5RZ6KVcAOX5xSUiB6rtn3ccpyXZBvTl0vVtDN7o1jF6sOdJaY8qipHe94ja3mHgIy/BTsmSSbauN5fqe+rFYC9YukKJl3hTrjClZk6CVSR+17MFpOGSzJlAaScuvdwT7m9NkarNTTFBiLsIu2wqOOK1OkQGUhGvRICvC6ZpPnt4f3MPUbRJTGy9XM7K0RjcaA4i1SCNm6HZVmFi9jPRTvBwrRddJyKiLoKjMKRPzhI27HD8cSy4hfIq+hv2t0aCAstvZU5/ZtC2/YFAS65XTLpsG7V6aCr20lJzVpzjsXFoFMvaL19Ui1pvXRIjw9CPzdpvU3pglstT98gwzW4xlntCMgiMsR9JSZLMHK9RYZCQlF3YWZajH2qHJxIRu0YU8WjhicVqWbPWrbMQdyVOXKjxPnMtQHpmtzS5HWFfbjwCfqldPG+pbsaBXU59Hf2rAnRbZJv2dXBAv399Hv9gpjYnythukfzsMxkc+sCGqYrKmKzkV6wO9iGQZElzuZt8/vTG9CEFKLVuO8jAs1qh20PTIZjl4PZxjzp7Gtc6czPpKQPZhJirQ2bkyhNAlQNm+3hoeWZtp CPZ6s/2i KRY4BaQXg+F3U+oBvy99S9K0576pOJo4PsNxZeJNWKZN3wciBl66AokmOg5qwzy6UtiS3nngjuhu2WGQS50brjldH2GQoOKsUamwgOIc4cOveJegSwdoasY1VhnE+TyLXsB3Nbf03NNTwKREU2h+dNM+r8qI5m0zcd9uz7voFx2CnsPEzAbCIV2r/obxxfZAbbrFRCwVbApw2oy5+9/L1taVlNHX2mnr7ORwgrjApDMSXHeiFVVgUCPcwwmg8eqcjedJ3E31NSYxLK5Am5MJDXlNO3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 15 Mar 2025 10:49:21 -0700 Shakeel Butt wrote: > > This is a cleanup series which is trying to simplify the memcg per-cpu > stock code, particularly it tries to remove unnecessary dependencies on > local_lock of per-cpu memcg stock. The eight patch from Vlastimil > optimizes the charge path by combining the charging and accounting. > > This series is based on next-20250314 plus two following patches: > > Link: https://lore.kernel.org/all/20250312222552.3284173-1-shakeel.butt@linux.dev/ > Link: https://lore.kernel.org/all/20250313054812.2185900-1-shakeel.butt@linux.dev/ Unfortunately the bpf tree has been making changes in the same area of memcontrol.c. 01d37228d331 ("memcg: Use trylock to access memcg stock_lock.") Sigh. We're at -rc7 and I don't think it's worth working around that for a cleanup series. So I'm inclined to just defer this series until the next -rc cycle. If BPF merges reasonably early in the next merge window then please promptly send this along and I should be able to squeak it into 6.15-rc1.