From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1467C282EC for ; Fri, 14 Mar 2025 11:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 738D0280004; Fri, 14 Mar 2025 07:47:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C1CA280001; Fri, 14 Mar 2025 07:47:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5886C280004; Fri, 14 Mar 2025 07:47:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 373D7280001 for ; Fri, 14 Mar 2025 07:47:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 99A181A0F5E for ; Fri, 14 Mar 2025 11:47:04 +0000 (UTC) X-FDA: 83219980368.17.9E209C1 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf11.hostedemail.com (Postfix) with ESMTP id E6F3A40006 for ; Fri, 14 Mar 2025 11:47:02 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=brbl5Kzr; dkim=pass header.d=linutronix.de header.s=2020e header.b=J4RAkdwY; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf11.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741952823; a=rsa-sha256; cv=none; b=Ci2IqUhfAa3tc1FkOqo1+bG10R+7qjEh47c/w46TEHQGfUJSfhPbvRPBbX8ln4lZlYUH8f ZAHxMF6y23mu+MfLic+M5GBEoRzlYAWnTEqe5LRBAFd6JCjKKU1Y7+jGj7IY/9sIYIjkzL dUm3fJ0Wt2S+3RxS3Pr2D2QQkBi1ZpI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=brbl5Kzr; dkim=pass header.d=linutronix.de header.s=2020e header.b=J4RAkdwY; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf11.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741952823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lPFOTPRd7Z85FnKRS0cTn5GgupBXmDpYhiKtcCMp6o0=; b=qC0id/M1VJ7vbsvKa+9wscHIDhmKkOT1bxa/k0NL2FVAsNoseOJ/Bmwayu8br2oxpF79Mg QSTEDjDxrVJ2G7lYKFGXunQ0l/G/1lMBAWudiqXfYoUkiiivUnEKf57JPcWEa/wEE5GfnV McSTTs7xSARwtZLzmzOAuVF2DQOwpMs= Date: Fri, 14 Mar 2025 12:47:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741952821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lPFOTPRd7Z85FnKRS0cTn5GgupBXmDpYhiKtcCMp6o0=; b=brbl5Kzr7FFK1oFrldCAgathJeQCaROFZpRnUkEmMhtX6StBIfjd1rNPYkpBds/CT56svh 5ajvsS7TCW1GPm0MNuIiLYhCgU9oH6ykHKudw1YnJKglRQlS6B5KAwH0hOjuK95/CS6T8w I6y2lMWbUviZbhH64Lo4L+jfVcYIkRQ6PsUK4wJwieT65A1hXmD/Kb0IdCQj45Y84wCD68 lB1r7Wt3NgRo5am22H+/y9B41fquuJrHEsCW0JJDWiFkQgXGaZHAAyJ+Mtu6fCCuVqeC0I BHr5jc7pJEJ/pbLcZHT4YQhHNjvrbxYCoM0wVbhKOQ6oO/O2BZ4cc0OWN5252Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741952821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lPFOTPRd7Z85FnKRS0cTn5GgupBXmDpYhiKtcCMp6o0=; b=J4RAkdwY9BJI342ztprMtM0GCDZb/4KAR0KYVuXhvmt53e3NZy1k+Hg+Nfy914XBfdRCOS Zyxnl8TAf1gJq3AA== From: Sebastian Andrzej Siewior To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 09/10] memcg: trylock stock for objcg Message-ID: <20250314114700.TiLB4FH0@linutronix.de> References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-10-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250314061511.1308152-10-shakeel.butt@linux.dev> X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: iqmb3ib8irm4n4um4e58ag7mgfjt83j5 X-Rspamd-Queue-Id: E6F3A40006 X-HE-Tag: 1741952822-900565 X-HE-Meta: U2FsdGVkX1/ofJxw6Dirzav0TYTUSScskjey8i6U3+JXgGDUtxxnvCir0meThtqVSQRPcH52pWpatipIc+oVuA3O1DTmKKOguy9e/2ZCT89rsDQsspjaD846p+WTHZy8v6hj/3kocODSlKhSTWyOEGXyk9y98Dsyd4GxmUdXoRATdl4IUf/X09MyzbBiMfmLAqriBzXjmtqEHt4QUz16AaxFVRa55EDhJk9TcoJRjGm3wxygVkcy4qNIDYELH4EbcKOAp/KkKlzBWO2p/Wy2jNBrl9mwPCZBx7Dx6phabmBqoozA6WJFn8+05xJsCWWSYQQu+WbKU3bdHrGo87oVc4U8+lXhel5/h7qIupnAMEcY09Y8ohQC7CVAzjQDJ7w0+hVn3xwmd296oNFqAWSzgP/DtIcUUiu9Qs5mXhaT7HGiB1XO8/weLq/c371/eievgX8nhGm3RbvL/r8S3W7XPH7DlHcbiZ2Epro8HkL/2ZwIOwYUcD7wCpBh4xzyg7mNf7ly2zngfAzslGf7AqW3QL8DPYi0pslLw2xKWnNs90myOzwXH0Nivnxb5TViNhul4ezpzWpOjI1975F1jNw7zdBe5EYDSPHQChMx510lmkvZHg1oz+7Ft7alONSIRNblDs1Rz0WjgRuoa724zlAtxRuuF9/ckGIDqRKxExpLa38YJOZmaMtqZlMqdEiM/CMKEbpYVMiKv+PUrOauMX8xLGabqxLWQ4DYGQkNkCu9rXCi7y3oKmPGEMO/jTfslG/+pc2PWCU76OwWbByd0prk3bgbWjnwIIwLODcMa5qEUo/QhUBjx3UYGvdhVJ5aXxacg2kRdGZVDcDNsYyFN0IZmpu5IYjIJaMiP50Eds+13GB0cpziAQeGwU3VP6snD3tL+nHQRF4rUPvqo+BR4ljEtHI8egkVM/poeRpLgSzpVcch4GRhz20nP3C9dnu3lPZgOcf9ft+etDMH1YLgVM7 XtMg4Xld EqsIe9eBXN64favCEaYFjwV//ZcZdqBNVZAkwWg48CSonT+4QBr53Q70eGnWmkZHRmh0FxORvUqfeHXgfcO+47ClXwKIwTAldQ6VOVMLHF22LZMCeuNEGseZ0jU8u8RyxiK8PAFYKLGM6Mtpvzpm0FXnpYZt9AbSa2bEJ7P/X6PyMfZBRo7DiNzxFgl99nHsrgStg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-13 23:15:10 [-0700], Shakeel Butt wrote: > To make objcg stock functions work without disabling irq, we need to > convert those function to use localtry_trylock_irqsave() instead of > localtry_lock_irqsave(). This patch for now just does the conversion and > later patch will eliminate the irq disabling code. > > Signed-off-by: Shakeel Butt > --- > mm/memcontrol.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c803d2f5e322..ba5d004049d3 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2764,7 +2764,11 @@ static void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, > unsigned long flags; > int *bytes; > > - localtry_lock_irqsave(&memcg_stock.stock_lock, flags); > + if (!localtry_trylock_irqsave(&memcg_stock.stock_lock, flags)) { Don't you need to change the of memcg_stock.stock_lock? Didn't we introduce an explicit different type for this trylock feature? > + __mod_objcg_mlstate(objcg, pgdat, idx, nr); > + return; > + } > + > stock = this_cpu_ptr(&memcg_stock); > > /* Sebastian