From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A41C28B2F for ; Fri, 14 Mar 2025 11:38:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4940280004; Fri, 14 Mar 2025 07:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF95D280001; Fri, 14 Mar 2025 07:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC25C280004; Fri, 14 Mar 2025 07:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9D69A280001 for ; Fri, 14 Mar 2025 07:38:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ACEE680F87 for ; Fri, 14 Mar 2025 11:38:57 +0000 (UTC) X-FDA: 83219959914.07.BF11BD2 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 0A1401A0005 for ; Fri, 14 Mar 2025 11:38:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ih4I3N+v; dkim=pass header.d=linutronix.de header.s=2020e header.b=XLCPgL4T; spf=pass (imf19.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741952336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UUKSy7z6knz10WLm50dw1U0p3v0ZGMjBuqkfU3chOP4=; b=60Lu/zi1M2hTNzNWUsGvivxRcyeFh0o8DzL6XVYSvgfiE6ICkd0A+28+Mt1zOMmu1e10jt VKtWBiAnkMMfTcmGwABzeyEefrLZgfkdRYOOi4Z4pPBddcoqpzAPT9YgFCMWo0lmDLzkxM 2Fc7NDaqJbSyRLrU4QuEqsls4CS0yEc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ih4I3N+v; dkim=pass header.d=linutronix.de header.s=2020e header.b=XLCPgL4T; spf=pass (imf19.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741952336; a=rsa-sha256; cv=none; b=qQyRzwbHVEv8c9+inoBcoCdydnjux7unO/tZHdlWEZbgL4EX+ZkCsAXc+D6vwwFYo+yCFb TRPVyS2aAzz9ZNxwMCXxEZo43VrJIKZIyvyUl4rHm5W+R5hYQMb3CozWwtcKGwXgy3MxfL 5W70zzn2Y5gAcMlPsKOKuy2JOT3SO9E= Date: Fri, 14 Mar 2025 12:38:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741952334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UUKSy7z6knz10WLm50dw1U0p3v0ZGMjBuqkfU3chOP4=; b=ih4I3N+voi1ZC4I+jS1VH+ZZwB8v8dgqMzo5PZvx9VCBvy01qODQzVZNjPlnosZWfVt9FY fHJnIlFCow7iwxKiUlYkUA5XSU4NZcYNv6cw0oSYcr4FR2ik2m6HyXVtgoKmVVrhhoY0CA vlO56eEmQK467eDaZU0E4En9ERVQvMYv+3MLvALjCBkHOGCBC1K3ZK6frgmCC6RCCehzIX gTTVJRcq8tT2RKHhJzq0N6ITFHXtedrpaGfmZEMJergiWzZmUROZZevZUshp6Jl5iGAznW 2FHL9FrAnobz3JtWz5FpG77h5f205z9i9bW+kLW107jD4MHXI8hLriO6JXOVlw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741952334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UUKSy7z6knz10WLm50dw1U0p3v0ZGMjBuqkfU3chOP4=; b=XLCPgL4TroxdqQG2xY6MurgH9susfpQpR3PEVjibPzp/bApY+hKz364hQ8XCO6DnxPCZmW ARr0VyTFEALfLTBw== From: Sebastian Andrzej Siewior To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 07/10] memcg: use __mod_memcg_state in drain_obj_stock Message-ID: <20250314113852.O1pm0QWd@linutronix.de> References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-8-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250314061511.1308152-8-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Queue-Id: 0A1401A0005 X-Rspamd-Server: rspam08 X-Stat-Signature: o6pneyayf4nqunretkwn118wgnnunxkd X-HE-Tag: 1741952335-153598 X-HE-Meta: U2FsdGVkX1/uPoihY66Q7VdkliEn4m0qhfzPNYr41sfTF13F7lwCfG3tl/V03Hr23WtNJu0xytBPrziADr3uxO8qmpV7B+mB6h7PmwDe0Coj6Fr+eza7fbvs+H9VQQ/J1bPpD4bGFCh0ysSgGm9kPs6L363eogIoeuMZ4SiAXTCDCH18/y6cjCUBuIVarMMatEbLzHTSTsAmag5fSRYP2oEmfJgLvzUArzlaNpcoBqJ9rKbqJKOT3Nf0IqG/5AC6G9DSuZuz2/NVyzo3FiqGlVbyDtkr9nW0f49tmPLr/+8AwReg04otiCalUsTjHjsJ925X9176JEXxlPWl+T+/FUUaSVtw3GZBcP/Y0EeQJc00e9HJW3EIjUZ+5DVxzB0TcNB/OGLJqYjS7uJhum2ofrA2MMDJg/0kSCeCfR335M66rhunbNstL1iaA9ajg55hULB8qMsGZH+2+GFs8i6uPV3Wr8hJZBxdIUMoh49fcrET0EleTt6g/kjhk8zZ8JCBwJJLtMG1pXNaUdUZv1NQPZQdA9qgBtruovne9Wmr6Tig7fgLTH4WmmyO7NVs+gLJY8p28RKyUoQ/tutYGU3lNdiIdJA1niFb6+PiMGh64IOalIRaCpzPdCFTg3HYAyFLyCG2KxTkl4qxbdkLkYULSDwkcrmmJdg2Ay2floJvukxcP3+L0xp90lcS6eGA758v78cTUE34nxenG37wD2rMYIhK7+thNTb3YHzqD8/NoK02VaRpn9njJ9Z5/3DVjPKm43/8tY9aAjoPNpIE7AKhbmKo2iXpx29EI28bLC5cLYSr5YLiCZ+HP9pVE7gPeNF/WLGTcPM90HARMSTeeyUeb5gORtfbN1wZpKzb5TMHA3JxgmGiENJ5aQzqcVR+nd6Z4NRx/FmFZYj05nPgOABc0cS1uZbaXYZtzaF3ufbWIIWX/nAB5qspfCVNNfApfDaDJxbDVN0+lgD2RHDXzCc nsIPGLrO P8OkOL+cNslDwOLFGKPD2PxvL8yMIeMli75agaUyskg5vVNZyJPDlhR86rde8LFIVVezN0u0d1P1xDvYE8Xnba9HSiZeo/qK5vUZeu/0dvlXk1EP08dP8NC6oyHJkhw09zjDA293snZOdqNDqZWG23lqujwmp2jbM8xYJJ/9N2C6WmWZy+LRfBtsxoxGDn1Ik5klSh1U1NiG3jNKtS2Ry68OnRWj9g1Hm9sKay3PG1HnyqHY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-13 23:15:08 [-0700], Shakeel Butt wrote: > For non-PREEMPT_RT kernels, drain_obj_stock() is always called with irq > disabled, so we can use __mod_memcg_state() instead of > mod_memcg_state(). For PREEMPT_RT, we need to add memcg_stats_[un]lock > in __mod_memcg_state(). > > Signed-off-by: Shakeel Butt Reviewed-by: Sebastian Andrzej Siewior Sebastian