From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8155EC282EC for ; Fri, 14 Mar 2025 10:12:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DF09280007; Fri, 14 Mar 2025 06:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93C71280001; Fri, 14 Mar 2025 06:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80531280007; Fri, 14 Mar 2025 06:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 61BB4280001 for ; Fri, 14 Mar 2025 06:12:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 67590C0E27 for ; Fri, 14 Mar 2025 10:12:09 +0000 (UTC) X-FDA: 83219741178.19.E1AB054 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf29.hostedemail.com (Postfix) with ESMTP id BE640120009 for ; Fri, 14 Mar 2025 10:12:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=j3OPGuq1; dkim=pass header.d=linutronix.de header.s=2020e header.b=oJvFa5Ks; spf=pass (imf29.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741947127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kYS1RJxvJHh0hu9vWb4sB4hfkU27Q11RTGqBr1jOQgQ=; b=bsfJQHb452ezLPJ1dTZ14ipP7LS1bKt0k3kGZFeJG0Y5xyaWxVBnlxjUFqroCB57aBe92v XYCgsxRaynIQlrllBsNNAlCf2o/c/7HA0AC7PmL09HlAGU7lLSeuV4uUsKZflf8gFXplbo 9mSFFU+Uf/sdnBIW5dWFMB/ftFBlv7Y= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=j3OPGuq1; dkim=pass header.d=linutronix.de header.s=2020e header.b=oJvFa5Ks; spf=pass (imf29.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741947127; a=rsa-sha256; cv=none; b=OBpzre1ITJf4EbnET1o0hTUDKTCnkvYeTDJVphcQKux1mnj/0beb+gmRWltKSzI8Rx03Ow q34O59Cv6zEgAlxLXhzJTs90Usx9bp96e31UpG0NmTraWSVWm8ylHTfLQhmoSEU8geJO67 u5iTmHIyba0sS3p4CVlynVW2T9xvLi8= Date: Fri, 14 Mar 2025 11:12:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741947125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kYS1RJxvJHh0hu9vWb4sB4hfkU27Q11RTGqBr1jOQgQ=; b=j3OPGuq1UCejnGrtjun2YET4jr4Y7+sMOJ6XxQqeDSqczADsE8bLWxn54y9vOH4z2mXNBV AR6YV3MitGqqxuWSxXmYdYiV53XvBCfHWgGARUXTOc47JcqrCdUvyABlDt2iQJqjDq3NPQ eyvUjaw8eUx+MbykvhVZCiplygPwRC6BrnrAw2IvEgR0KrZtOiBj8iv0SWv4lyzre8pBz1 nNdJ3DWeaX/58WRet30Gz4MklkF+jE5pEyXZHn/E0LapThLFaYotw/HAx405wI7203HVLG jxQyDW8ffNrw9g2c8jr2ES7o904qfspMrcB/o/MxJ1XwFmmMbh9pNvcKj5Fz6w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741947125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kYS1RJxvJHh0hu9vWb4sB4hfkU27Q11RTGqBr1jOQgQ=; b=oJvFa5KsEN2n8jKJGh4JFF/+GwsZGWSgxbqhOlxGEBNkGKySTmKicYNDCwgYH6ZYJUGwm0 J/BWSDRfWNCIJSDQ== From: Sebastian Andrzej Siewior To: Shakeel Butt Cc: linux-mm@kvack.org Subject: Re: question on memcg_stats_[un]lock in memcg code Message-ID: <20250314101204.0mN33UpM@linutronix.de> References: <5eqyqywhpgtpulqgnqyvpjivwfasbytgfrmum75ikvmsyhsjzu@xudzfvenzhzl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: 77uki9aob4k9rgfpoosuwqoxnbxhogc8 X-Rspamd-Queue-Id: BE640120009 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741947127-378703 X-HE-Meta: U2FsdGVkX18y0w3hvIatHlhOTdjGs+9V0HfkUzU7gO4lhxofZbQxEEk2j/gwJGqz8NXcTugCjPslyMNKolQjUVAoVq1IrMyFOEhVgnALknVxDAAdwcS+97l+8nWly34oYGiHzqZ0yanmnfKabzJ3093IrNO2n7JKt1Lcr7smv20Wtvq3A8bKUIkSkhyLrbT3ne/exPAU7JZ6oHiQWNPznlC5O9wOs5LQMVkTZKMG/05uQW7+qM1e7hDlfDAlxeOpgGfy18vnj2uuu4wZfd5hRLBJR98Hrllu/To/KNGMBjFoAJo9Fkx0nSZ7y2VWd+RNpQqw6XN7eKG5KvHUyoCJzHOM1Sdfe6sEMVycSydYaeKa+rQZgiv0Qozv34VBNccQJz4XtxnQh9wygpRCFtumRiwKvJ994/705ANT+uQbhrnHkNZRMo4JHdW1lusISiOOh+5mPiLO6ZFWBGKEcc32hTCA5OoEHTsF0eUEC7ZoSA2+QW7uzNkSSX7klF+BRTCRNkuVVH/ZHwfLjWQTCW9+ZvMbyHkCazhBGYOEJt124r/y9pWku1VxPgj8PVmFr5to+rw/Tp79Gut9izMZ67Edi8VjxHMqL0xqg8jcNOwIBngtH8VythfPYsgx+EMAfdlzGHTdOPYR69ZuGnHV+CWxtfJTRCaKs7tRarvfLsZc0vGqa0nRqm7eoywc8/t6KgCj3xdNsInFWLSsZZDtlrntsOk89QSkPk8GO+vKVbCklEZSSB9mxbtEev9Ps8z5HNyBxnvChkI/vSif5UQsPsjuC63OD+95vy8T1jmWoN9WQOEW1n3jovt2IgHYwuUYCFb+onJ5uDqzC/ONTxt9AL0pofirv8h6iMfvM8JPnt6+BZH8Zaed5haeFEaZRhNzX1kSoYX25OHk2Oqim7xXBfIKVYRNmvABeU4FZsZe2wNoJlZulDlIpZ2FQuBjgL9uL1bl0t8+8us1nW0/VrBrFkh dXBSHj3T TIf2xGjW55WXxSS2yo9Ejg4T+EM5wfivC4GGpjciZPfP04keop6Zh6h3eYT7KLyqCuNvFGq2viWKhHEYcWhqX0K3xIThZ+vHH/pboBhAoMrF2J/aLvSiExV0+Ig5j/GlIAJpyTYV63jlADVt1IuBddHtrq5c2zGBTqPRxl74OHqZ4g0bvSv4FKHHNuiB5KJZThW0QligO78BBPesRcceeCDrzLwB5LNNznDhPyNUbglG+o/A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-13 18:46:53 [-0700], Shakeel Butt wrote: > On Thu, Mar 13, 2025 at 06:11:30PM -0700, Shakeel Butt wrote: > > Hi Sebastian, > > > > The commit be3e67b54b43 ("mm/memcg: protect per-CPU counter by disabling > > preemption on PREEMPT_RT where needed.") added memcg_stats_lock() and > > other variants in memcontrol.c. There usage were added in > > __mod_memcg_lruvec_state, __count_memcg_events and mem_cgroup_swapout. I > > am wondering why __mod_memcg_state was excluded? > > > > Basically I wanted to know if the reason was that there were no direct > caller for __mod_memcg_state and something like the following patch is I guess it was omitted because the only caller is mod_memcg_state() which disables interrupts prior calling. So this is enough. Now if you add a user then you should add the locking like in the suggested patch. Sebastian