From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A85C35FF1 for ; Fri, 14 Mar 2025 06:35:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA898280002; Fri, 14 Mar 2025 02:35:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C57DD280001; Fri, 14 Mar 2025 02:35:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1FCD280002; Fri, 14 Mar 2025 02:35:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95285280001 for ; Fri, 14 Mar 2025 02:35:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D171C160BE6 for ; Fri, 14 Mar 2025 06:35:29 +0000 (UTC) X-FDA: 83219195178.05.33F1A20 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf13.hostedemail.com (Postfix) with ESMTP id 49DFA20003 for ; Fri, 14 Mar 2025 06:35:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741934128; a=rsa-sha256; cv=none; b=idbx/a6KJzUn3kEkSFbJBv9pnNh4Sn0YvulqwsuzNVlW5KsIvS6D2hfbHtuztcHj5eQYRS IgFfN34CUL3cmWtfvyuGfzzlazzNn8lz37OuvIQCQfzIG/PhvIEILWzDxoc811CcHsVaBU +UAVi2MRP4LnI2eGQH7fPzOs3w0PcjI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741934128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=deyPX4XV3Knmrbs+DYZGOhojawei4Dw3ur2CPegBs4E=; b=e0oj3K7xAlU1tQI26/iSZAb5Uyx0n0VP6ZVd4IJYE+dHbqviU0+lSUphJpwYp+ZM1dXYrw ItewKe1qoD19NSIQZoRUEzwcMhhjliP/ODTkW6zMoVyrvT/naYz3UdN4YKDl2PRO7lnP97 m8JfKQJE2PMevWmDhTRycFDq2syNWXY= X-AuditID: a67dfc5b-669ff7000002311f-fa-67d3ce2da8f2 From: Rakie Kim To: Gregory Price Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, Rakie Kim Subject: Re: [PATCH v2 3/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave Date: Fri, 14 Mar 2025 15:35:11 +0900 Message-ID: <20250314063521.754-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsXC9ZZnoa7uucvpBjv/8VnMWb+GzWL61AuM Fj/vHme3OL51HrvF+VmnWCwu75rDZnFvzX9Wi9VrMhw4PHbOusvu0d12md1j8Z6XTB6bPk1i 9zgx4zeLx86Hlh6fN8kFsEdx2aSk5mSWpRbp2yVwZew8soGp4BxnxZV9i9gaGPezdzFyckgI mEhs39MGZ786/5a1i5GDg01ASeLY3hgQU0RAVaLtinsXIxcHs8B6JonXm2axgZQLC2RInJnb wwJiswDVHNu6ghXE5hUwlrh9cDbUSE2Jhkv3mEBsTgEziQnvLzKD2EICPBKvNuxnhKgXlDg5 8wnYHGYBeYnmrbOZQZZJCJxhk9gz4wcrxCBJiYMrbrBMYOSfhaRnFpKeBYxMqxiFMvPKchMz c0z0MirzMiv0kvNzNzECw3hZ7Z/oHYyfLgQfYhTgYFTi4d2w61K6EGtiWXFl7iFGCQ5mJRHe 1bYX0oV4UxIrq1KL8uOLSnNSiw8xSnOwKInzGn0rTxESSE8sSc1OTS1ILYLJMnFwSjUwFl5n uDrRPmVhVPBb/42lzUsXZSobVe3lrO/2kGyr6VTtC52ZsnlaQe7cr3G2XAd3i/z49KxB3crn Z2KuYW5wFa9xYn7bE0ll1s/PtV6v+jg76ZgC2+eygIfPFv187GFxuC7ZfWHKpJLFiXKuASon JZeUGN/xM79fqLtf8EPb1SeB5X+vpfYqsRRnJBpqMRcVJwIA8J8bkV8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsXCNUNNS1f33OV0g8uPmC3mrF/DZjF96gVG i593j7NbfH72mtni+NZ57BaH555ktTg/6xSLxeVdc9gs7q35z2px6NpzVovVazIsfm9bwebA 47Fz1l12j+62y+wei/e8ZPLY9GkSu8eJGb9ZPHY+tPT4dtvDY/GLD0wenzfJBXBGcdmkpOZk lqUW6dslcGXsPLKBqeAcZ8WVfYvYGhj3s3cxcnJICJhIvDr/lrWLkYODTUBJ4tjeGBBTREBV ou2KexcjFwezwHomidebZrGBlAsLZEicmdvDAmKzANUc27qCFcTmFTCWuH1wNtRITYmGS/eY QGxOATOJCe8vMoPYQgI8Eq827GeEqBeUODnzCdgcZgF5ieats5knMPLMQpKahSS1gJFpFaNI Zl5ZbmJmjqlecXZGZV5mhV5yfu4mRmDoLqv9M3EH45fL7ocYBTgYlXh4N+y6lC7EmlhWXJl7 iFGCg1lJhHe17YV0Id6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxe4akJQgLpiSWp2ampBalFMFkm Dk6pBsbKg+yux3P221xv2y1mpvFr9wKtqw6eWz6+1RW4t1UrcO7ud29zu3efirsqkf1L7pCd p55kT84S46APZVMv1gU5TO+LenelSlxw35e356JrD4QEPj/xaqF+xo/8L0Her/92fMjZ8qfE ru0hSxpToOccUUaHt4JzkwvqBX3TavjfB3yfGS8YX6XEUpyRaKjFXFScCABnLrm9WQIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: 88gghhd9b99dukq6etes6gnycar37aj8 X-Rspamd-Queue-Id: 49DFA20003 X-HE-Tag: 1741934126-744150 X-HE-Meta: U2FsdGVkX18+bD9e3o+FjdURVOMTa9ZSqksPQr0oYS+7Z60JbRs1w+FT3hSGuQSpX2/XnokbghSUYU/VKOKa8nGb+jkmmY+O+HKVgq0tjyZAsJHPjGjLG2i0QJaRUzR8EMsTQMT7h1zvfibtK1m9kBI3Z3JBWT0uBV6HsZPpRLvhphsRBOMrX4LaDvJ/ipKGAXjYep8wsVyQ2/wYpEXPvQHGiPHTG6t0Iip+AsadX3Hg2wSGqDhXWd5Mop9d4BFZDYU5e/99hhpYBls2oo8rQOpdlbLJdx6MVWYC23p69smfEbR3ROvdXuJlFSngW8an4YE4S09GuTee57KHWwGHPZ7B9LjksX5xjzJswuakncFKR3oYM6DyUtmFPplXecdvIfJwTEc43EJgOHYi1QzcyH9sgk+5ayqSXAa6aqAb0DgcRbEzeNBiMAyZ7uHFZ5pxx5gNsq7nZ8YKmrcd8+cEvaayZ44nWFeOsULw7XKkWq9T7I+ilw2qSmgJpPPBFkBcWzf8hHzR0+evuZeh0qL/cJsZlsPc3G2FRJGYwnH7TwjEqeI76q4+bgvIScUwrbupMf7k+GN22RIpZQUzyCi/DOS9yWh9nLW501pO4a+X3WFIEf7+T+MadSBpg7n6+Wp9/u0t2d1EpdzCyF2qYWTBq5Bv+zGNW1brrUIKmJ9imWXQU+uwOHTyIfBLqJ5J/8iidvx5o5TZKrTNpMqHS2G6EXoWtL0nqeHKgYR6TeNayWgpg3cxSCc7c7TY4dQBlWCA6iDxQhs8iQTaMIJfxXKGDaCGgntdV6xwKXr8PJ2FL3/qdAp+wUeZbkm4B/zsVV3STWcyEwJX6J74JKuAY2gyFCE31YWXQ5rnAA6K5ZyJx8pUxHM26EC4hO1v53XRmas3L5BSH+TT5uqR0SC+H0mlubqnL6CZlzAAS4BpMnABjG2wxvPV78bCJsoCsw7rxOI2SDzsZU8PbgWOGeLOF3j jMaup0es j36C3M7x+aLRxSjyw1UYZQtm0OH9S7rEuH28NgbEFsZZJxPxQGPkKckEL5s1iM3R0oUHD+7V9i/MxwyaI24CdW0Fjxm2WKGY2JUwJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000815, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Mar 2025 12:40:02 -0400 Gregory Price wrote: Hi Gregory > On Thu, Mar 13, 2025 at 03:34:10PM +0900, Rakie Kim wrote: > > On Wed, 12 Mar 2025 12:14:48 -0400 Gregory Price wrote: > > > > Given that this adjustment is part of integrating the refactored > > structure, I believe this patch does not need to be split into two. > > However, I would appreciate any further input you may have on this. > > > > Another way of saying this is: can you please change the ordering of > patch 2 and 3 and place the functional changes into "make mempolicy > support memory hotplug" patch. > > It's a little odd to "make mempolicy support memory hotplug" and then > follow that up with a patch that says "now make it REALLY support it". > > Patch 2 should read: > "Refactor weighted_interleave sysfs to allow node structure to be > dynamic" > Patch 3 should read: > "Make weighted interleave sysfs structure support memory hotplug" > > I think you'll find the patches end up looking much cleaner this way as > well. > > ~Gregory Your suggestion seems appropriate. I will rearrange the order as you suggested when creating version 3. Rakie