From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A577C282EC for ; Fri, 14 Mar 2025 10:35:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96DB9280002; Fri, 14 Mar 2025 06:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F655280001; Fri, 14 Mar 2025 06:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BE3B280002; Fri, 14 Mar 2025 06:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5EEA7280001 for ; Fri, 14 Mar 2025 06:35:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D9E21120E3E for ; Fri, 14 Mar 2025 10:35:04 +0000 (UTC) X-FDA: 83219798928.23.E17D211 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 1C27D140008 for ; Fri, 14 Mar 2025 10:35:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XM1E5Zr8; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741948503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9v8xzMViPVA25ih/N9l/UeeRwjsW/yxgKcWtCY1niFs=; b=pp9IXXq/+ubRPXojJQKt+lw3BCPTcMqH51PfbECsKE+w1DV2e0kQ1W2UTsVAdaNOaj2Khe FjoiRKZmKhQjAUK8964ua6HPDe0Kd9K7NtoJ0lvHUddJVJzA7DaaeKpDnYTavaMlRCbYo9 22bzNNv7HitHKzKOPBRkxEZkC3MHqwo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741948503; a=rsa-sha256; cv=none; b=aHOwIcvNbeBTPqIaqWFZHK5wCxY10F87Ha1uDVDzOiTrwGBRMRSpH5bvyMC0O0QzX09MEs uz8POg5g+GphbHU9p4wl9mviMJnpjPaIzi8veiQzYrj0BPhAxrAQEY6KM83eQWsxeT2hNo rFOdEYP8mtfFGMKvRMqE4AVuOWkmjEE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XM1E5Zr8; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A76725C58E2; Fri, 14 Mar 2025 10:32:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD715C4CEE3; Fri, 14 Mar 2025 10:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741948500; bh=l8ntTR3a/55I6o8PPqCMsWt7nAeOmzqzgHnF4Wr5xFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XM1E5Zr8Ro4VqUSVAIIoI7m5VnsBdzZkV1oiUDdBTTY2kfXjaQ26Ukpbo6UTWA31d pdvLsBjr92PBSumYIGQ7AYNPDleTGE74CI1WSTOdHx8FeiVGi+5GMashPL78zy/lrw TFKf3LQkPLU0Lq1etg2KEsVcN7iR5SV0e5puJcgU= Date: Fri, 14 Mar 2025 03:34:59 -0700 From: Andrew Morton To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Andr=E9?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-Id: <20250314033459.180e943deaa30dcf3549f376@linux-foundation.org> In-Reply-To: <20250314095931.825Pdmvi@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> <20250313075924.qulV64zL@linutronix.de> <20250313150814.075d1cd993a84005d4cd22c2@linux-foundation.org> <20250314095931.825Pdmvi@linutronix.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1C27D140008 X-Stat-Signature: h5n4owm8iudtauhezycbntd8dhda38o9 X-HE-Tag: 1741948502-207962 X-HE-Meta: U2FsdGVkX199M6lh/kVkydyzx9gRi43S4I6bctq66ky1RteItNmRr7GcfZ4DhCQUOIJVdQRApJPWhxTlftb2GpYVMM3YBJiwX5ziVO8GQMmEUoEk9JzZliyHOua8CnE2b9h06rTDIB+mxXSyphGLB0fjdeDLKnVtPK0KYNRtHtapysm1EoBxpyuGRUN4wRso9rpFHacafebRhp+Bu42RgIIiAiuXKThKcTngaCaghbGq3344SNLGJy+N8EcG56GttF+BOmmyxU2h8fQj8Cd9ZfZY5S1lry9OuC9nvXuCy5SdOD9oZnTD/j3cSYA0b4lLIU8tZtfT1tugqFpzbZ7epKrAwtjH4o9pci/0W8dUhckLFog0T6AstI85vgFbygnLpAby6hcc4sVTORGL0u5ZCkAKPZkaC0Kkp6Ac7HtTeXp6ERqbTFkmJo7Zq/zQEcuPMz+VhITY5GJNuUR81jSubIpOhzUYWQFHjWqZn6Sx8b6ZI6evRu807LZeubeU2xQkS7I86LreZCkffQMPota+jkPwDsmlRdggLIf68wL8Chlad5ZAifCN0LtkGsXTaFuiat8qV0/FKtNf1/6+pcx9hcD84GaP7bbeRQuQ/9nSt6XR01xDhrgN4Yg+coq+ZR/c0MiD9l3E+Uls6aDngnNZVoQxB/w8rMCLnMw15FSrPQwtYOzWGJ96eC42bvt2Y6FU+5ajlCNBKLkXRq+zmqtp+SKv4QVXintcCXdiZJjXi/2DVqxte8VNDOkdpbUjKNC2psTenNYOuO1XWe514eqwkelEP3OIHzs0Kw5i88cnZzoghtNNcp3qFWR0iUVvUi1HFD5ksxz3yKE4O/QgQ8AHr2C+xPofDNPr0ixO37VggLnXDVTTM1hSZKd7PNeKye52e7FJ6l8Lt5zgFabUIBnAhhn5Z5hOQJ/vFq4XFOKLMa9qFke24Vprhw+6CDihQJIjbytVlFLjmjAve9RflW0 4iAbV5E8 TBamSk0n9V8Any7Yu2iDvlzc4dba0DluWMfgRFuxJeXPNNfN0gwKI1XZXFwlGT1C3GPVf+eGxlBphVPLZCTCNS79KxO412jU5bn6Xjh3Arawv8aHVN8L5Ej5IDlyt1Y+ot+dJlwPHItOqndAc+hNLuy9Qhd5wYGaikfohV+SLG7MINYlTCEiPGHOuo0a3BLBqykOnLF8bW40NMdPfd48dyVMw7ye3S2wAxIJY94Auluf/H//IHIrfBSuZU4tN231D3vwPmmmqhEIQTdzmZ9VyJKvBPu4RHGErlGDNUYnj8CVka6c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 14 Mar 2025 10:59:31 +0100 Sebastian Andrzej Siewior wrote: > On 2025-03-13 15:08:14 [-0700], Andrew Morton wrote: > > That would be nice, if you think it makes sense. There is some > > duplication here. > > As you wish. That would be the following patch below. Looks OK. > This is now > somehow unique compared to the other interfaces (like vmalloc() vs > vmalloc_node()). I'm not sure what this means? I kinda struggle with the name "vmalloc_huge_node". But "vmalloc_node_maybe_huge" is too long! > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -207,7 +207,23 @@ void *vmalloc_noprof(unsigned long size) > } > EXPORT_SYMBOL(vmalloc_noprof); > > -void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) __weak __alias(__vmalloc_noprof); > +/* > + * vmalloc_huge_node - allocate virtually contiguous memory, on a node > + * > + * @size: allocation size > + * @gfp_mask: flags for the page level allocator > + * @node: node to use for allocation or NUMA_NO_NODE > + * > + * Allocate enough pages to cover @size from the page level > + * allocator and map them into contiguous kernel virtual space. > + * > + * Due to NOMMU implications the node argument and HUGE page attribute is > + * ignored. > + */ > +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node) > +{ > + return __vmalloc_noprof(size, gfp_mask); > +} Please check, I think this wants to be EXPORTed to modules. > -void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node) > { > return __vmalloc_node_range_noprof(size, 1, VMALLOC_START, VMALLOC_END, > - gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > - NUMA_NO_NODE, __builtin_return_address(0)); > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > + node, __builtin_return_address(0)); > } > -EXPORT_SYMBOL_GPL(vmalloc_huge_noprof); > +EXPORT_SYMBOL_GPL(vmalloc_huge_node_noprof); Like the NOMMU=n version.