From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E931FC282EC for ; Fri, 14 Mar 2025 10:12:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EC93280010; Fri, 14 Mar 2025 06:12:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9736828000A; Fri, 14 Mar 2025 06:12:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A436280010; Fri, 14 Mar 2025 06:12:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F85228000A for ; Fri, 14 Mar 2025 06:12:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F048BA97EA for ; Fri, 14 Mar 2025 10:12:23 +0000 (UTC) X-FDA: 83219741766.29.728E9FF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id BC7518000C for ; Fri, 14 Mar 2025 10:12:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VpVCqqfF; spf=pass (imf02.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741947141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=9gm2z62YPqNWN8yJwphL0g3OWPmFyfl9EtTC0QPQVIU=; b=qe05wRdhlZnqVPYLr+1DegPhj6F6Aho3nwD5eBZdmVqKtGUYDx9SGEg8iMvch+Imy/ubl8 9M+WyFc8RsN3pc7cVxpNMLbKEfNRr4pbKwJZxAzoJw5TxgnyHEHAq4+vhBjncp0hYw3sa0 I8XWE8twyGpiVdwi+M9bYgKvcrDuEgg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741947141; a=rsa-sha256; cv=none; b=6H1Num7gNnceu0A4otxU7/avlhtXnc3Jn11cWIImK06lmSO4hjYkhX8jvMQUwzz2uyHflH e9KEwGU4HayFSoE2zN3C/0NTbULdXhKZShddaeRmoVBm/SDiDKVfqHD7ART46yaszfpzkm 2tA5UfW+UpPMYBfou7zqlfNsTVNtjmE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VpVCqqfF; spf=pass (imf02.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741947141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9gm2z62YPqNWN8yJwphL0g3OWPmFyfl9EtTC0QPQVIU=; b=VpVCqqfF73ZZSaIQJV5kFGtTMqdIhI+6uYvUmcMR+ergrLx4spkUJq2U12toySmInyr3pa /79e8MlIbpNVLy6t2ZXhEvEUfEPx3oRGDmXZWdQb9Xd3DY4e6MjFlg3P05kAqlKc2uwvlB 3ifkaJ6g2l7jiM2iV0ejN+Yu1bpr6WA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-AlcuMqvbOT22HUzyM5AyBg-1; Fri, 14 Mar 2025 06:12:19 -0400 X-MC-Unique: AlcuMqvbOT22HUzyM5AyBg-1 X-Mimecast-MFC-AGG-ID: AlcuMqvbOT22HUzyM5AyBg_1741947138 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5496d38f725so978817e87.2 for ; Fri, 14 Mar 2025 03:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741947138; x=1742551938; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9gm2z62YPqNWN8yJwphL0g3OWPmFyfl9EtTC0QPQVIU=; b=qYlSzyhYm1PXcBW2bpXdsO8xyctgt1Xi3suGWaV1jMHQbTVAfPQW45VWrqg5GrIKNr IjAgt77X86Z2UqUFvXreGvUOLSOQAUZUMCooyfQtsYq5Ue0yK8AvH4gtjkNUh5br4diW BfIc9WEMk+MvWW/z0zNoVyOV0eB+iptk1CN7roIMYULt9aN4j+ctnM5R7nc9CzrytyE6 JiPKl6lKzaQPDt/fyvfDPnKZCIZP9FKZMQ60MSqO4BHkjBUUanMr+bYeBkwxYC54lkbO fSwHiEgcmluTENKvFVzcD6tI+v5Pqea77R1C9O7qSb2O+jYsJNAYQs9xGXW1ERF9YG0D cMfA== X-Forwarded-Encrypted: i=1; AJvYcCW7bjSC/jRZEulRjNY2+x7cmIhhu8x8wVpl9bwXVw6FGvjWgkxtjaj3NAYJZpSRjbMAkl92of7MnQ==@kvack.org X-Gm-Message-State: AOJu0Yz94UTL6fV4G1uQzRIODNyf+gDxxqQueLkdhIJq6MyLAz9PeiBX t+6POHqsBA8G7MJCm+QjfqwVALqr8ugIIxDGvzNutYcuWPqcHVYMz4Y4s6JNpe/Js/oHGPM+wCs Mo4MNsZCuPmKPyDOfT7VF/jV7QzdgDZ+WRfGRyqhz+TZhgxcX X-Gm-Gg: ASbGncvdD9wvefmVqCHT3qc7/g7mOVPGmw9cFc0tSlS3EVZrB1cmAALx7GgQfj0UDYF jNBd0op57x0Q/ZnDsj6HXgGukVKqOy5TqDHjXEnipBWV94UI6aUyacOO54VYV8P/4HM4XVU8IOr oYKZmAHna0ZEboWJzsQf4IFeSnMAajhGqDhmxHfbXxGoVSqsf/s2DiIsgmPtyY+O6GXl/6qmov/ b/qSdVOdkViHfHu2867dlqOEOpucBEqDRad059qDRsCKNrwtxQFtlirQ5ny3s9eKlqA5Vee4go8 iv1dDkeCsgp2 X-Received: by 2002:a05:6512:3ba4:b0:544:ca1:da41 with SMTP id 2adb3069b0e04-549c39897ddmr668078e87.44.1741947138265; Fri, 14 Mar 2025 03:12:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQUWKDrZlzJOt8qlYePG63LB20pTY5b0FHQCM+E2JqpqZhwzuf+fAjF8sgxJkwHe+V2bVHLw== X-Received: by 2002:a05:6512:3ba4:b0:544:ca1:da41 with SMTP id 2adb3069b0e04-549c39897ddmr668037e87.44.1741947137761; Fri, 14 Mar 2025 03:12:17 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba7c11f7sm477629e87.84.2025.03.14.03.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 03:12:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0737418FA92C; Fri, 14 Mar 2025 11:12:12 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Subject: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool Date: Fri, 14 Mar 2025 11:10:18 +0100 Message-Id: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIoA1GcC/x2MQQqDMBAAvyJ77sKa1R78ivSw6KpL2yQkQQLi3 xt6nIGZC7Im0wxTd0HS07IF36B/dLAc4ndFWxuDIzcS94RRmoshfLAkWd64fgWJ2fHAMjxJoZU x6Wb1f53Ba0GvtcDrvn+tpLJRbwAAAA== X-Change-ID: 20250310-page-pool-track-dma-0332343a460e To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Qiuling Ren , Yuying Ma X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WR_yANfXAq1yyHzOYFjsnc2NIWle65OqT6Lx9fwaIU4_1741947138 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BC7518000C X-Stat-Signature: rj3o6myoz688rwppmtjde79ht5j3zu1o X-HE-Tag: 1741947141-271731 X-HE-Meta: U2FsdGVkX1/seOrLQqWY8cGGFjtWGQMtDoPO6es5h+bM6LMooO11dbCh8UG1N047MhGQXJRRXkiqNvsFPb4ToTZ23o+72JFfR0O6fs733BmGaFiY8lm6MnEoEQj8FubmwAMpXjnITc/AtixSlmi6iCYEaS/Ih75bMVZyk6KTnFVbQMVwnoyKV/g1eYSaeiXLPCLM0udZcrNgipbVUJOlWDWq0sGPSJDseNEvmYEgdMI4b4QhlJZY9TyrOfnQ/HN3H6qoYTuXjdT/s+t56a3jini2mA+iuXWdEvfEOeJ/qhb24/h9tAYSV5NkUNFy8z8AHVDJnqH0xpxlNnZET1eszrWIjCcSi5wkw+Dy3Yp90XsJnNEMl1M4cMb7KTjhm0q/azmJMQwmkpZ0SJqXhrCBMVVajCfxV5Hoq3v/Ite2bETSG7yMGqbEC4hz7eZa/wAXVl8+LNd9T7WEmShIz+VjB3D/Y8BalKtGGzJnLWbSzGB50z8vrcbjU3OILeQbvch9CuKjq2nfwlTIo9aN8rt4NAWr0LO/0y9FwTESoSZI8ZYon3y3j56J6YBO/mWTbS3aFOP4jiyawwHuv4PO4kCbJrs8t6zCqSY5e4VklptH/sN+LsdE3G89VjCuoF1n3xHbN4Ao62bWkUOi+QT8Os9ofngSJgTlorH0iVrdKLbmIscN6kgVaWyHSjj+rXPomTJDr9JlSdoE3iYZJG6Nfnluds3dLpKLNLiLlHEAc7Olfg1QaVwUNi6JjYt9Dbyrx+h2rD/9ilLno43nzwkslhl0RbSFp5XEJG2Hw+TddXF8z+tA38u9Rhq0PRWjXTS6V1opP522sx2lxg5uY4yOiY0LkHwHW4K8w0Vuop+oFA4AkFGQec95PZ7MK3mB+Isnxqg38qlg+LwcNruBoCCfFPgl8anU0Fx/lPQSQt0VVBCPctOdINlo5Gj4AlWFkohkAyP8+TtQodJoysnbUFfleh4 O0z7x58Y 4CtC8kCp9/IuHRRtjCeqQ/JLnWOztUX1dxduudH6+AOgfIaV16jYkUueOwyAD/PdqpzDNTNZXAAVy7K5Sj7DZf6YgZ+sBNDl7NHBRkE0day8AhyHJHMBBMHd8yQv2EuqzrYQvbCsrO9Tr9vBhBpyEH15GKdTjo+nUjZBWth95czaU7NZxk89eDuZ/gXqPSN6kV6ZbZMDQ5/5Zbxg7Jel3B/cCYcU/oin+wuYgHfbKrEbcNftFH9R1SQ8LvesjO0ApkVdEHdndqLqp4Lt/iXdXW7ypfIqQoXg0h7PXPnNP2egOyVUfvEFconX0NHHTNMR7hY/3jHclQJzAhqTYFYjiMofvwDojOK4+wAXuRLh7+g7cZAAKTwn0GciApu411IbSETzwMEX3kyXnGfvZ2EpZvQjgqFHM+7FJzTOCJfJG2Fmk0RhsYJRmf3yD/s4s1r8vl8dgG/kezEGHdsYfAQ5R0Dl5mBmMNp68FC1m7nQVkGOzyN1YpgxzQpRzjG+UPDaPoR39BEENsQtjvWIuWI+fICdMsHARE8BOqIq74ruPd6cXDSWeC38S7IX3E2Xd+oycGls9uFs587y0MbxJoHbLalKPEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This series fixes the late dma_unmap crash for page pool first reported by Yonglong Liu in [0]. It is an alternative approach to the one submitted by Yunsheng Lin, most recently in [1]. The first two commits are small refactors of the page pool code, in preparation of the main change in patch 3. See the commit message of patch 3 for the details. -Toke [0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ [1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com Signed-off-by: Toke Høiland-Jørgensen --- Toke Høiland-Jørgensen (3): page_pool: Move pp_magic check into helper functions page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap page_pool: Track DMA-mapped pages and unmap them when destroying the pool drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +- include/net/page_pool/helpers.h | 6 +- include/net/page_pool/types.h | 54 +++++++++++++++- mm/page_alloc.c | 9 +-- net/core/devmem.c | 3 +- net/core/netmem_priv.h | 33 +++++++++- net/core/page_pool.c | 81 ++++++++++++++++++++---- net/core/skbuff.c | 16 +---- net/core/xdp.c | 4 +- 9 files changed, 164 insertions(+), 46 deletions(-) --- base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe change-id: 20250310-page-pool-track-dma-0332343a460e