From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Horman <horms@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mina Almasry <almasrymina@google.com>,
Yonglong Liu <liuyonglong@huawei.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Matthew Wilcox <willy@infradead.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-mm@kvack.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Qiuling Ren" <qren@redhat.com>, "Yuying Ma" <yuma@redhat.com>
Subject: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool
Date: Fri, 14 Mar 2025 11:10:18 +0100 [thread overview]
Message-ID: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> (raw)
This series fixes the late dma_unmap crash for page pool first reported
by Yonglong Liu in [0]. It is an alternative approach to the one
submitted by Yunsheng Lin, most recently in [1]. The first two commits
are small refactors of the page pool code, in preparation of the main
change in patch 3. See the commit message of patch 3 for the details.
-Toke
[0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/
[1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
Toke Høiland-Jørgensen (3):
page_pool: Move pp_magic check into helper functions
page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap
page_pool: Track DMA-mapped pages and unmap them when destroying the pool
drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +-
include/net/page_pool/helpers.h | 6 +-
include/net/page_pool/types.h | 54 +++++++++++++++-
mm/page_alloc.c | 9 +--
net/core/devmem.c | 3 +-
net/core/netmem_priv.h | 33 +++++++++-
net/core/page_pool.c | 81 ++++++++++++++++++++----
net/core/skbuff.c | 16 +----
net/core/xdp.c | 4 +-
9 files changed, 164 insertions(+), 46 deletions(-)
---
base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe
change-id: 20250310-page-pool-track-dma-0332343a460e
next reply other threads:[~2025-03-14 10:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 10:10 Toke Høiland-Jørgensen [this message]
2025-03-14 10:10 ` [PATCH net-next 1/3] page_pool: Move pp_magic check into helper functions Toke Høiland-Jørgensen
2025-03-21 17:16 ` Mina Almasry
2025-03-14 10:10 ` [PATCH net-next 2/3] page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap Toke Høiland-Jørgensen
2025-03-15 9:31 ` Yunsheng Lin
2025-03-17 14:55 ` Toke Høiland-Jørgensen
2025-03-21 23:13 ` Mina Almasry
2025-03-14 10:10 ` [PATCH net-next 3/3] page_pool: Track DMA-mapped pages and unmap them when destroying the pool Toke Høiland-Jørgensen
2025-03-15 9:46 ` Yunsheng Lin
2025-03-17 15:16 ` Toke Høiland-Jørgensen
2025-03-18 12:39 ` Yunsheng Lin
2025-03-18 20:55 ` Toke Høiland-Jørgensen
2025-03-19 11:06 ` Yunsheng Lin
2025-03-19 12:18 ` Toke Høiland-Jørgensen
2025-03-20 11:17 ` Yunsheng Lin
2025-03-20 14:34 ` Toke Høiland-Jørgensen
2025-03-20 2:32 ` Solar Designer
2025-03-20 14:37 ` Toke Høiland-Jørgensen
2025-03-17 2:02 ` [PATCH net-next 0/3] Fix late DMA unmap crash for page pool Yonglong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com \
--to=toke@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qren@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=willy@infradead.org \
--cc=yuma@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox