From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248D1C35FF1 for ; Thu, 13 Mar 2025 21:07:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DF06280007; Thu, 13 Mar 2025 17:07:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93FA5280001; Thu, 13 Mar 2025 17:07:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796BE280007; Thu, 13 Mar 2025 17:07:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 50EB2280001 for ; Thu, 13 Mar 2025 17:07:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1363A54F16 for ; Thu, 13 Mar 2025 21:07:04 +0000 (UTC) X-FDA: 83217762768.12.209470C Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 39E67A0011 for ; Thu, 13 Mar 2025 21:07:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=0BHOy9gf; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741900022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2esPX4cdQSzTzPsUwG+c+ZkpjEsRNEpWoM7zt95z5xg=; b=PbwREosaj75u6ZwuEft3rBDvJK7+2q3vJo+9uWXII/Lvzsrtax4hGf4OGKX7T4UEcvkiag J8JhMTeV+XVe+PyStFt2uq4zhgGw5HRAeO+hn0XoHwlQkJcnX9VmgsIaIO6Vsv/GmdVoYx TMPANaezodmKCfLFIx1R4U60veubDto= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741900022; a=rsa-sha256; cv=none; b=k/HLpCr1nAAB6iIDm7ljnMg5Re3ZdkEWriHYCp7AmROQIc5YxQ0LjGoNNQ8zcgOU/aMyVG zSnmy8gOLtaj1Hnf2smP30xUf34EpBkT04JtWEVyy9eVPQ6ZXlOJR6l2CuovIsoYoBpAEN tnN5oafQKFZUcxWtSsrv0t0Y5vP98JA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=0BHOy9gf; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7c08fc20194so235398385a.2 for ; Thu, 13 Mar 2025 14:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741900021; x=1742504821; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2esPX4cdQSzTzPsUwG+c+ZkpjEsRNEpWoM7zt95z5xg=; b=0BHOy9gfZV8CVNvyf9lHKvW5KrJhtRWWq/CF0ZcFn30fDVrqRoadTq194l41e8U8K2 6V28xgZE0C46q1eW0SniP0d6UweuRNg4xVBZxK1Qg+6b9AFdtCbkNtXY3FSTgk9zimB2 d2bAo41KmCrQ1xvXRxunVRPAWO/Q/8aORCKXjHvkJZWD7KNxiJWC5ZTx1Ef0TvQvMVXR LwWdmnRJQSkFLlqbWCb7Uu8e3FMnrY/hFvTtAXU1NwS9eeyl30UqQ9MpUeQm0McQsviF D4i/UWHE5thg7qhn2xBTKX39M8D+Od4BtH5esa2GD5Xe6ngMuUwpEzGW0iw3QJ9CHRU7 Ykdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741900021; x=1742504821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2esPX4cdQSzTzPsUwG+c+ZkpjEsRNEpWoM7zt95z5xg=; b=Tn3XwiRxzXxjVGnWMdSaOc3AsOhcxKFtgCBWE17toaYhrI2/nyYCEiI6Y7I7WPHfjt 7y7a1zV5YnnwioFpnRT+enMtwa480GvWGbvHtQuTheutKknfSrPSUjQsCLsFs1R6lw7Y 459k2xhdDbIv5BZIJ/uFpKrWqK8p6kH3F1IPEUzuMEp0ZCJy63bBCmhOV/w4lbqgB7FK ZZi/jACh3fiCzA/pNqq5pKvAt++kEyb7MG75mCCu0+US8ic4eSV81khUVYzl/K2ZXyw5 0lY2MX5l0dCcyCZX7eOGDXPfmw4AHu2y85CS2FMq8pGIwMiktYtyfUfgsVGkybhYVDy+ Vhag== X-Forwarded-Encrypted: i=1; AJvYcCX7mZ9Tp5M4/XeKmT2mx9BKAbWH5xSnj23Ezob33ibwVbTVTaeknA75hjGRo6NlNrVM8BKlsskILg==@kvack.org X-Gm-Message-State: AOJu0YxAuvnMzw16DuGV/sbLuGo8N+nKWR89vdsX8AWROhn1HTMcWgUP 2JNQZ4ZwzFPD14BMPTc4HEuidWcl5VAh7scZA4IWO1U6vWGOmoBsQ7KtOAj6fw8= X-Gm-Gg: ASbGncv8V+WR9YnRraBany3RK5gLP42qIy2FuRiCkdI7y31GCtL4yY0BufnfoYFvcuP Kyvp1/ysaZUjl4PeKYF2JSZf0Q91PhtMY4+tsOaT5IPDyUqh/VI3Tzdtqy6D66xG1WBzlsriXYb mm7mg2b1sYGKxKuqWK3yFNmEoyH+wJ4Hd8WniwgT7UpkQ0q6oIW+ohiQR+YZCg2iYqK8HJvmOq1 EIXciXqhL18HsA0OYKjORcRJUinn6he4BKfM8LX9EmEDnmBSDB6DyaV4W+vSMqVGrrc1HJ1+pjq MP3LXCeqc+ejoyrv0Q39GdPdxmF/Zn51kBsW9s6bpCo= X-Google-Smtp-Source: AGHT+IEDki5koJiqxSP81S0xIyeu1/cjXxLH4CEnBdYSjdRM2zBmEa/+ycr0rjzgyK/cpuSXIx1wnA== X-Received: by 2002:a05:620a:24e:b0:7c5:4194:bbd3 with SMTP id af79cd13be357-7c579f96ff8mr167000285a.44.1741900021237; Thu, 13 Mar 2025 14:07:01 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c573d6fb1fsm142597585a.80.2025.03.13.14.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 14:06:59 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] mm: page_alloc: trace type pollution from compaction capturing Date: Thu, 13 Mar 2025 17:05:33 -0400 Message-ID: <20250313210647.1314586-3-hannes@cmpxchg.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250313210647.1314586-1-hannes@cmpxchg.org> References: <20250313210647.1314586-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 39E67A0011 X-Stat-Signature: bjg1eh7wjnbq9tst3ui49b859r3ey49r X-HE-Tag: 1741900022-359512 X-HE-Meta: U2FsdGVkX1+pKFs6eWdKU7Qf27k/vR/mQgvT2wa6go9fwV2UCnClm64bQY6Hk/SzhpSQhnHmH69LHdVHrBGMnLp8/K4K8x/6VAlA8dgfuNLbZ/DwMwHF7FNzfVdSE5kgJmJZmbmN0S6XapR1NXzCxcQTFBeEds11OMByXYKCTFAnv+yOWKk26GQ/C6mTCrXPs5kgmBo/AA2zEXHfn7XeP1DzAI/Wnewcu9T6VTPtNAWiGjJWWwRtvVYu5WXU5dw3yiAz0xfqnhlPkghHK7ITpFIpOsSz9Q8JEjoNhXO5womjuSYgM6bfyq20yaaKg8Zgu6/lnZSuqeDebOb8N/JgVtJpkv7BkAYd+kNf/Yo1Aa6WCXqXAo2TP+B7/gSBVRH45J7SZvjXxuiigB7+MDg9ynwzEcw16vqwCEaIYrelQkvrC+f+hS2R4iGgKT4qhanOz/JzVa6zeaILAkOClDw05nlihuJJK9S3UYjnd3rFJ6qCf3O8y8CDydWhBGRzgMF/g+Gu3Z8F7ErG3GC7oWt+BLCFT0J0UBz47ByqBWYIWwR7vM38WqD4CDw5S2QRw98jQvEDBlr19a8Gs6aMHbIC0nEMxjV5PpIQZHB0LOu0sa2tfOoR7atrr59TCBnpX9X5aOh/TjU9IXRCTVh+B/s8eLmTVvSmuAGiGnKMZ6O6+M+xWAc+e5I5jS1/I5ozkJ1SFElp5Uzn1NukUV+wrZOPmSpUOTE6ErhSrmGsN0FUFlViu0YqLqjtcUbzy4C/vCQKLEXT1nS8zQSQxgF50OSiioI9gN+gQYezY0HtK7h9gVFVwse/Ux4XERtu5iKGuE3xJjgLvC+pvlKpx/4q50Un+92rD3vMhz6Dc+Dq+nFcpjKFTDCUNCTp4gE5VZT5mWhTZ08i79fgwZ/W4J1iyAY5PPaQzxmhBsS4nK3zMJYwCU/7SDWe/A2JqR3FZuRjGHr6+avngbJ71vgM3B3+51G kpJ+vakY ZUmCv8jplN/T3BsybS2sSfZ+mSdCB+KeVPl5Rg2fZxd0fSufjo4j1T+vYiECLoIpdqwLA6qSMqvpKcsb22PuHrjcx/NW5EO1Rkq5OuNIP6qszuGX7EOZ9zSKVSAl4RyDJ3UfFhFcx08JSFJU3Q3AZGaGmBURkn9kYVJd/0yQDg5pTInspIi6H/XOyCqeAdSY+QWYMgolhCGRlPirEzhUu/a/09i1uscohGy8TpprEBtcoBkbS7KjAOp/Y9ItFBfTfxPs7db2Jmc+mtJLsuynMJBJDiKTRVB3fAmSa1DGAjXg2iGwazOfnF+smfZA5jz3RQFJYnUkC7T5OMIoU3akC+71N/RHpyYDS0Dlxu7GaDxfNRtVk054oso+fNIUtzdZ1n7b9Ey4nIjdlZJyBYN8KYgjOOFEFYi0miwmqwg6e+mABrsV2Nc9OjH+dLYwiV5SfmBZhDfG5PFPtGTeoaroPubCixqUXI8pieeM/LpY17/lwUyo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When the page allocator places pages of a certain migratetype into blocks of another type, it has lasting effects on the ability to compact and defragment down the line. For improving placement and compaction, visibility into such events is crucial. The most common case, allocator fallbacks, is already annotated, but compaction capturing is also allowed to grab pages of a different type. Extend the tracepoint to cover this case. Signed-off-by: Johannes Weiner --- mm/page_alloc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9b4a5e6dfee9..6f0404941886 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -614,6 +614,10 @@ compaction_capture(struct capture_control *capc, struct page *page, capc->cc->migratetype != MIGRATE_MOVABLE) return false; + if (migratetype != capc->cc->migratetype) + trace_mm_page_alloc_extfrag(page, capc->cc->order, order, + capc->cc->migratetype, migratetype); + capc->page = page; return true; } -- 2.48.1