From: Kemeng Shi <shikemeng@huaweicloud.com>
To: akpm@linux-foundation.org
Cc: kasong@tencent.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] mm: swap: replace cluster_swap_free_nr() with swap_entries_put_[map/cache]()
Date: Fri, 14 Mar 2025 05:05:15 +0800 [thread overview]
Message-ID: <20250313210515.9920-10-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20250313210515.9920-1-shikemeng@huaweicloud.com>
Replace cluster_swap_free_nr() with swap_entries_put_[map/cache]() to
remove repeat code and leverage batch-remove for entries with last flag.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/swapfile.c | 21 ++-------------------
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c
index 343b34eb2a81..c27cf09d84a6 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -1570,21 +1570,6 @@ static void swap_entries_free(struct swap_info_struct *si,
__swap_entries_free(si, ci, entry, nr_pages);
}
-static void cluster_swap_free_nr(struct swap_info_struct *si,
- unsigned long offset, int nr_pages,
- unsigned char usage)
-{
- struct swap_cluster_info *ci;
- unsigned long end = offset + nr_pages;
-
- ci = lock_cluster(si, offset);
- do {
- swap_entry_put_locked(si, ci, swp_entry(si->type, offset),
- usage);
- } while (++offset < end);
- unlock_cluster(ci);
-}
-
/*
* Caller has made sure that the swap device corresponding to entry
* is still around or has not been recycled.
@@ -1601,7 +1586,7 @@ void swap_free_nr(swp_entry_t entry, int nr_pages)
while (nr_pages) {
nr = min_t(int, nr_pages, SWAPFILE_CLUSTER - offset % SWAPFILE_CLUSTER);
- cluster_swap_free_nr(sis, offset, nr, 1);
+ swap_entries_put_map(sis, swp_entry(sis->type, offset), nr);
offset += nr;
nr_pages -= nr;
}
@@ -3632,9 +3617,7 @@ int swapcache_prepare(swp_entry_t entry, int nr)
void swapcache_clear(struct swap_info_struct *si, swp_entry_t entry, int nr)
{
- unsigned long offset = swp_offset(entry);
-
- cluster_swap_free_nr(si, offset, nr, SWAP_HAS_CACHE);
+ swap_entries_put_cache(si, entry, nr);
}
struct swap_info_struct *swp_swap_info(swp_entry_t entry)
--
2.30.0
next prev parent reply other threads:[~2025-03-13 12:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 21:05 [PATCH 0/9] Minor cleanups and improvements to swap freeing code Kemeng Shi
2025-03-13 21:05 ` [PATCH 1/9] mm: swap: rename __swap_[entry/entries]_free[_locked] to swap_[entry/entries]_put[_locked] Kemeng Shi
2025-03-14 20:37 ` Tim Chen
2025-03-13 21:05 ` [PATCH 2/9] mm: swap: factor out the actual swap entry freeing logic to new helper Kemeng Shi
2025-03-13 17:42 ` Kairui Song
2025-03-14 7:32 ` Kemeng Shi
2025-03-14 7:47 ` Kairui Song
2025-03-14 8:39 ` Kemeng Shi
2025-03-13 21:05 ` [PATCH 3/9] mm: swap: use __swap_entry_free() to free swap entry in swap_entry_put_locked() Kemeng Shi
2025-03-14 20:59 ` Tim Chen
2025-03-13 21:05 ` [PATCH 4/9] mm: swap: remove unneeded VM_BUG_ON(*map != SWAP_HAS_CACHE) in swap_entry_range_free() Kemeng Shi
2025-03-14 21:09 ` Tim Chen
2025-03-13 21:05 ` [PATCH 5/9] mm: swap: use swap_entries_free() drop last 1 flag in swap_entries_put_nr() Kemeng Shi
2025-03-14 21:21 ` Tim Chen
2025-03-13 21:05 ` [PATCH 6/9] mm: swap: drop last SWAP_MAP_SHMEM flag in batch " Kemeng Shi
2025-03-14 21:34 ` Tim Chen
2025-03-13 21:05 ` [PATCH 7/9] mm: swap: free each cluster individually in swap_entries_put_map_nr() Kemeng Shi
2025-03-14 20:53 ` Tim Chen
2025-03-17 17:30 ` Tim Chen
2025-03-13 21:05 ` [PATCH 8/9] mm: swap: factor out helper to drop cache of entries within a single cluster Kemeng Shi
2025-03-15 0:24 ` Tim Chen
2025-03-13 21:05 ` Kemeng Shi [this message]
2025-03-17 18:23 ` [PATCH 9/9] mm: swap: replace cluster_swap_free_nr() with swap_entries_put_[map/cache]() Tim Chen
2025-03-14 20:27 ` [PATCH 0/9] Minor cleanups and improvements to swap freeing code Tim Chen
2025-03-18 1:29 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250313210515.9920-10-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox