From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA667C282DE for ; Thu, 13 Mar 2025 18:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BE51280010; Thu, 13 Mar 2025 14:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5468E280001; Thu, 13 Mar 2025 14:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C067280010; Thu, 13 Mar 2025 14:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D357280001 for ; Thu, 13 Mar 2025 14:03:10 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B26B280455 for ; Thu, 13 Mar 2025 18:03:10 +0000 (UTC) X-FDA: 83217299340.20.05CDD00 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf08.hostedemail.com (Postfix) with ESMTP id A1952160020 for ; Thu, 13 Mar 2025 18:03:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=FJNIJ4wY; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741888988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tWC/m9zXQcbzyUKH0Lu3T1Q4DKswln8vw9/ARDWaZCI=; b=ygfqqN9mBjKAe7xRgCsyiI+7K2TQviZkC+kYep8Z9fw/fIzSboyquhAub5NeJo3v/m167b +BM5buiveqKoOPEbGrwm3mPd3FGqsGncEffgqUKsWecrw2Vx6X3ED5y08XRzXTgJOLdisT m/2+VdcvVzItqSAepqoTSEj6cs/p4Cc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741888988; a=rsa-sha256; cv=none; b=ONbadqxIyiu81CqRGFqX9SkpUdiDCd8OB5CxrmTOWSWOpt29AHz751Uygc9YpBqACopGoo gJDIBwBMPcJGIosPnb2Jqqz6dzmr97cV8XpbJ5kYDisXQEV9IqblWk60cbTMQfRgMZrswB yI2koA0DxiRKyKYJ9CcP3C1mNVFMHD4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=FJNIJ4wY; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-476ab588f32so16948171cf.2 for ; Thu, 13 Mar 2025 11:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741888987; x=1742493787; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tWC/m9zXQcbzyUKH0Lu3T1Q4DKswln8vw9/ARDWaZCI=; b=FJNIJ4wYBC61eZ2M/pIR4nZEikmDrMUhTiuMUo1lo5n4s/kU/tjsuC6ZtwMQ1dPxQR KOcJ46JIaMmOcjDLNQ3xHm7atCmq+LM1y7BKrLsL+c2NcBFTYp80CUcNYew0YK8tLESi tP29vyEa8MqFIyQOYybdVxzx/lY0b1lrNKNSVaXEnrM013nt6OmAB5GcJIH3Wzt7BGNa pMCruCky6pfupnGhOlxsWMoyW6v0WHNszZolfAerCw1a1fG23pav/olJNlIvhnwiust8 dP1k7xIMSi9AXqpzTrk86SGugQzU3USt6ETa9d85lVEJmJr3HyQhEe90gSHWyBfHfqm3 SopA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741888987; x=1742493787; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tWC/m9zXQcbzyUKH0Lu3T1Q4DKswln8vw9/ARDWaZCI=; b=LfaQONrbXFgpEAW4wKlY4runPwWhUKSOWJ8nf5hjQlJganKaSJEwfmRcj/Y/Bf1ZQ2 Zf4yDC8Svvu4QtoO5r7iQxx8ideAoVuk0UqRuV6Ma3QmHYiR4u6jKJgLOjFLH8FiGWWy 5QNhjiickZ/TbetW2dO+Cezxww/gFYwwKrf6VR5PokWAjVugtWSsCZjwsQOxwiEOC/7p J5LXxpZzRVfMtMwelkgGW+APx+YjjprcZMMWP3CPh194VapTzTHU04MVYbAEaOeaKcy5 HT6Sbz3XrI7b1vBek/lnkWmndkBpKCbDNZtReQrtqbvbEhF97luX9m2+PCEN8kICxxzw VZ9Q== X-Gm-Message-State: AOJu0Yx7TSabPN1Olq+Lchb4HtTQuEd+7yt2pm0AR3gwHg/Ydg70gBtv s4dWBtsiCsnbLtL7LuncSKlzY/vZart9Cjz2G4Rdo85YJuZfY9vBi4p+4mi1eWk= X-Gm-Gg: ASbGncsx5Snhzd21tE76mLN2IekCtsBWdEpeKx0AY598Xzc7RypcpqbFHYcyyPSjXgn gTy6u8flsaw4pBdpZES6bQ4RmQhljTbQb4DbrlBs/6Ricef8QWOFLB7tlKo5iwGv1xq340rTfmH rMk5wnrSKyhYP7Z6NXfW5KHfdpFpstbESHfBHLfLbd3LrwII9/XDwZOGbB2KiNs2krRi2R1NNI+ 5bHlfitdmC7CeBJSXaot/hW1z6W2F4wgcOdsbzHnjwhqoggIH+4iNRn3DVJ50NpDVXFBCOkeyhw Uzx/uXamL/nQa20Wf7Yl+EtM3TCmsjk3ZILeD7vj594= X-Google-Smtp-Source: AGHT+IERC/9TzHaIuUVRa6tPhCLfU030PYucXwO4ZncyAhEDZ5Fkou+sK7oUIQLpWhb4I01pkxi5zg== X-Received: by 2002:a05:622a:4b0b:b0:476:6b20:2cef with SMTP id d75a77b69052e-476c64685a0mr5484161cf.41.1741888987574; Thu, 13 Mar 2025 11:03:07 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-476bb7f3d5fsm11655291cf.62.2025.03.13.11.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 11:03:06 -0700 (PDT) Date: Thu, 13 Mar 2025 14:03:04 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: linux-mm@kvack.org, Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Zi Yan , David Hildenbrand Subject: Re: [PATCH 3/5] mm: Remove references to folio in split_page_memcg() Message-ID: <20250313180304.GG1252169@cmpxchg.org> References: <20250313145856.4118428-1-willy@infradead.org> <20250313145856.4118428-4-willy@infradead.org> <20250313160114.GD1252169@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A1952160020 X-Stat-Signature: 4iehw5mhzotdh66eqsso3j9hfezcigss X-HE-Tag: 1741888988-127529 X-HE-Meta: U2FsdGVkX1+uMYIf2xaIJccxooJCmxhE4R1Bk6O2CCbdVt/PuNoy9efnIVcW070uJA8p/4BdVCdQY803DUx0pf6hMB8LRt0ucb57KuAI27aeqrJzGHJa+PZ30Us/vN6veu45ixVpaoSaoCkierAoSBfD14XgEkQZX5ENH7eNjvyytuug9YWqcA096ErAM1JxWY+q9i906yB7x1V/ftU9qkclS9fwZlRmixl3/+97cGNAAxXHsy2uZjIFotWd12O4l1jxnJDHY0xJLaYLbj8frVCT8kkh6YxNkzcNSh7loAi1EDgGeJ/Z+pXHSiWrEoxb24+WRZiqA8sIz9r0jC66UC2vatFZNakwLd5bgoL6vhFlWpbH63skScuZXN0k1tPPO9EizpI02hz/4LFXTKEpIrgm93J4ll1Gsjcah6BWo0oJfjXl9RP57CVkWOrTGPKj358VsuElfZGWMjunTGaGT/8uFGqxuHNUbLKJgQ6dKeajIcMwDEUpFalmlqgDYbRugoLMMRtCjO6oljnqtAZ+WVRXcM9fWRIEg9Br4lU/rAck1OFe2+8ULBXldY3YbTZrxOEcBDVNWSZggex6ey8YvGHrJ0MhN0Hz0nV1YQu2LMXGPnPUUQL7XVga1YrGKulMj2jNmKuo1MaZqDx1Izc6OX0b/pYMBPHUYjSrJcweeitLGYrxiXOn8KB47gTq0W8NzV42vS6TbIS8ErcGNZXkQHs+d5O4bJixdiAzTwlb5E75BSMOu/8B1asn1OFsjPRuAQkXVFUDE+rzf7Lwk5jFaBUfuZDWEE8GCo4xMz0lvfuKU49Q1w2gvZAr+JA1vn6b3z7JEzgVl4BcaPZCN9hANtMX0BwaMKxkelb8HOjCrRYclRCYlFPp4dcoef+nly8rDw/lV1eVca/Qea8R5WQn0LZeSmzSW0X2wMR0PZ0YnlaIetwrbh/dh6I1uaG6aWztUxqCluR51ichLzdA7wO R0ZPb4vH T2FKdUQTn96edUy2xWqgaAWLk2NWjrmxMGLuBA5miiuSgpuvxsdHVl4R1t+Zz8ndQTorOu2v3l+nvA/y1xuAY9WKyhv/KoyxItN2wGQGu9wWEdgRw5sYnNVTCHwmd0l201e2N12Yq810jm4vlUTJwY8hYHE6TpJqw24YmUa486DNwVzkj5CyzFAx8DJNbAgyeLVbwZPK3Yd64WhHM/jjOHS1+CCCAbctcW+t3cWmvhN0f2WB9vuPb9MJKbtVR9jAZQWQhBT+v5b5LV1GVEMTObNagTZTN0ACC5JUSmkBzPT5a2AE9hAPG4YlBj0QkfOULDhrCfNq/7gXwOXg5FjRCkCe/2cRk6KXEXsktty4SmM+AxjLe5GHnzw5huA0OwjCzIS6qxrwqpimlF+py92w4NXn2RUeHamb+MHNkaSRh3mw6mbWVo08MVY7zf+biVOUq5rTPcOgHSJu9WqZiIs7dXHbdq5f2/MGvdyN80nk8GmarPHxa93MNcZoEeehrd1GaiCQw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 05:59:15PM +0000, Matthew Wilcox wrote: > On Thu, Mar 13, 2025 at 12:01:14PM -0400, Johannes Weiner wrote: > > > void split_page_memcg(struct page *first, unsigned order) > > > { > > > - struct folio *folio = page_folio(first); > > > + struct obj_cgroup *objcg = page_objcg(first); > > > unsigned int i, nr = 1 << order; > > > > > > - if (mem_cgroup_disabled() || !folio_memcg_charged(folio)) > > > + if (!objcg) > > > return; > > > > mem_cgroup_disabled() is a jump label, so a bit cheaper than the > > branch. Can you keep that and do page_objcg() after it? > > I think this might be better? > > -static struct obj_cgroup *page_objcg(const struct page *first) > +static struct obj_cgroup *page_objcg(const struct page *page) > { > - unsigned long memcg_data = first->memcg_data; > + unsigned long memcg_data = page->memcg_data; > > - if (!memcg_data) > + if (mem_cgroup_disabled() || !memcg_data) > return NULL; > > I'd expect the compiler to inline page_objcg() into its caller and > optimise away the NULL test if mem_cgroup_disabled(). That sounds good to me. Thanks!