From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD24C282DE for ; Thu, 13 Mar 2025 23:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55028280002; Thu, 13 Mar 2025 19:10:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FF52280001; Thu, 13 Mar 2025 19:10:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA31280002; Thu, 13 Mar 2025 19:10:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1AB33280001 for ; Thu, 13 Mar 2025 19:10:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0624A84EC for ; Thu, 13 Mar 2025 23:10:42 +0000 (UTC) X-FDA: 83218074324.02.BA49168 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 32B9AA0006 for ; Thu, 13 Mar 2025 23:10:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r1LbO++h; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741907441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uQsUOg9Wl3GBkj34Pd/P8J4rXOI9TTuELe3xCAfOaXs=; b=Ow+nHFroSCQyfdIXuNhwoitTlbIuG0bTehhIP+YESAh8xERPzynbNJBunowecBlqmGcPlv 6/m1kmbqHo3dHVER1W0WtUSgcmSVt4sk2crlh4xggpJZiybV8vzwXve9dwt81zF0LMLwPx qFCpuUHZYePNuA7T88oBGhrVCBisfVo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741907441; a=rsa-sha256; cv=none; b=Lo4gNdkA9i5b0Rk67DI08VATeQN9hJkaFd+VUJU25ZWXBkaqCMq4YYTVS1wYLq3Ga/UW6o W9hked8VrwLT+hSGJYM+6+jnTWP9am8hxkTBRTTBiAQyG9F+Eaz5tulZPQegt9zNEMCsqF EF2rC3jsJG+3ix2Kqmw3H4Clszq+3iQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=r1LbO++h; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5C5095C0F92; Thu, 13 Mar 2025 23:08:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 839ACC4CEDD; Thu, 13 Mar 2025 23:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741907439; bh=85C5EaLBPcNm+VfXMxlgckNkHScFkxqfwrT4hbCXaS0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r1LbO++h2zt9ITOCp8zaBNp5bCW3oO8IYrW9fm3oZilRLz2OfzDBHOVialXmivLvD bsPejXMhoq8EeEH1UfZGgQO5BcyfMZ6opeDWAKOUunCcWeso9WZv2uAjmotrBYRJrB wRsd1Lld8tuszHDkPkn9GPUZwcBYsR4A0hlP64N8= Date: Thu, 13 Mar 2025 16:10:38 -0700 From: Andrew Morton To: Andrew Donnellan Cc: linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com, sweettea-kernel@dorminy.me Subject: Re: [PATCH v13 04/11] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear() Message-Id: <20250313161038.8bd10fa54778e984d8f849d7@linux-foundation.org> In-Reply-To: <20250211161404.850215-5-ajd@linux.ibm.com> References: <20250211161404.850215-1-ajd@linux.ibm.com> <20250211161404.850215-5-ajd@linux.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 32B9AA0006 X-Stat-Signature: o9isskc19gew6f9fuyw3gmu884ydyh8a X-HE-Tag: 1741907440-572123 X-HE-Meta: U2FsdGVkX1+cwiHIKod/S8zooEKj0TM2xb2y43bmEMZNrJmqPnkyI2nzaBNEHQwbg0AyIT0teBQeKyVl2xrAumyP8fvzWLDvnGW89ySPLyvkpj3Bs9K7sQEtG6cwOTF3iO/dOErwW9OJ85wN2ud9LS4WzDfdWr1otyKxPUONC/GVMe16qzUxFx93qPIo0D/ZrJQ+Y3x/plrjk2in7ZtCGsr0OVJSg0jt1KouzbOc0hDLoTq+8MOjEqZ/PX+wizBbG7+R79uOHjd1HxW3WBSQtpCGQhs1DKfENdzu5iNZpliFAGLsEQ+39zIUoHjIJwO7prYUo5aImj1Xz7so0congm50VSDegAUlstRMbsnm0cdLE7MJkvqHUkuxw2aVQh7/eEBvYzvIMHr2uP07j9i1UjkBAY3daQvcHqmqJtAP4z/0J0oESPrtbar3DNyGyseqmHF7x70VC+NZRTJ9gScWT+kfJhhrbFEbwUBPJYx0Cf85S/QkunXPI8XFqEd/5gIdfsaAoM1h38olszMbj86d0hzx5WrADPIU0QLxDxRODyRzF0bhqDAf8995KrwHutww+DfEv4lUqotPUWgtOjwKv3dJwfnY8K6T2UlZUopY/lEQgTSTCAg2AYQgl3KMhLG7Mnk3/rBexaBp6INOxMTrh2L2VQ00X1NzlZSgXBXKAikmSBsMiIrO+MoaPgaQQMXOXbF9Bc63K/FLdC5sK/pbuPNQ8TdBwS92fEUHuys7qI+IcupVzNkxy03KwQ5vA0pAATNXu0ICGzZHe5kniuSQQS3cvBJluUKrp0HfCzvJ19IEFxUYE421sDFzLKSdDO4qTxOiuuQh6H4JPHwnG498SzlmPe/UKHVqkpHxGL/p7pnwUx2NC0+AZxnaIIkrdXqiKhAAgDOJZ7v/rg738ZfBtczRXosA5QJTWz+AFLKwjQf1CORU/G87bx27JA+OoI426GEY+d0VsZ6bhmlFzCu 1Upth5sM roIqdodx2b67G9lVhTpazk7/enplCJbVJULwbYWetGgHYOdrQfmLYOxvfgOj+7Gq0J8jkK1OQZ1gbbzTKhA1qRyLKYLlx/M9HdoQ/y6pD2TXg1fOoBFZD6vmREdywy+F3sPwOeX43pS9H2C4W2/WBf9xPazcZyTbxSMliALNsrf+9elb1OUP3jySOUQnSlxjf0SUwjl0LZeO4qJfkLVN4mm2CaH1aFEf17HdSBpCZ8xk1D8jE2LyObLoN05KocbJbneiz+JZwPAHGM8znQxSUirhxyhBoWuX1np2IjCx6bFNyP7FoqE5gH3iZ6gLbtHgkjbJU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Feb 2025 03:13:57 +1100 Andrew Donnellan wrote: > This reverts commit 931c38e16499 ("mm/page_table_check: remove unused > parameter in [__]page_table_check_pud_clear"). > > Reinstate previously unused parameters for the purpose of supporting > powerpc platforms, as many do not encode user/kernel ownership of the > page in the pte, but instead in the address of the access. My x86-64 allmodconfig exploded. ./arch/x86/include/asm/pgtable.h: In function 'pudp_establish': ./arch/x86/include/asm/pgtable.h:1443:46: error: passing argument 2 of 'page_table_check_pud_set' makes integer from pointer without a cast [-Werror=int-conversion] 1443 | page_table_check_pud_set(vma->vm_mm, pudp, pud); | ^~~~ | | | pud_t * #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD static inline pud_t pudp_establish(struct vm_area_struct *vma, unsigned long address, pud_t *pudp, pud_t pud) { page_table_check_pud_set(vma->vm_mm, pudp, pud); ...