From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3A8C282DE for ; Thu, 13 Mar 2025 16:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05983280006; Thu, 13 Mar 2025 12:03:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F263D280002; Thu, 13 Mar 2025 12:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9FA2280006; Thu, 13 Mar 2025 12:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B7272280002 for ; Thu, 13 Mar 2025 12:03:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6C9A21A0222 for ; Thu, 13 Mar 2025 16:03:52 +0000 (UTC) X-FDA: 83216998704.18.AA4C769 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 933AC4001E for ; Thu, 13 Mar 2025 16:03:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=o9i1PIYE; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741881830; a=rsa-sha256; cv=none; b=IFW2ksNa2/YQgBjjg7YjFD+6NAOzpwSar19oHdwuMnRk3thpDmo6TF563+771mcvGrJpOd t92dcuMxpX5594gNQaGMuIKqNoe0hbKAk9IltBbF7r6ZbV5wToWzjoXN1GWh4yMV6nEXdc 79B3Pjuua8IIU570fvkLkPRFlJDL+a4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=o9i1PIYE; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741881830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X2aNBoVywTwdxZk22FjhhRHVAe2XpcpE3nx5TIE1JuE=; b=mqCkfQy017fotHuo6bycmSemaP50zxzQXhbf2bhjamFpN1gDiX5cxZHDndJOVJI9QkcW9I 7z5Z8SGgbO3mu10waKEI5jBZy0vkAO0KxDPmLZdiUBE3p8dvluhcESm33elVqWzslaNJtf QH+FUjTRDCFp+rwUcKmXVR80/XEcTGU= Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6e8f06e13a4so20199956d6.0 for ; Thu, 13 Mar 2025 09:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741881829; x=1742486629; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X2aNBoVywTwdxZk22FjhhRHVAe2XpcpE3nx5TIE1JuE=; b=o9i1PIYE+0hJ8gajqS2aLOg+rLfo6QFKMPkJC+b7oX8Fo0qCv5XJfsc4r+XVlXfHb9 iHfvFdPriAF+fkqsPAzgJ1stTFq0yI5IK/Ft+44Mux/LF5gjKVJU8P1+DF3mtogkGSVQ EFLcj2NOQTE4WQl3mMqhEM8VB/T6aKrqUPNWtm+3aatP+ANuRT/Cso16NUifB8c2PKML AcuuzkJkzEdWrLlj508BV28uv3ObpjKmKEnpvL/5A9a5T6TDJYccpsH4ddGBv1EzsgjJ Ja3JDSQKlPliBlGgFSr/U1Xls83otjOItrB0S0vM85/gbyxppCZ6ulRwoobZmNyEOTSX 8TEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741881829; x=1742486629; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X2aNBoVywTwdxZk22FjhhRHVAe2XpcpE3nx5TIE1JuE=; b=WoyxK2IqbVcf+Wfo1Bv+u0iZvIwr6t/bWyK327c5ApDtnESO6//JhDsACsJEbyKDmo jaXU9wppPVT13YDGvheD8xWWoA9kSziHk5vdQlGanbupZjA3vmy/rZ+tL+h8zp56Qawc qUezLRZVOH/AYbh9oCXES/jzypmq3syVUqiGzxWoaWnI7wJu05dnl1EGrhT0xZrQiiiR 4YT02vKdSEnx66f324+QE3ujTJyHEWNFlS8+2pztTwdba+WGkxZyxDjUEZMJrjwt3Zf7 mG8FQiFHhwYRQEbzG3zgj1YnQHusDypE1ydU5f6qNBU2+9vSiM8CddPPDb8nBOYqCK5q GrIg== X-Gm-Message-State: AOJu0Yw2yVMWj2/NeGOHCsQSMk5boQQ3/7hBcmyA6ST4MypRIcXAr2HF jbu+tZRwX9tJQgcxh6xAXurLo6ZR96i7mEvQ25a39EOVbG+lcJrHxtwEKPEDzBanY5zy1DW+MtQ s X-Gm-Gg: ASbGnctQFc+Am+bwPrtLZ6hdqH+ljH5z+NZe/Z3AlmVtCfDnChQI5DnvEztVpgHQroQ pSwrxqUQUDWjTpcxTMmisUgOC1iVZmh9m3uUnA4u+Vutu7y92a7thzJNhhlZnIT1V4wqUObk9B9 kpI+15fWhqC7XvGc6Dj8blSR9fywkWzjqWHPC3VYEaanCihY0isVuZHQcZyYfKK6jswD3/GJMpc fr6vrORSGtA8WWoRhN47ohc0qHJpNe+GAt3b0DAvSpzXdpmL3HGfDJCOB5f1ciA+7W4MG/FBpV4 Hc9QgE92iHf2cwbTiG66Qg3SVh30DKNkgQMwERbPebk= X-Google-Smtp-Source: AGHT+IGf8tfLuL4MCYSgKSB/JFjFVYYAWz3T29nopDLD0Ikyw//X5VHCCQoRFYy4Up0PrAyseyhRiw== X-Received: by 2002:a05:6214:2581:b0:6e4:2e5b:8d3f with SMTP id 6a1803df08f44-6eaddf4a737mr49293616d6.14.1741881829576; Thu, 13 Mar 2025 09:03:49 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-6eade34d7b6sm10931786d6.115.2025.03.13.09.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:03:48 -0700 (PDT) Date: Thu, 13 Mar 2025 12:03:48 -0400 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Zi Yan , David Hildenbrand Subject: Re: [PATCH 4/5] mm: Simplify folio_memcg_charged() Message-ID: <20250313160348.GE1252169@cmpxchg.org> References: <20250313145856.4118428-1-willy@infradead.org> <20250313145856.4118428-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250313145856.4118428-5-willy@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 933AC4001E X-Rspamd-Server: rspam05 X-Stat-Signature: 5iojoi3gxktxwcyche7x9dos81zse377 X-HE-Tag: 1741881830-152753 X-HE-Meta: U2FsdGVkX19TERZOHvrMNWRPF6tadVCpig2trA59N7Rgly65SiDs+tni77JNT4LKG4T1Zqf+dUcaVYpM2FVbXkZPp22GIxGJe+IuKRpbQIQdYq/fvBAnbDTrX+R0PcKihoKouWvTMm+sFI85PvZyUrx+NEcttdYYdEMyuKFLsl7VSqHCkSQYQs86Ca9Ca/SAYuyHZS/N/o+4gQxs4RvCmAw3CkyY1G4X/Ttv1NUeQL3GhBYj9H8up+6bUmHsux83y5M5rtBmmATO1Ar3tiUtLYrxwUbfoz1m3JyCYEpJNudbFpOcyYBFyoKJ3Ucs+NXl18nBKwpqB9cZQhd4LhRaM8O4oFELSS526WqAb0AYGFH8NhIxbidnADKEjlX/GLmPWqrAACx8tPqi25DsdYIdct+UKgRXC6LnQW3Gslb1OJo21lzty9JG6eq9Gm6cRvVZNXH22e+lmT5CD1apmx161FBvCQ1Emb06+YhpSdhgqBVtDUFpemMswhz2lLBiT4ZFySHyJAoe0Hu0zRxJZJ8Xo9RcJB6t+Cmt/MTRxtu3HHIflzFQBUmYk+d5/WiWmuaWbkIoNWetPpvs7Gqn6D04spoAZpxfz8rVLdvLlyRKRQwr9T3vwpl1dHy8Tui2jzR+4VNnFW5F8RppJvqmen/H6fl7Y19azuTjhnbFB3rP3WJe7I6Si0ivKaDVpSmudCr8TZGGYjIEMIiViexGhPCUnq0yS7hITrciu/H8hFvLxsV6l2ayWM32MfcMdvYdPlY2iBLe4vgRjYD8eYaB0PGv1GBsrkQR3I18PNHw6NEfSytK2Wi6Sm2sAuV1PnGo4Z8NNokk3YnDORP66BbeyqYbolI1rhVlBULeCj7LcBWmRB+bPdk9i4Xxa3WiJKvl08C30y7+7MJBACZ9zByRPhX0jXRLudpFu/MeUi71mhXaDrKdwy3g3Moiux0+A4ROtz3j7xaFzCMQtZD1hdl7xxr JB/9m/EE nvGtLw/ldadsfuEX0zzDJDImMef+oFtQpu1Bh+G+c9vBgxaZxLsi7ducU6gMBQSdxSm0DzkRYk0Fc9G8QfRlIm/yOJV3OwJVirhdZBxcyo/06q8g6+KCwtSg5WLfldNmFRPKfNCHtzWKoAwIRTv/z3IYfOV77k2IIEQ/04L9CIVxSnPMaGOmw4cvwiW8CkA2qKXkSNNbFYdd8ygi6OydvoGg6EQFiCg86J6/aQnREqEuev4Qu9u2l6YrrtFMpVz92nTscWxrgL291XUiqIK+Cqcv53yvTrr+i73PWYBdCsvK3+DuylpVMCB/Sb1eKg60ClNPVFr8wgZK5nwNYemhttWDXzBX3mBQQ9CZhTn6vg7Bw90QQqbctoKD0N0p/9CwFOBFb0PV7dV5L9q1Ftl/O6QH09wBAX/ZsFA6fK0eDljhnwgHu5LSw4WAZ1PiMi39bGre68LoVV9Fez0GNT5xB3ROTRYETt0J8fRaDYKN+QSAsKRmDwVWcBf54tIpthPiBzP7q/bCCMOQThK5F3YxAmDi0cAGguUtnmHJc21Ydgx4UNcCEoZJTwwA0yboKWoogmtGfC+P20NNvN4ii4bpXZ4h92w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 02:58:53PM +0000, Matthew Wilcox (Oracle) wrote: > There's no need to check which kind of pointer is in the memcg_data > field, all we actually care about is whether it's zero or not. > Saves 70 bytes in workingset_activation() with the Debian config. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/memcontrol.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 381c5b565dca..28c251e34cdf 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -438,9 +438,7 @@ static inline struct mem_cgroup *folio_memcg(struct folio *folio) > */ > static inline bool folio_memcg_charged(struct folio *folio) > { > - if (folio_memcg_kmem(folio)) > - return __folio_objcg(folio) != NULL; > - return __folio_memcg(folio) != NULL; > + return folio->memcg_data != 0; I suppose we lose a few DEBUG_VM asserts, but no doubt this function is unnecessarily complicated. Acked-by: Johannes Weiner