From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BDAC282DE for ; Thu, 13 Mar 2025 22:08:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8ED7280002; Thu, 13 Mar 2025 18:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E174F280001; Thu, 13 Mar 2025 18:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0685280002; Thu, 13 Mar 2025 18:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B32A0280001 for ; Thu, 13 Mar 2025 18:08:17 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 259AB1A05E6 for ; Thu, 13 Mar 2025 22:08:18 +0000 (UTC) X-FDA: 83217917076.16.D4C326B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 721F31C000A for ; Thu, 13 Mar 2025 22:08:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zLYkXpMF; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741903696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kOOP8IgCjNDwx0KC5dTPDfqnQPONXCLlNZcLlwtrYm8=; b=XDGDIvzXGRnmir/2SFWPD0iqA/z6j4xDgwg0iI2Zz7Y3IV8H1EeuH46l6gn2H98MmHdm4E G6D+NdB1iDRzi8CGfcaD9lEWHaQrbcQowIR8skAXY2ZPBjrkL5YjzHUHRcXJAiHSMW/t4r ztfSUFF4lHfMejta/H2qSQeRouTqwHE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741903696; a=rsa-sha256; cv=none; b=3mv7/kciJkwm0iujtuTjRYhrVUDuIdveCnV8TH6AdBsTmFK0xXuf/gZ0/2I/TCwfrLcntC 8iNnhcBnbNc53l/s+cDfjuM4KHF6wwxY7rVYOW4Ov1YVQT62bjnE9PE9JZYiAlhytWsBti Q1npHl+USNZfFNsjsDuWhkGxoTP8mD8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zLYkXpMF; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8F2B15C0709; Thu, 13 Mar 2025 22:05:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99306C4CEDD; Thu, 13 Mar 2025 22:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741903695; bh=IRAhxhtjAxwlDedobD/rjMlDvajD+gS5Er4WmKzxIyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zLYkXpMFOIhsH962rYF+opwrkkdhe+6kfeiby9XVU0T8+3ncLboKFq+oonTGkhsyf XrGwqB1PQSouvsvC49AgpspjqpipqKXkKuu8wEJKGpxspTMHxn48pjE7JY96uUbLOU GXRFqh3kodKoRV3NzdZmn+zRPPdwVbnEI984A90Y= Date: Thu, 13 Mar 2025 15:08:14 -0700 From: Andrew Morton To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Andr=E9?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-Id: <20250313150814.075d1cd993a84005d4cd22c2@linux-foundation.org> In-Reply-To: <20250313075924.qulV64zL@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> <20250313075924.qulV64zL@linutronix.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 721F31C000A X-Stat-Signature: awnmy9ykxsaoas6wrxrfkbjkd17oocjg X-HE-Tag: 1741903696-326663 X-HE-Meta: U2FsdGVkX1+SqbYhr2aZe3o8GJkulKtEo4s6Y0dpcTmbFDl4p7gupCHcISRTzGkA0WKBhhPhmULpYMd4S3TGzKajm3mV6nfRKydLzp1D0AoQF+QJ7ixon9fDDJtTG62Gld4zF0DRuB92e9QUBz8yNiCpmSy0afr69aXygxNp2VDvxmJfPG+fZX2ldi6cbD2XCFiWB62BgsKhOz559sUTXcln6tA1DgQE4gdd6kpaKIhDfwRuHg0TKx5CTQ0+mfTiaUCT0dnEc7KsLMGUbLi3N3IZ688OXlNnwbqcWgtN1nTFlBhKBO2QMeJ3g5ftG0qwaI+5gC1W1gvx3xNGf4EgtNCJiG4WTykccK0IHfmYep8pgtt2XpYS8sY77bearjneFnrfj3g0NnQW2VVhOjSYEj6yeqxTKXGQlZisQAib+k4OhFtSaeaV7fI0y7HVKd+56FvT4HweGjMltaB02yjG/HB+FcUiy6G3ywpevkRCiLT+odv32IWb2JkfeLZdx/6rG1mbrIgJ3PqNzdGdkoABUMw6EPHf+TQDT+lNOsxuVAgFeWepROheLHMTlzDW+g1b5PmrA5Lr6ed6mN7wPGIy3iTuNBjvp8T3Cgu06/ymyHtbPsf450jE3H+GYHcnoWvATMrsO7NcwSUUwi0tboA4X2OeR4l2EtQ8KRrnedLayAkrXrFD2pWHgo2lf81bj2l8nKaLZsbVwx9piPKndtEUl48j7v6lHNdK4/3we0sBnmGw1cJ+XAFQQJ4hHbyCCyemEATHPrm8g5da5dVMwgmet9qhfjq6ZEke61ErLHyJNVYnO/R+evUynX8mPnJOVS2wkB2GLmuSs9B5PxykANQKgUvT+lQpY6kHGFIozFe4PUDyvhN1S1/tfDJOa4XjFz13QGBVmWuItop8uUa+iiHEGH+pMxYd0ae07cuuqgIrH73VsNATF5+PHrWVvIl2uEWeTUam/agjzgFRiEBG99v sjdUhISm rxv5e6Cjc/yS08TCS6lY1J9/4YLoyyJk4T6Blhcoeo3c8LQOwGVBZIpVIp8kqO5aBIZBjNymrlv8Mn11K6x5Azol/upQ9zWR60JrID70PPG+1xfdwI97N0txXvrWCMx9MU7l8Ucy/gz+i5KQkZtSIkoAPDGoH8hgdeoYnxROYDuTRYuesrvPidnv4uAZhmuxXEfO1mQ0WBCtCspHaGw5Fb2VVWQcrtdTjoUhzE1kFyw7mClJ3OMwOlZmLOdl6FMDNTZWeox/N532Kbn/4B+uNfu7HKe9EivAOXltlNjIJls095Rg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Mar 2025 08:59:24 +0100 Sebastian Andrzej Siewior wrote: > > > > I suppose we can now simplify vmalloc_huge_noprof() to use this: > > > > static inline void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > > { > > return vmalloc_huge_node_noprof(size, gfp_mask, NUMA_NO_NODE); > > } > > Do you want me to stash this into this one or as a follow up? That would be nice, if you think it makes sense. There is some duplication here.