linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>, Zi Yan <ziy@nvidia.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PATCH 4/5] mm: Simplify folio_memcg_charged()
Date: Thu, 13 Mar 2025 14:58:53 +0000	[thread overview]
Message-ID: <20250313145856.4118428-5-willy@infradead.org> (raw)
In-Reply-To: <20250313145856.4118428-1-willy@infradead.org>

There's no need to check which kind of pointer is in the memcg_data
field, all we actually care about is whether it's zero or not.
Saves 70 bytes in workingset_activation() with the Debian config.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/linux/memcontrol.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 381c5b565dca..28c251e34cdf 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -438,9 +438,7 @@ static inline struct mem_cgroup *folio_memcg(struct folio *folio)
  */
 static inline bool folio_memcg_charged(struct folio *folio)
 {
-	if (folio_memcg_kmem(folio))
-		return __folio_objcg(folio) != NULL;
-	return __folio_memcg(folio) != NULL;
+	return folio->memcg_data != 0;
 }
 
 /*
-- 
2.47.2



  parent reply	other threads:[~2025-03-13 14:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 14:58 [PATCH 0/5] Minor memcg cleanups & prep for memdescs Matthew Wilcox (Oracle)
2025-03-13 14:58 ` [PATCH 1/5] mm: Separate folio_split_memcg() from split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 15:52   ` Johannes Weiner
2025-03-13 17:07   ` Shakeel Butt
2025-03-13 17:22   ` Zi Yan
2025-03-13 14:58 ` [PATCH 2/5] mm: Simplify split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 15:54   ` Johannes Weiner
2025-03-13 17:08   ` Shakeel Butt
2025-03-13 17:23   ` Zi Yan
2025-03-13 14:58 ` [PATCH 3/5] mm: Remove references to folio in split_page_memcg() Matthew Wilcox (Oracle)
2025-03-13 16:01   ` Johannes Weiner
2025-03-13 16:05     ` Matthew Wilcox
2025-03-13 17:59     ` Matthew Wilcox
2025-03-13 18:03       ` Johannes Weiner
2025-03-13 17:10   ` Shakeel Butt
2025-03-13 14:58 ` Matthew Wilcox (Oracle) [this message]
2025-03-13 16:03   ` [PATCH 4/5] mm: Simplify folio_memcg_charged() Johannes Weiner
2025-03-13 16:15     ` Matthew Wilcox
2025-03-13 16:57       ` Shakeel Butt
2025-03-13 17:10   ` Shakeel Butt
2025-03-13 14:58 ` [PATCH 5/5] mm: Remove references to folio in __memcg_kmem_uncharge_page() Matthew Wilcox (Oracle)
2025-03-13 16:04   ` Johannes Weiner
2025-03-13 17:12   ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313145856.4118428-5-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox