From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A15C282DE for ; Thu, 13 Mar 2025 07:59:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B6A2280004; Thu, 13 Mar 2025 03:59:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6413A280001; Thu, 13 Mar 2025 03:59:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E0E9280004; Thu, 13 Mar 2025 03:59:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 20764280001 for ; Thu, 13 Mar 2025 03:59:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2303A81DA1 for ; Thu, 13 Mar 2025 07:59:30 +0000 (UTC) X-FDA: 83215778100.26.6162769 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 34A5240010 for ; Thu, 13 Mar 2025 07:59:28 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=MUnPelFL; dkim=pass header.d=linutronix.de header.s=2020e header.b=PcLhGXH5; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf12.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741852768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OsKP8joiC/AFQkri/bU6lzIAtOi6ZEtSVz09/Tvs7uU=; b=p/bJQxi2WImSVN7/3V2zzR+gUruGErHJcl1fa5fJMt2MoWGgBxAogbTB4am3dalqWSW0hS NGY3fB4ipwxOmfevKvxDLZfpDYd+GScfax7bkOc15T+xX3Gt8babhJFGNVXf246imjPs88 J2fp57wSit2AzWzrT8Txyxqpj04Q1iw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741852768; a=rsa-sha256; cv=none; b=Mq+AXFeygie4D7XvzApz2IfaMiQ5ERAOuxcNYiBRq07zwuGVz7o96mhuNvzb+bLT9aQl9g fsSZfZyMHCtRk/s+eJnlgAAN4tugf82ZRbkuIl7UDbvxwO3YU13Z1I16Bk4Hprg10/vbDI YJ7rpDXwprqZejGaLOls4mOGYON9Tvo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=MUnPelFL; dkim=pass header.d=linutronix.de header.s=2020e header.b=PcLhGXH5; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf12.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de Date: Thu, 13 Mar 2025 08:59:24 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741852765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OsKP8joiC/AFQkri/bU6lzIAtOi6ZEtSVz09/Tvs7uU=; b=MUnPelFLHF2+ZJUe6YgeQ7EU/mn9xiiIFm8Yb0qlTvYpect/PnhtRMCDDPjo+7Xo0oTnwq BYpbUq9u+PTrxtPUoTYSTqA+iHswg0gzrVBi70IQs0GZM6bSxzdq/cuTIe52J4KggT3OF3 ksrAkt5axY358I+NiMnvFFaCWG+P/e4TG857Wt67vqnImbPNN6+0pnamxsrd1HWihS7fzI 7sUdjx2X5rirTgAj24+nxwDix1AKWUCcFU6yJHXuZL3BtjTN3WIWdWmDCWV2191SQ9aoX/ 666MjTvh3FujRVo/KtoSw8qqsksSCopIvY/K5ut+ah9jZLYxtNqLHnbaxHymmQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741852765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OsKP8joiC/AFQkri/bU6lzIAtOi6ZEtSVz09/Tvs7uU=; b=PcLhGXH5Fm2ECNrwOxHtfjfA9b93KJHm76F2MCNyjLR1Cxg7SK9DBRUsTIgEE/ZLT+2Ls7 aNv2gFWW1gUUe0Ag== From: Sebastian Andrzej Siewior To: Andrew Morton Cc: linux-kernel@vger.kernel.org, =?utf-8?B?QW5kcsOp?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-ID: <20250313075924.qulV64zL@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 34A5240010 X-Stat-Signature: igxnjch6tf5gg7di6g1xzxpf1ercz5h4 X-HE-Tag: 1741852768-793292 X-HE-Meta: U2FsdGVkX19L5pXLJcA3rkEI3b/NlL8oUFeugjZEMvrLBn54cjLHFlx48+8hvqR2SCVdDf4XmIST6+m7alBgMvvOF5tfYpakqXN6nyJkCEgW2aOFEdRvwjJvGDePuai4KiPI9P+J6cM9YVCUkEhAUceOufKqBr0NbYBjXRDmVuIRWoTQgFfkPEe//f22Ulbw+E6h3TC4edsBXP8x21u08sE5qesAUd1Kz696N+Ousf0L0qMZCWpRHVU9x7emNQ+MeXjh/65rSeAS1TFcsr4pOoWltbFKHhh58QCJ7EqSgeqPlqbqOMg0lI58G8oAtbSkviunEZfAFO4NCX5VSe8bn6qnghHqRBMDlkPg6eb0Rqr1v37Le3u8XQeT7iyDqdjHFqLMC9Z+gSX/PyOIgWFrIBfXZ2kNDrFEy6jafzwGDdkiCDrdQMVlkcKIIWKmCaz+JohH44nP+KCPHotttTOordgI8qYgCdzXbH9FIbnkYq7bWIDFl5YVVa1Zx8aWXxfrrpQoJSeBtRyQOW3KU/2BdJHOrcKUti+x1xAwQ3RDQfMgYmxSensOrPkqdz0ziZPrXaTGYZ7L4lfvslmJnsa0IpZuDXNWWxp9tKt+JHOR9BKjln9tD7pbbN1ln4NRiz6Bvdg1hGwELbSHjqzcyEeOrRIm69uDRjWp/NuXTDOqWpsK4eeodft36wNxHueia1EcLxFbtsNyALUWBjYCU52S8HcD1IFHL6mym2ENvPRxlNgiEkLe7fxyWcJZZ3PuCfZbivNR24+7650FE5rF8U//Avh9pIpod4Vx3P8irq/g5M6OqPdRzlFBpdZfA32s5THNp9vUCCB0DavxFBCLzaU/xPghyOlwt25iQIDMmzeXivSYFNrQBADiOaJjNhtql3N6XmAtX2B5r7Js0465BBNImX2X3VXZxbgf89hggNkrQOwyAUFMKZ8Hvjy09tBfDgs8q5qkW66gEJXfuSU16QB iNYXNns2 +6lI3Uk2+frdB5rwj7p4+JJjYeKj5ddKQVtAfyi15Y2q1jzY/0tsfTl6TQqYu2FajSEINqVjqwi8gCO3IIK4uD/2F+W4qdKOcEjWStn+4NbEO4hb88FrZs+iY2Qdr/q9QL5X2lbY8EMYyizPgeMHnRm5qK+7R9pipA3gQwaH6p3gNFq962eJutmc3EC+otdDKS2EeN+++ddpzQIR9+V96WvnPIJZbPSAEMI6Q+96mthqvQN/dEfFYCqLeR6x6pf0myIoqwzMLg+ESTEavsmbiUNSMbTj/QwckV7Gj7PTLT8R3bPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-12 15:02:06 [-0700], Andrew Morton wrote: > On Wed, 12 Mar 2025 16:16:32 +0100 Sebastian Andrzej Siewior wrote: > > > From: Peter Zijlstra > > > > To enable node specific hash-tables. > > "... using huge pages if possible"? > > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3966,6 +3966,13 @@ void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > > } > > EXPORT_SYMBOL_GPL(vmalloc_huge_noprof); > > > > +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node) > > +{ > > + return __vmalloc_node_range_noprof(size, 1, VMALLOC_START, VMALLOC_END, > > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > > + node, __builtin_return_address(0)); > > +} > > + > > kerneldoc please? Okay. > > I suppose we can now simplify vmalloc_huge_noprof() to use this: > > static inline void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > { > return vmalloc_huge_node_noprof(size, gfp_mask, NUMA_NO_NODE); > } Do you want me to stash this into this one or as a follow up? Sebastian