From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70681C28B28 for ; Wed, 12 Mar 2025 23:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8797280003; Wed, 12 Mar 2025 19:01:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0FA0280002; Wed, 12 Mar 2025 19:01:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98A1A280003; Wed, 12 Mar 2025 19:01:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77143280002 for ; Wed, 12 Mar 2025 19:01:19 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4A420C17AD for ; Wed, 12 Mar 2025 23:01:20 +0000 (UTC) X-FDA: 83214421920.11.111279D Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf29.hostedemail.com (Postfix) with ESMTP id 09A5E120014 for ; Wed, 12 Mar 2025 23:01:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=NO17S0xf; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741820478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/k48zVdw7SyhnQrDrLHbVl8Rl30ZSbI9RE/c9vyrahs=; b=AJ09DMV73v+5JkfIBoc6/478FH/yFyF03R/JZAKwYquQZ44NLnqt6I7yiw2gxviS8G3jNI bMR4VIdHLNdun9P0JV/vfQ+/eM7U4BNU90oBziqUxBz4Y8yU7W27jxWH1P6Hr7xfU17ku4 Lm/anuM/hEYhOVsjaWs7cn4u9dbxyPI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=NO17S0xf; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741820478; a=rsa-sha256; cv=none; b=RlSxP4cUJVHE6x2htX7CNZUvtOf0zJXs6vnT89NCUOtmtqiSIDXIGdGKj0RdVGOPSUYNdd UihmgFx5P/5l7TUktZpHU2WO/apTOMnb2az2OPJahlOLAJJ1rjH2t/XV2LPppIoyhNp55T fJx8OBfv/YbwBRzg19yDkZ8DtO2TTXg= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-476b4c9faa2so3372981cf.3 for ; Wed, 12 Mar 2025 16:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741820477; x=1742425277; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/k48zVdw7SyhnQrDrLHbVl8Rl30ZSbI9RE/c9vyrahs=; b=NO17S0xfvWkY7Ovxs8fAICjms6VFRZHxsmlRDYy3a/BW/NdmgxRYwgY25Bq0JWk3Y6 FFGjtZ13HFfloWtesFyMieVX8krVDIi3wD8job5zoopMnQri+LxOAKtMWCKO+txwaDR3 GCzUQ9m2mPbS2M7Ns1d1pQCNyJTuxuWHUa29nUYULhb5seJzk6JrL08OuFUmy9JZZwWP R31ZKXq5r8dK9YjsUzAVeLGA4BvDETSWSqPnXCF192xWTsiAos4JiBUxFjUigwXa6B7q Ct3vKJEnNnEL6h6c41Qm3o21f+Q6i+u55OhHtkHC2t/dR9dHaDPrmdAHRm9knsC5zHoT VP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741820477; x=1742425277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/k48zVdw7SyhnQrDrLHbVl8Rl30ZSbI9RE/c9vyrahs=; b=cTYjenA2Ny/JLJBTEN/NwrfwVjzP6wux6STIwGllLzCxoiSvkSnWE4msQCt/vNSsnk S1XyXL6HzxixA/NjyttiFlcJnIQbOAQuR1ea5w4OWWbwXY+frQx/WF+drHyJNQ1V+Fi7 o7ZTJzUH7vBwqo/GARjt1tCj3zPWaVWA/JDVXeatNggRtHKsAnquiiOeriXQnY7KlHFh sCesrx1OhjF42pcFUe4VF6VBwxtdbQakXwlnJuvrxyWUSnwBjxUQS8m4VrwbAElaKp/5 vZg8H8Du/Feu9/lyYyR1eVAlXY/M5mDoQu3UcuboP3ShjJTj9wJgxW+2ng65PxHbvPwD 8RFQ== X-Forwarded-Encrypted: i=1; AJvYcCUmwcPJIGgSL7xIjUlTz+VM/DZcxxAX45I6Q3uINpph9QMPY0oknXE1sxujhgrxHIAdw5+zpFrBUw==@kvack.org X-Gm-Message-State: AOJu0Ywsq5qH/3ij0gZWhULjjIpxyaQwvT/wWT1wJ6YJcCytlkKX04UT 4vQgFG1nT3tzLq8DsyITn230es+d6Xx7QVic+KZI2+48F6/Js7AkdoEEtAxmdDY= X-Gm-Gg: ASbGncv0leFdrpxjkoKfJHP0WfvmSsndF5auKMSA1z8QadjozKzcRxjXrQTog+XXXUE EsNXU4nGSQCX4GZ4f6/5L42ymiMVTMe17YOldtsuQy7nz+wV3wDG0bIVkieAl9kVARIdfopCCJB nfpfH1kswTmFJ58y6hZ9WwDuILt5qU/qdvlJCyYPJDgALo9fqlElMSAkrY1SrB60OsoBVmkEzAC as7Mz6aN8zXLzz8dbeyxe4sxaExU1+As1DOTOyaME6V2pKVjAImpOvQvdz1Em19F7uK24wcpElF 1Zri/y/m4XSf9fLCDIjGbZpuP39H1aZJi6Sj1rNkIVY= X-Google-Smtp-Source: AGHT+IHh1pCjpeXCj9O057it0duPj9RnmfTnaglKfOGbIcKnK2/5+F6nwuoQMbtwb+1X3EUnHJ6fdQ== X-Received: by 2002:ac8:7fd6:0:b0:476:9001:7898 with SMTP id d75a77b69052e-47690017ef3mr156653221cf.25.1741820477055; Wed, 12 Mar 2025 16:01:17 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-476bb7f4f08sm822891cf.56.2025.03.12.16.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 16:01:15 -0700 (PDT) Date: Wed, 12 Mar 2025 19:01:14 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: move do_memsw_account() to CONFIG_MEMCG_V1 Message-ID: <20250312230114.GA1247787@cmpxchg.org> References: <20250312222552.3284173-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312222552.3284173-1-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 09A5E120014 X-Stat-Signature: egcy17kkxgayiyzs3cp9ijotz5mtr3dt X-HE-Tag: 1741820477-188191 X-HE-Meta: U2FsdGVkX18a8n8aZkPqOq+iMpaiNhFryWASM3L35iwTcRpnPZNbnnqoQ1+oXyPopNsdGx7V+NMgAhJWh7G2f+SeVbvtVjXijprq6+Z9+s76lTldOd13vaqFSCPdXRraLW3VjT5gxqBN/PZdEqV4V5/6uHwP1cZfDHTQ9xPQ4gu1UFgEwHvij8rFFK14lczu/kZLEldOfi3HDciAyGwSh6uWdNhUvaZpP0AkTWyXpk3WvWfWH/zbgr8zRGZKmbnhwF+BKPWOWTw6/m3YvemxcJlGIkkhy5+2SGj1pZQh/cCHf29Yra+a6MbpZ3Q4QVZlVmyk48vrM5KCxQoM86/7musWhCJ9nY6HmiXVp9dka1EB5IX586WZwtOskf2CUFYiy/YjwyElAHT2YgJ/qaWMzmbRcM0l7sK+mWAxZeGgvPG23ye5NaKiRmp/QY4ucD+y/4x3dr4E3nvtgfJtLAv3w4l1s4CTuGccyORuxvD1jMoQqcVNcHc6mqQJl6/gGFQLcx7UTdgnZpxz/6EtmQ65QJQTnghN2jdNWyPTSveWa1LV0juz3Qdeo7ebN1umaKr3sTpzuyMH50sbGKYE0aUxFuy7aDzRMAUrhhnsU52XE8pMdB57l0fbwby9ljN/1svzsNiOQ/LKVrUxjQ6jdCFX77OrJBnPaJ1jQH4QuJk83MTDpbQ/Ctu5XeTVYoyFrdZboZa36IxO6LTwsiLXzVaSpzKNJ2rkEkhzqi0a8Kn5rSaC9t4i1Ux/Qv5nQGsNmFJx4Jg7RLBm4nzAo8MFDA2VqDndnZElpD9UKTv+/jBpIYE2g4xzsmnnlQ/0P+B/TwTT0BVOKUc54ihIMfogU0iHJMJJK5iSlwiBxUa7JWwOZR2R4rzKTSoqevHIaWpWrV6X6klFkdIP9sesMvXNJ0ipGWeiBs0pB44LNFLn//lycNoMlpAoL2//g5RPLJrDkeeUwfBC9ST0RW3fVX2D9Oj o1W7ZE6F cODz9qgYH2pTqccinLXSmO99geUwnyqAv+yb03y3w5eQAFtxP5dXJ/iV5crMDADCU8vNnawn7/O1rMckE+Tgrxsq1TkPzO5UBx9Ix0I/NAJAefLGyMrAzUC18SQA26aB3RHD5pbMbIvmUC/hFIWFuaG2Q1DzoGA4oOqo8Xk4PkP65z4jz3B6Pz0ufDmTUhEzMro8vTpIAee56GDnQ1bj6+ZuutbMKgW3gTVfMfwbbMmFtfV6JFNt5sfb+aJqr5QYXgSh2py1eoiOKMNPoc8kXq4IhCUpRoKUfvcWHuiiS8FxNKKVy9QqV4JoCL0FVnmKXkP2LX8RnsqV8z1zXeiRaHOz/aYXJ6dqTs2Z6derXbubKwYEgECw06/nNHqcXSnX99uW0OIasWiwS7a2Ggva+M+F7CiJC9r9yJ3HadxDQHl4jP8MCbISelqdKn2n0+0+vqXHZ/v+8fqlqxCL4fTTpJVN5dLXtGwEgN3eJUPn1xlTqWjdGxGiIQ4+9MevgiEUVjV57Bnawkwb3hNZZXPFbM4uKWs+uAx7Cm6AZMxGc63xLDcd/K3q+tdGBgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 03:25:52PM -0700, Shakeel Butt wrote: > The do_memsw_account() is used to enable or disable legacy memory+swap > accounting in memory cgroup. However with disabled CONFIG_MEMCG_V1, we > don't need to keep checking it. So, let's always return false for > !CONFIG_MEMCG_V1 configs. > > Before the patch: > > $ size mm/memcontrol.o > text data bss dec hex filename > 49928 10736 4172 64836 fd44 mm/memcontrol.o > > After the patch: > > $ size mm/memcontrol.o > text data bss dec hex filename > 49430 10480 4172 64082 fa52 mm/memcontrol.o > > Signed-off-by: Shakeel Butt Nice. It being a jump label avoids the branch, but it's still unnecessary text and therefor i$ burden on fairly hot paths. Acked-by: Johannes Weiner