From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD681C28B28 for ; Wed, 12 Mar 2025 17:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F08A5280002; Wed, 12 Mar 2025 13:23:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB7C2280001; Wed, 12 Mar 2025 13:23:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7F5B280002; Wed, 12 Mar 2025 13:23:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BD587280001 for ; Wed, 12 Mar 2025 13:23:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 81C2E1A14D6 for ; Wed, 12 Mar 2025 17:23:55 +0000 (UTC) X-FDA: 83213571630.05.8063CCC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id CB5FA18000E for ; Wed, 12 Mar 2025 17:23:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NRr4R0RH; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741800233; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bn7KrBsZ5kzC+I42d42hhr3tfVdQp0dYcl1cKTeVorw=; b=8Ov16a4KaOUaDWP7b0GmoKgqyC7jCXaMO6TIQzkmCxKob9IB/HAY+SdYmEProAS9MX1cVq ZYC/25r+8CXoBF7eH5SPh5Hag6uJezoRm198/Nyqzrguy2vGVoXIBcAfPsmiQZ/TvRbLBr mDj6vy3All0h8wAC8SVAqKmvw/4pAss= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741800233; a=rsa-sha256; cv=none; b=Hb5ha8pUywl5MaLIgbBph5zpin8lUkvjAPa1xubQpfraG8jMnAQN/NCMfs66IvJFMhD3ai bWytDqZdSi53Yl7Yh2doGFZiNMSXHJH0j4QoDJSmQJZblJsLJSvvH/0q38CORqOWcjauG9 elhsXlbDmf8zUV8vfbStsxX3ri+FueE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NRr4R0RH; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2D9DA5C0356; Wed, 12 Mar 2025 17:21:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D129C4CEDD; Wed, 12 Mar 2025 17:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741800232; bh=wh1Fxnshp8oLvMCLtrPIX0gzdOI/IeVWj1yLkdb7azE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NRr4R0RHiZhCC3DDkz4iudYArYbHByGgGONNO9lO1z4AeK9haFC9nUSo0tIMk4uZg PtqIG3RrzgNEsNYlPUF+8SuPcE6YvNMaWZfBJL1R+W5nLVBxeddIFFHvMC2X5y6wge SRpwX++BHv/19EwajZMqXWaGN9RZtqDtcMEDGqwvQia2IoBa9CHEnuLeYEjlyHmpUZ rnSvqBIIsZbh3gVtcMl6y/Z1kdqVFLcGfDgJBbmn5Iy006ATxFpCazAeQSE8J+KrZe qAyGhA8xuTnoaX1gGeEda7nUwK8DmldMlGVIK/qNrthZ50QjB0FpyWRUAsrxm+mFeM JfWfkxAxCdaKA== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/9] mm/madvise: define and use madvise_behavior struct for madvise_do_behavior() Date: Wed, 12 Mar 2025 10:23:50 -0700 Message-Id: <20250312172350.59632-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <2a2eb9de-c8d5-4be0-afec-2efd334dbab9@lucifer.local> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CB5FA18000E X-Stat-Signature: qh6jg1hkpktooopgmm938bcmucqpaaw9 X-HE-Tag: 1741800233-548899 X-HE-Meta: U2FsdGVkX19EWz4v3LVB9y9ZkG7k3eUxdmX2fIEgIcxvfHelWRoaLDW0/JLRjQcILQhOar3khpnXU1zlTPmCI5TSGN3zu5cs2Tyy2Sr7FGSwZxzpSSgvFEJUzIJAQSBtCVK9B5t10rp0wuLs1VEWTeR+Nu2wvluODuPL6woV6yPo/3FjMuomdjJhsafkyFNK6ALOdPgGPbOnjCveXZO7j/09N46din/IhGw81va/uvYovahMfawiKDgZLjWwoA8Ms0+Hpih5WQbojZi5ltawoRYgcBUBPWKQi3xthkDZCA8gImbC75oQU9sdRw20O1wMM+RlNxsYZxFi4z/Sg8qHALv7mpDVQgpS2uCcZb7Dte+yRdo90gjZTrKQvem+Hy3F2q1V5ZBfwDa9e/MJ/09Er+TCHuZty2QB3dZBEOUdHOvEPwY79EbI1FHjAGXj7dGahNZJ1fOXImcF7Af+iN2Vyg4OBmiku7mCyQJ/Zv2Ydg6ie4WXTHrg1cP+i7h7NRj+dnm3cYfuhimnS6X6987jVSLdbhGQMWEGg5kaPf+BcAjhc/oZrrM9L0vBZGW6jErQ00oruWV6V36qojYmC9Si+Lj4BtemjVbgZ8IG/sL4c2N/2DbBcGMctWAj4Fv9s3ynxLKiIJ+9b1ivKIag4aXc5zonxwIK/Ylvl44y2DUm+qRUyNYYoCXuS1MSj0DPqqyLgqMRZBlsc//ZG8IV5TNptayIX2A+wqsIazMh7ReE7Ok5lLNKtfBZEkFJqvT2U/irvIsb2K5oyAuc4MtUYte5MRZO43OMNV6Gb16eBm+hhQQXr0xZ6aKwD99FUNb7c3Fdp30OcyzT4UGCMnfjJOVgO+/e2a+etWJVCaN3+8l0fayj13Jyn85CpjrL12aRd+t0uZhmyisxvWyRWtUCUOxAHREPd3E3ZwGdk6AYGEmVk24MG62IK4VF09mQeQx20TMirpEh7ey0zC5HqCn2Oqj 3eIalSF4 po2zwzAgDw63VDXmMkRPB8+KEGJHC5KlbBuswaDWfs87iyTB3GNbkXFYp8wCgJ+FZQTFvoWjUE2a4sLf/JnqWUd/D48GFT+ymX7pE6ZwmB/yD7AD20bX7QIIRdxmisAtuc7K0G0qwAYC+gvslRRRKXU4K5bi7Gi/33Y+9HQlCXPEDhBvoD0qovBtByHs9J3n49S3eAIhgxLiaC3Ncb4hXI5956RFNr0w18Ki4XICNsS0G/lHEFuQFSuirg4Fsdpwi6JRiqUlTB2NPoA5jc+GH7yeU+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Mar 2025 05:47:02 +0000 Lorenzo Stoakes wrote: > On Tue, Mar 11, 2025 at 01:56:17PM -0700, SeongJae Park wrote: > > On Tue, 11 Mar 2025 12:17:40 +0000 Lorenzo Stoakes wrote: > > > > > On Mon, Mar 10, 2025 at 10:23:14AM -0700, SeongJae Park wrote: [...] > > > (I wonder if that'd be better as a typedef tbh?) > > > > Something like below? > > > > typedef void *madvise_walk_arg; > > > > I think that could make the code easier to read. But I feel the void pointer > > is also not very bad for the current simple static functions use case, so I'd > > like keep this as is if you don't mind. > > > > Please let me know if I'm missing your point. > > No to be clear I meant the: > > int (*visit)(struct vm_area_struct *vma, > struct vm_area_struct **prev, unsigned long start, > unsigned long end, unsigned long arg) > > Function pointer. Thanks for clarifying! And I agree this is a good idea. > > But this is not a big deal and let's leave it as-is for now, we can address > this later potentially! :) Agreed, either! :) [...] > Thanks for being so flexible on the feedback! Appreciated :>) Thank you for your nice and helpful reviews :) Thanks, SJ