From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C277C28B28 for ; Wed, 12 Mar 2025 20:57:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3C63280003; Wed, 12 Mar 2025 16:57:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE9E9280001; Wed, 12 Mar 2025 16:57:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98AF7280003; Wed, 12 Mar 2025 16:57:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BD24280001 for ; Wed, 12 Mar 2025 16:57:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 759FF141681 for ; Wed, 12 Mar 2025 20:57:25 +0000 (UTC) X-FDA: 83214109650.11.67441C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1230B1A0002 for ; Wed, 12 Mar 2025 20:57:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A0vdGSez; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741813043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=slUJe+JHhJOnq30PEtJv6XBCtRVaMaEHLPY3w2dXjCU=; b=6M+gKc+Jhp8b+bjMbK4XyF+O+lLlnhCsTboOW+jCYAe7WNsjcYSseCUtcZ8IClTwtUU8AI AS9w2B13Qsq6/M06C2xVYMDpVC9PIck2Udw7hei9qMsmP3+kCIvfS5YEERMzSiWdnimYS1 jqhhQk0+oo3IIfEglwxOzox53LKvVPw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A0vdGSez; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741813043; a=rsa-sha256; cv=none; b=Ch7RYb0Cvj1jT0sVNKvkDA8qsqHbyXCiPTfWDToIgujOpaoZGQEPXkqY22x6pTc/qxYZMA 3kOWh2g/cP8E4RIH8L2VFcfYUXacgwdHVysFwfSJbu6bZAYqgTbwi84Dm/aUC+kBecfk4g pinSmT6El337dscyeZzXeSc2UhYzvcE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741813042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=slUJe+JHhJOnq30PEtJv6XBCtRVaMaEHLPY3w2dXjCU=; b=A0vdGSezksR6SG4T9D+Kr+UxQwtZlIKsr0kXpq774s2dvMrsRYNBUaTXVihaw1BTm2aLs3 BQ5M2pWGGOs/2b13QUgCrO/uFsp8125SbnXkOcLvLjkGxlTkN79o5aCZvMEKRhNUB+vCJN Ld+DLQT0XyBBNe0JBJ9+ld4FDn8Un5c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-I7YXEbMKMNelplVyHKupUg-1; Wed, 12 Mar 2025 16:57:21 -0400 X-MC-Unique: I7YXEbMKMNelplVyHKupUg-1 X-Mimecast-MFC-AGG-ID: I7YXEbMKMNelplVyHKupUg_1741813040 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ce8f82e66so958015e9.3 for ; Wed, 12 Mar 2025 13:57:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741813040; x=1742417840; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=slUJe+JHhJOnq30PEtJv6XBCtRVaMaEHLPY3w2dXjCU=; b=Y00RuDwBeVNjEdN3339IJhS/EdmiT8whSsZBb5mES1ax01AnJBT9arCgNrqRDcGAQV 0wGAa4nx+3hjW0rQB7sepUy8z/coH/sjgQRmEo+zg9Qhvvi8olHWr5sXGcsAh3X6l0+O WMhI6v6VXJxTWouPhvKgTGE5ZaS0Uaxwq+R6lCjkKGMk384aAgLTQtfi7yI+28egRWhd E6JoK8DHR3NOlfICaeuFvRlDjwmzptlRPgpqty3huLwGN6dVxFTxkPNNXrpGJZ5Mgx3f xm6GaoQirSkyh42K1eLOZtBEo6096OKj5+t+wqD0Q6h98eS/rrJOstph9LGTTMbV9Nuu +5eQ== X-Forwarded-Encrypted: i=1; AJvYcCXQE7OSJhPn/FRp5OA3m9OzCqhWniN1+5WoixGVPRpYOVfDOO9HAz/rZ1Nsmj3Z5KD8GgQinusJJA==@kvack.org X-Gm-Message-State: AOJu0YwGuaze4La6ib/8D0RWuEE2C73/TU62/EgVjg/1TfBagi/gvsGx gJfg1QB8sxGM7qvxoK34r1gM9hKpS/5ASdG9MHpxjdUJOiRJxgRpxi8E8FvNFEelfv8Z1QnkgrC B7PaT+jha74CVKE5Lcq1Tiy132pbyOqgfuRD+UDD4sd0LdL5g X-Gm-Gg: ASbGnct8ZFkBry7erbMeqacw5EvYi76jXA73XFFJQsUAfmaSkQKOBiONz8zkjCGINNy o/W9PdhGC3kk9fLtUYLiRXt73G/gnO0KS8eF0UhOBPiE8ThMmcQMuV0J4RGxRpYDx2hsAxKmaaW dbINWIl66KxBQ1KSl7fAW1VZhJfsx/m+gV2e7eNwllyDz4y0d+UHFQ3nirKoHQlSO1o6uv/rVG3 CAWFEA049KQoRvnTboJU/Ui4GyQk4sl3OfWZ1OhSvGW+X4JEyRLHwuc4LqosiyfcPQm5UiIb7LM c3eulPXd7Q== X-Received: by 2002:a05:6000:144d:b0:38f:503a:d93f with SMTP id ffacd0b85a97d-39132d9908fmr17334959f8f.40.1741813039718; Wed, 12 Mar 2025 13:57:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3/+BK82Z+aTDjO7POooWoHYU637cwTUeXYPG2W8VKTA2QZ3BgBHzUd7t9xStiQ+fOSVcEVA== X-Received: by 2002:a05:6000:144d:b0:38f:503a:d93f with SMTP id ffacd0b85a97d-39132d9908fmr17334939f8f.40.1741813039371; Wed, 12 Mar 2025 13:57:19 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfcb8sm22470458f8f.33.2025.03.12.13.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 13:57:17 -0700 (PDT) Date: Wed, 12 Mar 2025 16:57:13 -0400 From: "Michael S. Tsirkin" To: Nico Pache Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com Subject: Re: [RFC 4/5] vmx_balloon: update the NR_BALLOON_PAGES state Message-ID: <20250312165302-mutt-send-email-mst@kernel.org> References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-5-npache@redhat.com> <20250312025607-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NXK6rpgz0dJQ2knS27C7ify3JYEbr7ejo2g_zjXNOqg_1741813040 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Stat-Signature: 5cxeu6t3ximpfqucyidgjx9qqr8ana7y X-Rspamd-Queue-Id: 1230B1A0002 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1741813042-551122 X-HE-Meta: U2FsdGVkX1/kQ7h6ZYAbGk/FC5xQjtxM+hzLav7mhjiW/sTheY6zdG1em33bpsNMrfoAvkwDJNQyqM1kIASxiYm2Tb/KwODGYoIEyt3AhGVZeHrFFKT6hLV6dXGQIabjBenWMfOV+RkUNUfa4Lq25yhkSbmyrQvBlZqWg5sEqQ/ASUwO2u5GpPtyRLBG1HPsPHvizTfoviNyFKCUX4DU6dQHecQRDfJPlyh7pI+2lRgp6oiiOwYlraIRcE/vxB/4kAzPE2g0UQZT+3VyY6hPwKhlVtvjid7QtWfs0jr9fYm9y+48uZkV5nz4Wnce75O5kP1xPvSSIw9ZVctbCBk4nneUaXlt9YUefyYwNFpVNtHALwtntm9CHsd3KIJaf+jEdWLBnNjDrTcW5KqT6DTzlfkVT824fX+TqFxGfOm5jqeGikdrUJlEOHuta2DCIiO2LZz1SRt5SdXIRfJPwbjNZ/AalYy3CTl0IfmRVgYZgpKPRgzT7NdZ5mw+8m1q5Bf9LhN4GPWcEuC4U92IS025fAnkFA+bA1NXx6Pbe3f2IFg4kXAOF31RigmLpgJGAaCs3Tb6i8WCQzJb8Uv5BrzZhkPZ2F1r9909D8krqpk5Cgn0LrbsoKOKUBziH2l3J5BkW+4BMn3G82Kh57LI8cicpOELBBraLl68y7TkyfUI6jwEztivH4mzOxKTreRuyaEFv3pb2P25+N9R8PQacpTRiWBxvqbcCR8pEZdJ9WEWUdogQrcaISTOFlAP1fQr/dgVxksuKem2InxWMoiDkXlsY5ufH8SLoXqlLoqQMgT5GeF7jwyPoIjc4SluA9juW4s1k3sInpEA+xyc+4ZvXG5zRptWkXaiYwmK2GwdZ0DKJz0JJ0BhARO5X/0oc5KppkFv+gbqUIdgD/XfSXJGigg8uPeMToBaeyl7AyBYS6VCIDtbNTFzXwr+vInZM0MInWDYLXUT1AA2dNTlG8MYBu1 INyX0npU HfFHuhJnkWw5GKW72VdFd0jhcFOAqmm9lTS5GaCCImFyPfI0/wSSsrhop0enr1sIqilRsv26bLZZbuo3G4Tfjw4PrdKRbci6wnFgZcT93dlT5IuxhHYiRtirc8onIW7lPcugv2tgRx3h0FnsBCkMHyge42jJ0pZ1Rd1Xdrko8hP357DxEft7OFFuSbSUt731KoTqvWewEtoCc0zxWdyHnzvbu2h2uf6HwkveQFCqr7dbHRFz6KXgtfMANLUI3HLkXgXl7zAoG5E4FKa08rrp/sGYKOL5e7Rb61cDLG9anbyhnIzQEDEVdjbCcamE2qoeTM09hiPFQUgfLjlWB+VDFNrUGx3p+ehgqQkRg61cE2mpnLgw1I1y2qmfRg0Cb8cZSHvPTD75++QfdfJK658kWcPfGB4cXiuNXQmbWBc2eGk66sFTXzPgV2uk77dbNRhpPcM+qLYMqG0OC8OZ8th+VYU+f3Qw3lAza1gxL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 02:11:09PM -0600, Nico Pache wrote: > On Wed, Mar 12, 2025 at 12:57 AM Michael S. Tsirkin wrote: > > > > On Tue, Mar 11, 2025 at 06:06:59PM -0600, Nico Pache wrote: > > > Update the NR_BALLOON_PAGES counter when pages are added to or > > > removed from the VMware balloon. > > > > > > Signed-off-by: Nico Pache > > > --- > > > drivers/misc/vmw_balloon.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > > > index c817d8c21641..2c70b08c6fb3 100644 > > > --- a/drivers/misc/vmw_balloon.c > > > +++ b/drivers/misc/vmw_balloon.c > > > @@ -673,6 +673,8 @@ static int vmballoon_alloc_page_list(struct vmballoon *b, > > > > > > vmballoon_stats_page_inc(b, VMW_BALLOON_PAGE_STAT_ALLOC, > > > ctl->page_size); > > > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > > > + vmballoon_page_in_frames(ctl->page_size)); > > > > > > same issue as virtio I think - this counts frames not pages. > I agree with the viritio issue since PAGE_SIZE can be larger than > VIRTIO_BALLOON_PFN_SHIFT, resulting in multiple virtio_balloon pages > for each page. I fixed that one, thanks! > > For the Vmware one, the code is littered with mentions of counting in > 4k or 2M but as far as I can tell from looking at the code it actually > operates in PAGE_SIZE or PMD size chunks and this count would be > correct. > Perhaps I am missing something though. Can't say for sure. This needs an ack from the maintainer. > > > > > } > > > > > > if (page) { > > > @@ -915,6 +917,8 @@ static void vmballoon_release_page_list(struct list_head *page_list, > > > list_for_each_entry_safe(page, tmp, page_list, lru) { > > > list_del(&page->lru); > > > __free_pages(page, vmballoon_page_order(page_size)); > > > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > > > + -vmballoon_page_in_frames(page_size)); > > > } > > > > > > if (n_pages) > > > @@ -1129,7 +1133,6 @@ static void vmballoon_inflate(struct vmballoon *b) > > > > > > /* Update the balloon size */ > > > atomic64_add(ctl.n_pages * page_in_frames, &b->size); > > > - > > > > > > unrelated change > Fixed, Thanks for reviewing! > > > > > vmballoon_enqueue_page_list(b, &ctl.pages, &ctl.n_pages, > > > ctl.page_size); > > > > > > -- > > > 2.48.1 > >