From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EAF5C28B28 for ; Wed, 12 Mar 2025 22:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0F3C280002; Wed, 12 Mar 2025 18:02:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBDF6280001; Wed, 12 Mar 2025 18:02:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CADE7280002; Wed, 12 Mar 2025 18:02:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ABDB5280001 for ; Wed, 12 Mar 2025 18:02:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E59391416A0 for ; Wed, 12 Mar 2025 22:02:10 +0000 (UTC) X-FDA: 83214272820.18.67023EB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf12.hostedemail.com (Postfix) with ESMTP id 3610B40018 for ; Wed, 12 Mar 2025 22:02:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uXL3LVAD; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741816929; a=rsa-sha256; cv=none; b=1QOjcMxIYzXFWwjQACOfErxOpcqZuCEKhWRBIjZHnJYKS7o3DosnREARvTPMPR09m5rXne QCIS59+lB9WfvqVXl7NLCFpE4V6m8NQNiudMO3MzwV8OBr+xAp3QNWUSwpbdfAPm+B2VB6 spPRBqBve2sKHcHy2SoUi3YKQMlNz8w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uXL3LVAD; dmarc=none; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741816929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9kguR8b+wJNEmJmI5/QqyMKcLtbJ7dsZcZsDdrsKAuY=; b=bzg5/SWh/lqjTdOoXmuBGfLDpjwBTB8y6FEL5sjo9SqMbxaHysmA6xvhAj1SvZqT18nUkQ c/kJGuer/CQnOOExYX3DaaVvxa94Urcm+MxpSFb42UDbXvFGdK55lcm1qoCt4Hp/i+9K98 nD13q6KB174IRuyMH9QLZ9v5CUzBz3E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6F26EA41AAD; Wed, 12 Mar 2025 21:56:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A008C4CEDD; Wed, 12 Mar 2025 22:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741816928; bh=Eo6Eu8e360fJQvkuNRFhWM189X1XwXkzKCdWrCxAZRw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uXL3LVAD3+MFrG+nB/yBh+3wFqjzEIzbsU/6mRJrWe8wH29REn8yCGTrQ4F8jnEyE VaGHdIAMHzzFmGEa1IftorEndl8I/j3XrbwbVTXRUu0A9fyCXtR/Nl+YWz9yd+S2/q FK9x9TvIkjcTi+fe1dmicekWQaJhgyAcBSnjv8a8= Date: Wed, 12 Mar 2025 15:02:06 -0700 From: Andrew Morton To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Andr=E9?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-Id: <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> In-Reply-To: <20250312151634.2183278-20-bigeasy@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: d6gk6ftwn3dtnn5pmrzq4pqsb6ojisyh X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3610B40018 X-Rspam-User: X-HE-Tag: 1741816929-185125 X-HE-Meta: U2FsdGVkX1+Qnkbra2TvYi3rvFGkQWOBCxaxxD5idqlmvS6z75GqzQZpmYBvZhMQyrifA+x0u0wWBp8Zh3vYMxY3kDHmvLBNLEIBLR8234lPZl9VGZYC3l6sXlKoZ1bvR7Akm/TVWPF9ka8wsqofapNOxvHCUvsHTFXzy6H9fP6zviyvJiuGjGGjcPX+UYvGUDpwJSAyIy/MuF2W6/Gy30Rv+iv19h18Mj0Wfrtog7nJNbr5W/9DIjvVkVTqqulghUASCFparaFy7alimeWXr8ju9ouD16StzedugfLSQqNzPz+M5zo0hA4A3BmlWqP4OC1yqxCnZ5xBv+ORzYjxwx1nh0T571W1YJ1loJuh5T7AoDryhV97zIG+bW6CRwIvXfss2ZAUEn5xyTrp82G17mY63p4uvk7O0Jcpoejc3e8ZvMenQ2icjVVDccEneT6UXs+xKU9CevWGoVpTuKmHXkEGCgr6ntPlwSQwBnyD/gWl22sDILKoUDD5HYKWs1faHU6a3ee8WTYue6haH7ZEvTwsFYVyNyFUZnd0S2LW3up2Ag8x7A3SsGh8Ty17StfybzxYM3sM2spT6GdZb+c3v5sq6cpaDDFFYi/i7FIdie+0BCRiT1Hd340Wr2XwvSGkvp3WX22eyjXAA4faBsO4SdRu4t1cjpKHYYQ0fq/WzfqiDPA7as6KOv+aDKibX+BtT6gEIib2B0pdXkrEvQDNhtbijzD4EZwvKCCzaUZ0krY80Av+I2vvUlxjt+Q3cNTzlp4K/jPjIe+0OxcGv4qpPUQXkv+AP5IAMUnDA/BIKDBKWKIjIbfSyTzUIGzRLDi/W22Nq6m3XSu25MI0tMGBclKMX7HpzbKRzIUOG0NGae9ZdOO2Yt01UORwT5l3uq9FK1qXvAFlPhVwNA3oXeY/bVFbWIndmof2EIWCAjEK4ZgC+TmhTabDveqrosjyBjcb70hNrPDiQwiQkZvzN+H KIWeTvty lN/+1ToDAZiztERSgWsaMDfQ3PaXh1IFeEPHarZ4C0zA8uVdS36etv4APoXqbmWRsY0wN8WcFd7spIZii3uaSW6LN6vA9wR04LOgenm/y9YiX5CQICFEiSiB02qgW9z7mwPaqtxxfjwoYzo2dNXU7ADsJ6ghql/FJFHOg4yJ1LMrQdgLHUrf3tpQKA0HzCkZ4lpR1291b64HaVtAMscSY9EVLGByY8qEcF9Gf9bAsVVCngkm1Vvef6R0RCeDWfW5Opvx0qbRW+TrVLUQCH6sRU1iEgeJUTTcwhfOrQs9puUrpa3ZsSqULg4JwPpmKWMVFU7ZB65AWfeF1TGafRaGrIGLF31TMWx4WN4Z1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Mar 2025 16:16:32 +0100 Sebastian Andrzej Siewior wrote: > From: Peter Zijlstra > > To enable node specific hash-tables. "... using huge pages if possible"? > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3966,6 +3966,13 @@ void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL_GPL(vmalloc_huge_noprof); > > +void *vmalloc_huge_node_noprof(unsigned long size, gfp_t gfp_mask, int node) > +{ > + return __vmalloc_node_range_noprof(size, 1, VMALLOC_START, VMALLOC_END, > + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, > + node, __builtin_return_address(0)); > +} > + kerneldoc please? I suppose we can now simplify vmalloc_huge_noprof() to use this: static inline void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) { return vmalloc_huge_node_noprof(size, gfp_mask, NUMA_NO_NODE); }