From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2341AC28B28 for ; Wed, 12 Mar 2025 06:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB21E280003; Wed, 12 Mar 2025 02:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A61CA280001; Wed, 12 Mar 2025 02:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 950D8280003; Wed, 12 Mar 2025 02:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 78DA8280001 for ; Wed, 12 Mar 2025 02:18:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A494A160B24 for ; Wed, 12 Mar 2025 06:18:44 +0000 (UTC) X-FDA: 83211895368.11.C217CFA Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id A9725A0009 for ; Wed, 12 Mar 2025 06:18:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741760323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gNAuJZgOI44mefbKQgqxEEYUMU0COXT3kRYhQmw0u0c=; b=jcgIKOkn5qz5p+/kmKjzcdBqqd3GvtFSCokqUyp4CLtTnfNCz3VURuTPKKzXfW6UoFVMk6 DLxK48phvqfSa9mVS86tHrbzc4tNqRk9YSQkZ9suGOa+Cm2h1Y9Ybq4zk97bPI7mzBov9U CgAGxX5vswfRpYuou3Opqccr4sui8r8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741760323; a=rsa-sha256; cv=none; b=IeJPcdQWHSGoC0DdUDwzTIdrMwctyC/CoYBKtjoLnRFDHvtYKSs9st8cNutWib+dbv4ykt 2W4h7qgQr9raaC+l3oST5EZr+KGyqFpf0p6t8G9VveebDS4+C9iDOTBSQAQGfFUnT9a1nA qiGRwZyX5edllobRyGeT2stKLAonQBA= Received: by verein.lst.de (Postfix, from userid 2407) id AFD7868AA6; Wed, 12 Mar 2025 07:18:36 +0100 (CET) Date: Wed, 12 Mar 2025 07:18:36 +0100 From: Christoph Hellwig To: Huan Yang Cc: Andrew Morton , Uladzislau Rezki , Ryan Roberts , Zi Yan , Lorenzo Stoakes , "Mike Rapoport (IBM)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Christoph Hellwig , Bingbu Cao Subject: Re: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns Message-ID: <20250312061836.GA12841@lst.de> References: <20250312061513.1126496-1-link@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312061513.1126496-1-link@vivo.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: A9725A0009 X-Rspamd-Server: rspam08 X-Stat-Signature: e5u4611ofbpfkw6z35sufoxkya58p6rp X-HE-Tag: 1741760322-937852 X-HE-Meta: U2FsdGVkX18wuPttJciN7ewqGEcwdXlNiAKjNf2/zMdgmdCGTbmJeVGDo9sJtl7v2khBmfQrVKSgmVK4udg+AcIU6X4NIGA+iWOPMpvAkgPjT0+y2OiwT4ccvyExvrYNJiKORTCdjaGkafaGcapmkveAkqYhEmwdri7VV6MCJUBLqdpet2KFBrifILSDkz89ejj6Q24TOdWtKiZkSX5ZJZ1o07AVth6nnBJESARBHZBlfFEhchzMlV7lMMZx0+nUPFDAm9vXwU79HKzWaGbvFxlxCMIiSIfdbn6m7ADQnV4UwugcIJRJ87HnJ/Cw93iXdyXxt7o156FYRH/yjpluZ9ChPkXnX+bpfP48qH7hDfi2TFUmaqWcI3fVhvMwXZC0HLNN6ziHO3Z80sVi+WqRR1PtdGQofsTswysu0FLpnHY6d6MPiRnEsBVEDU/MVomPbkl5HYwGNoZkByVupRd/VWW0htR2zr12SW2Z6FhlMcaTVNQYgenEfXfLFaPk5aQeSu83kuBjbIBogrGaNymdVKjtRG6fnlQhL5bwux/YgpzS2yJ8qKtolyFO42ekva5MK/9ElJrr1u6UTIbksWHAjfnKWEiG4yndNNrWmbnHgxHiCAiqiChqVJSlvFEcLmtlZg2TOebJArDmn25ettVT74ab1RBQxcqZC7hcMCq+FNywAcLs310ueUgtSzjW3ywwBFxqLMakDhyBICBFWTA9OKjl4qLb3dNZ5qNgDbejO0NkHn1RARxiWmbbPVZsacyKwei6uHbDx2On9ucBXDMmGA3yRIgxyLybj1xqBF6PHhVT5L+5Yr7qggeGj0R6fQV3EuHPYuS0s3nCn73Og3P3IYt0VnyUvrr3T4uXl1WvTzdqjgvd/mEQNWQMbnf3flAZXjTfVP3vzKbc633TAndAKMJCGZfUoC3wE63uV74VkQejmwE4EJjjP6PhMu+KFUH3ETbbwdH7VoCoUuei1OZ oU2LmbWs 3NsfUvmkLYQJ8pX0ST1z5+IP+/JeHozIepv5Uky79NQTktGq1z89MJH3+LxM7XIo0Ao5kdpYAvN6a6hqnTg4FO2lYkhRvNcnD28bEVWnqIWyOA/Bf5XMs4WzaxvFz288hCRvhiu5OCL5G7HShGv4ftq2oF/iM6WTp97xj5Khfy+w0aCJqibiDxrXgP2xbRqQ5/K2JXEEMDRHKfyRiwj4UGE0m1k6+C/aPp06y6Iy7DBrzYsXwNvwJaHBgWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 02:15:12PM +0800, Huan Yang wrote: > When invoke vmap_pfns, it call vmap_pfn_apply to set pfn into pte. > It check pfn is valid, if true then warn and return. > > This is a mischeck, actually we need set a valid pfn into pte, not an > invalid pfn. As just discussed this is wrong. vmap_pfn is for mapping non-page PFNs and the check is what enforces that. What is the point of having that detailed discussion if you just send the broken patch anyway with a commit log not even acknowledging the facts?