linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Huan Yang <link@vivo.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Zi Yan <ziy@nvidia.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com, Christoph Hellwig <hch@lst.de>,
	Huan Yang <link@vivo.com>,
	Bingbu Cao <bingbu.cao@linux.intel.com>
Subject: [PATCH] mm/vmalloc: fix mischeck pfn valid in vmap_pfns
Date: Wed, 12 Mar 2025 14:15:12 +0800	[thread overview]
Message-ID: <20250312061513.1126496-1-link@vivo.com> (raw)

When invoke vmap_pfns, it call vmap_pfn_apply to set pfn into pte.
It check pfn is valid, if true then warn and return.

This is a mischeck, actually we need set a valid pfn into pte, not an
invalid pfn.

This patch fix it.

Signed-off-by: Huan Yang <link@vivo.com>
Reported-by: Bingbu Cao <bingbu.cao@linux.intel.com>
Closes: https://lore.kernel.org/dri-devel/eb7e0137-3508-4287-98c4-816c5fd98e10@vivo.com/T/#mbda4f64a3532b32e061f4e8763bc8e307bea3ca8
Fixes: b3f78e749865 ("mm: vmalloc must set pte via arch code")

---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 044af7088359..ebadb8ceeba7 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3488,7 +3488,7 @@ static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private)
 	unsigned long pfn = data->pfns[data->idx];
 	pte_t ptent;
 
-	if (WARN_ON_ONCE(pfn_valid(pfn)))
+	if (WARN_ON_ONCE(!pfn_valid(pfn)))
 		return -EINVAL;
 
 	ptent = pte_mkspecial(pfn_pte(pfn, data->prot));
-- 
2.39.0



             reply	other threads:[~2025-03-12  6:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  6:15 Huan Yang [this message]
2025-03-12  6:18 ` Christoph Hellwig
2025-03-17  2:12   ` Huan Yang
2025-03-17  5:29     ` Bingbu Cao
2025-03-17  5:53       ` Christoph Hellwig
2025-03-17  7:42         ` Huan Yang
2025-03-18  6:48           ` Christoph Hellwig
2025-03-18  8:20             ` Huan Yang
2025-03-18  8:33               ` Christoph Hellwig
2025-03-18  8:39                 ` Huan Yang
2025-03-18  8:44                   ` Christoph Hellwig
2025-03-18  8:50                     ` Huan Yang
     [not found]                     ` <20250319050359.3484-1-hdanton@sina.com>
2025-03-19  8:08                       ` Christoph Hellwig
     [not found]                       ` <20250319112651.3502-1-hdanton@sina.com>
2025-03-24  2:13                         ` Huan Yang
2025-03-25  6:32                           ` Kasireddy, Vivek
2025-03-25  6:46                             ` Bingbu Cao
2025-03-27 13:40                           ` Matthew Wilcox
2025-03-28  6:13                             ` Huan Yang
2025-03-19  9:09                     ` Gao Xiang
2025-03-20  5:31                       ` Christoph Hellwig
2025-03-24  2:22                         ` Huan Yang
2025-03-24  2:57                 ` Matthew Wilcox
2025-03-17  6:26       ` Huan Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312061513.1126496-1-link@vivo.com \
    --to=link@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=bingbu.cao@linux.intel.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=opensource.kernel@vivo.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=urezki@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox