From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68071C28B28 for ; Wed, 12 Mar 2025 06:57:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5C4280003; Wed, 12 Mar 2025 02:57:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65593280001; Wed, 12 Mar 2025 02:57:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51E6B280003; Wed, 12 Mar 2025 02:57:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 34A5D280001 for ; Wed, 12 Mar 2025 02:57:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 46C5AB780C for ; Wed, 12 Mar 2025 06:57:12 +0000 (UTC) X-FDA: 83211992304.10.7528F24 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E412C1A0007 for ; Wed, 12 Mar 2025 06:57:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cKupKixu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741762629; a=rsa-sha256; cv=none; b=rNDJh7tcYxcQAIUMGzruG1afvbkFVorVU9nhwgHXu1yEJ6oiP8NO/DI4JGMA6Ibl5/kbYS a/mEdc2hLx5XEd+HvlM8F9Uwju8dR+5+xG5qheg4KlfspoD6wh7hHK0okMXEbuiSNViYyk ijnFxAmVANYbztkbQJQaTQfELH6CuWw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cKupKixu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741762629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ngFN5P8pa+SiEt1Ew8FmKgFK9481luIZ3P3zqtJw6G4=; b=dAj+nSa3V1Ykarl4jrtGIvlEwKHoMOP6ZRrfvbBItCx0nhQOb6Et+Vb2J+ZlXR41mQcHPc DTXgiH0l5L/E0/BRFnKEcNaYeyVrDLyGgI/bieXM9q+CpQf664CzV9QnDzwxQJF4X/Onwk BkoUmeyBnuaG9bQfB0g2qKQtxRip5/w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741762628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ngFN5P8pa+SiEt1Ew8FmKgFK9481luIZ3P3zqtJw6G4=; b=cKupKixu0pgM283QzKnMquaa5FimMxsNLQ0DlUX9AqzxUd1Z+BhHVgqvK/sofj9531xrkC odUR3qPy75F2jveM/MbWPSFK9hIfAoHvKdnqw7LJknX6T6bG2CUJFrtMf1Xlo7zWTn1st/ 024yWaJuEejvHTD6nKyezq7NMmxUYCI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-fB2HQs5zP2q-jQB-_MTsxg-1; Wed, 12 Mar 2025 02:57:06 -0400 X-MC-Unique: fB2HQs5zP2q-jQB-_MTsxg-1 X-Mimecast-MFC-AGG-ID: fB2HQs5zP2q-jQB-_MTsxg_1741762625 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ce245c5acso31975235e9.2 for ; Tue, 11 Mar 2025 23:57:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741762625; x=1742367425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ngFN5P8pa+SiEt1Ew8FmKgFK9481luIZ3P3zqtJw6G4=; b=H1Zmrl2dKyfoq9Jy4kyY7SjflIo05gR2qnx/mdm70O/ha4lIaO+fCbPv+aLv2rTaMz e5RLn9qSDomKpLo86t9regN6ttOvcZ0a8jPzNVee1PwmFKMjJ1DxhUlovAYIpE6btgS0 XtrtLj4GUbgE5ltnpNnGnWRksNa2JaP0VbJnMRuxuvaSFTEBlWsbhLcGuq76B6hR3FYJ UhIdUpAhJdU11IkElnu6NPpGM6m3p6QNzr0Ojeumady62tbHBoYxgvnJcfF+cwEMgdUq L9lGkfPkYmbhqVIiZshzgOMuWTP8kJqt/c5gvV3vi8n733LpjeBdKiGqI9fMHOApBXM/ vlLg== X-Forwarded-Encrypted: i=1; AJvYcCWvvFfqePpfpN2V9Ez/RWdp5HR6zdEGjoM/1BFy+WOoWFd3eiLf2wH2DjbZbFo3w/fqSyZMtB7XUw==@kvack.org X-Gm-Message-State: AOJu0Yx7Agc8d9HGDUvHNpUP2yNgH1mwkPp+JFxlWPM2Rhycqvn3juDD LC/gfPdH35THN84/5pSZoTcPaaQiG/VGQ26dypwdvu9w+pTPGh79zL6cnfQHoCmFR6wctJtYWrW c44xdXy6Sv4cOiSAIIpCAd4lwkl/xyVXTZcTjQuEE4zonr0Zj X-Gm-Gg: ASbGncuejQ5j2yRwctlP50kQdhh1vPGWCFqxPl4D47M7BUE/SBycLfU8L4ielGay8wq KHotnQYtGGdDfP5+gFBG1oUu2qPhU6pcmufEYQ/CZamXDeu/tCiqSqMTaQ0e3WsUb65LIaIx2XB YV7uomyiOGnu/LwIjtIcQGeLwGg++NTfILb0pbMtypbnqH5gJ4Z9+SlVYMjIBuWp1s4E66907wp +q/ylmPw2Bdu9UqCLkInOh8iYDLVtBpNAjszxN/X2SBLjam4NlXnz4vrDoamUHva8TBqNDLpTaq UF5w5rsJUg== X-Received: by 2002:a05:600c:5618:b0:43b:ce3c:19d0 with SMTP id 5b1f17b1804b1-43cdfb7db88mr143183515e9.29.1741762625108; Tue, 11 Mar 2025 23:57:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXQUbnjKhdX7cSTwHc/sH5KUBC9yqYpY1/TKqBEmz2tDiKoCFs3roMwKysiE2/kbKi5UsENQ== X-Received: by 2002:a05:600c:5618:b0:43b:ce3c:19d0 with SMTP id 5b1f17b1804b1-43cdfb7db88mr143183025e9.29.1741762624636; Tue, 11 Mar 2025 23:57:04 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d0a731031sm11806955e9.7.2025.03.11.23.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 23:57:03 -0700 (PDT) Date: Wed, 12 Mar 2025 02:56:59 -0400 From: "Michael S. Tsirkin" To: Nico Pache Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com Subject: Re: [RFC 4/5] vmx_balloon: update the NR_BALLOON_PAGES state Message-ID: <20250312025607-mutt-send-email-mst@kernel.org> References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-5-npache@redhat.com> MIME-Version: 1.0 In-Reply-To: <20250312000700.184573-5-npache@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qz4zCdzw0___SWLFFVIw7s_uHY-iLKJHi_RZoozTcvw_1741762625 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: pqpppdsjzj9cjjhndjyn731tjkfr1yj8 X-Rspamd-Queue-Id: E412C1A0007 X-HE-Tag: 1741762628-533544 X-HE-Meta: U2FsdGVkX19QVguS15HmJ+KmqMIzB5j6G+/iuLEEpp4NWrZpmWjG1GYFwLfs0helVMAzKO219LJEFyvTRupB0Ymi4T+BrwTR6DYWbMTSUM+Jbg1erdpabiOudYeCJTZNkskAsRWrKAfEwFESCtbEnrebew9qrmzRbGwflAz0qJtwvo7jhKSh9tOn2XPQm1LyIG0XPR6pr4DaK9oLERTx6JGstFiypRrPNtaat9ENCvdG0y3PVjSFKtO+X/g99O9plFDMwfruAOFic9xEMxBSV8kSQOdmKCXkSWGCsxfHNw5eIGNit+p1uAD3CA1NbccKVcMpflJ+aLFgIkSN29EwoCFHvm6SYWbSm5/sAPUTD0DhgrCKsWxzOOlcTQeOqScQ/YZkVboV6FTtS3wsxVW6kuuuswxP/5X1ITi/RVotAU/Oq6jC4Oz4HSe2eomVGL+j39Ml1fOUQ35CasPRsz7BEp13Lh2j0dEt0qQ7fjlNloHzTR03R7QRPtVVeW7exgnjonyLAYzAaop/x9ddZ9D6841uiFV/EFQDfgxMLci5g24bcZCw70jzP6h+Kz9f5M+LzmWNWhATEry6VXp3PMD7AK/21wCz4TxXThG7BPo/4iyJ94KrQrLi6BVSUjZlgNKdMMRmEflz00CW/nQYEWDEuG+2DhjcankgIiWFvblk5TaVpIEuGR4njpHHWoj0kKX5aFSZdRj8EpMlrJDcfz6P7NqgbBH8JO5mIyqOfcMDdCxp8JPh4ri1Acd98SIwoEZkzP53fGyLKpjPls83TAV45qmBO7hKj5p1dPByjKsBRUUnzBNMxPw5KCvBVEMOCDvxcdhbvKstD+IuPt7XoqsBHm9taEW4l7YtxVgIm5Jes9Nd/sCWmi3NrcvQMn+ZjEFeMB2kjlz6KI9S8Eie1+sWzSWQhQIbSflihoyU+q0SoGqTJmAUjc8VWAjxcpg/qnvUBugD8hEuvkWH12v/kmz yMhqNCgU VsX7LUK62Ppyr5umO1lMl5oQQjXS2JuJ7Wi1BqOMSnVJT8+B4X2eaT3od/Bnw6kFPFOKFekRLN0zCRTaMebchlO5DpX7gdCQPZeeEBH2hAICrdKMyZtEV3zwKTEcG0KJ1npt6K3/WnXKarnx12o9DfzF+Zhu/Jq5tpLb3yLJ8M8D0R/7T7J4SxwlWoKgCZLgyr9GlcoPGhgUXnRl5+7HsJ+wDEh00BnqeRW8fcgcVtLtxUMrOnWWpvmBObe8FgMrSVQDfZ4rzzEDbHMLEym/1tVemIubMWWehfFrZ5b+bBpRnqKprmunt4EydHLmFREhU+oS9RPmXFXjanj4+HjaAr8c30RiNOw2S0sORZkii/Fbuw/KPu5QaHuz9es4BWuzphF4x5IEu8KFYEs4pcD2WmmqraE9rYi4bfwGIvjYhU2+1T6w7tIlNOhMaYKht2pvvZMc9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 06:06:59PM -0600, Nico Pache wrote: > Update the NR_BALLOON_PAGES counter when pages are added to or > removed from the VMware balloon. > > Signed-off-by: Nico Pache > --- > drivers/misc/vmw_balloon.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index c817d8c21641..2c70b08c6fb3 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -673,6 +673,8 @@ static int vmballoon_alloc_page_list(struct vmballoon *b, > > vmballoon_stats_page_inc(b, VMW_BALLOON_PAGE_STAT_ALLOC, > ctl->page_size); > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > + vmballoon_page_in_frames(ctl->page_size)); same issue as virtio I think - this counts frames not pages. > } > > if (page) { > @@ -915,6 +917,8 @@ static void vmballoon_release_page_list(struct list_head *page_list, > list_for_each_entry_safe(page, tmp, page_list, lru) { > list_del(&page->lru); > __free_pages(page, vmballoon_page_order(page_size)); > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > + -vmballoon_page_in_frames(page_size)); > } > > if (n_pages) > @@ -1129,7 +1133,6 @@ static void vmballoon_inflate(struct vmballoon *b) > > /* Update the balloon size */ > atomic64_add(ctl.n_pages * page_in_frames, &b->size); > - unrelated change > vmballoon_enqueue_page_list(b, &ctl.pages, &ctl.n_pages, > ctl.page_size); > > -- > 2.48.1