From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8218FC28B2E for ; Wed, 12 Mar 2025 06:56:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B78E280002; Wed, 12 Mar 2025 02:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56776280001; Wed, 12 Mar 2025 02:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40812280002; Wed, 12 Mar 2025 02:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2300B280001 for ; Wed, 12 Mar 2025 02:56:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DEF72B594E for ; Wed, 12 Mar 2025 06:56:00 +0000 (UTC) X-FDA: 83211989280.05.EB6EEF7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 7FDB420006 for ; Wed, 12 Mar 2025 06:55:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XFG/tEGR"; spf=pass (imf13.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741762558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M5urNoJLNtNizXgsJBqJ+K7FyEmcih4A00lRbzK+XcU=; b=ixzBrG5dM7B3cxkvaNksKhCIl2xIQLIGWOk45nJlfjjccw6zN0Xz4eNP8RXMN6ahzActMd J2mqhXuCpT9rxcoL+PsH4CvIt6SDB9/4I2HJRDw7ewtg2GDyihmRcoKZ26gnHInuywSA9/ h+1z4HsJu+V3e0vB91sr3VY49keVr2A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XFG/tEGR"; spf=pass (imf13.hostedemail.com: domain of mst@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741762558; a=rsa-sha256; cv=none; b=M0uNJaNWbvoRzfOeHOGanYU7wRsjwKChmtCQbcy8N1ZiLBLkYwuJOm+gKd/zO7Na+zgE1c wBuI6XsiHq0SdafnM21evMDjAt0iZezbXeSsO/+ollGsVAjPcBG3wKGOaTgcLdKPJSppO3 vRLZ1Zd6GATSKGwbZKrWETHkvw0Pqzw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741762556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M5urNoJLNtNizXgsJBqJ+K7FyEmcih4A00lRbzK+XcU=; b=XFG/tEGRGpxP5VwnKrQ6M6cP7pt0CpEdnPeI/f7zKLVyjOHR5CIR0KXpyVcdM1N0UxvUNx dZ96YvZ/Gxl6v8Ge1gBFw/AEnRTuFakuUNnjDj+cAUN4xm611kkcdf1uL1k2ZDda8dZ9WN Wmm7O358DKvpalSbON6ut34W3lwUIf4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-lzp4FhuUPm-YAef-bbRTXw-1; Wed, 12 Mar 2025 02:55:52 -0400 X-MC-Unique: lzp4FhuUPm-YAef-bbRTXw-1 X-Mimecast-MFC-AGG-ID: lzp4FhuUPm-YAef-bbRTXw_1741762551 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3914bc0cc4aso1662569f8f.3 for ; Tue, 11 Mar 2025 23:55:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741762551; x=1742367351; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M5urNoJLNtNizXgsJBqJ+K7FyEmcih4A00lRbzK+XcU=; b=bZQzKdfA2nyDMWqpuVRnTSuRY2l7SrVk1Md6w0kqU10S5n5Sx4h83D7XTTTCDfe0S7 upNDtgObzRW060D/GH6ocRfUS+I3g1AMs/gEZNcp1DIu6DOMNErwdoyQgK6QfPnwnuS5 3gleU2YrbOAHRuhsVcs7xF1NTFeVorfy+e/QRa5B9XEcX7x0aAfiMY8YYa220NijtVdt hi59o2dqLl5+PQvXbDB8dgYqQhAPOCazaRqC1smAcOvmn+LRbiczZrM0s0sP/i30fc3W lC9zOTioCJUVumaTurTlImjR9A3ujcUnfYcHyCrl80uThlLk94SlCDAlazxcUZUKxFzV akZA== X-Forwarded-Encrypted: i=1; AJvYcCUtkg6tnr2Mw3oq7tUlDouOZaGxQo8BPQVesJsmGncxZ8BWALctJD8pQ69bz9wcfWiw6mqqJXwkxg==@kvack.org X-Gm-Message-State: AOJu0Yx1I1fl1uxefGqWDIL8LbI/JB3ory4PHn0RSJATAgicn5N4GkfQ UsT2yG2tV7TCH5Tpvlkd2QXUh8hk1E4Ke3QhFW+nvvNs8Ztk0g2USnsrKXe+o3rdOWcCs6DMTHJ nBDT2IRvqyL+IJyStx3gmuC5k+Zba5sMLd08Qn/8E92ET+v0I X-Gm-Gg: ASbGncstlMsrtqs63NmtLw7XPZkMbmShcn9aAgOK4cA8nmmUse56vj3xvtcEqw6PJoD xG9nPPA+cZfpXyyLiaOLyJwN3aO/Rjc4rJlqbOMK3TO2BqpidWNpdFPuWIv0WM/4GNH+DXcNbUa dAEwlN93iOZWSBFv/YkVcCu4KRa1c+ZBkqxX+w4sSK5XsCzKOW2K8hAxT80BrMc9s5i7ZopQ9S8 ssbEiMs3B8fexy+a1UMKij1J3+Wc8Wrwo32V2lSO3+zA+rY/x971XcDTHFccg7r3UfiPlWNtTMO Ft+BEiTpMg== X-Received: by 2002:a05:6000:402a:b0:390:ed05:aa26 with SMTP id ffacd0b85a97d-39132d30c22mr15005794f8f.5.1741762551533; Tue, 11 Mar 2025 23:55:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDerobH2f/muGrjnyAjilHqba0+0kowFg3s8AIPcyJb001SG0K4ObuoiA+X/VxHvC5d0rDfQ== X-Received: by 2002:a05:6000:402a:b0:390:ed05:aa26 with SMTP id ffacd0b85a97d-39132d30c22mr15005774f8f.5.1741762551189; Tue, 11 Mar 2025 23:55:51 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-394a8a5a304sm565705f8f.40.2025.03.11.23.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 23:55:50 -0700 (PDT) Date: Wed, 12 Mar 2025 02:55:45 -0400 From: "Michael S. Tsirkin" To: Nico Pache Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com Subject: Re: [RFC 2/5] virtio_balloon: update the NR_BALLOON_PAGES state Message-ID: <20250312025331-mutt-send-email-mst@kernel.org> References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-3-npache@redhat.com> MIME-Version: 1.0 In-Reply-To: <20250312000700.184573-3-npache@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lMWggIst6AdWlkS89tcuQlFXMP09K-xstWJM3oN7zUc_1741762551 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 7FDB420006 X-Rspamd-Server: rspam08 X-Stat-Signature: 38nz67c13nwwoj5toseohwg6zsyt6gcw X-HE-Tag: 1741762558-184317 X-HE-Meta: U2FsdGVkX1/BQkFg5senTkQU67di+JazkWvc6jta3b9YO88XpSvOPwbV2uDolcKPpYmoztzPFmHzrYalygz5cgVpZnSBTEmINBI3PAD0YMSybfZ8ip1zxguRcK4D07uPDFHZH3tL4EWc3B4WYxsSccE+7+bF12mI5djxMADdskY9LRlai5z5thhA3e4EjP5r7dU0kuqYJZObjnScAwF8I0Xb/XnzRgMFLhACGWvYhMF+PECvautnj7jiRwUMjGMBwCkoJ8S0sud2ltibw9hog8sp2vMUlcvZpIIvcs2PdfHoYQMw+97WlZhcjMr8MpUmeMCiYG8Wf1lLmoYScOyqOhJIN6JxAF2rzXKbQEFuUrrqV4F+2PeJJPtNvZmBp/AaXbN/WP3epNOjPWGVMqGY47m7zhorqW9LJ8hY1HA9EPyAa+ut9MJdSKX/jNqsB0y27Iyj6QHvuYWPAjfHbalQ3F0FPhZnQ9CVnE7m2duYEBgGKqsHDG42nWLWBv/0GbkeEcYQ868l4cYm8PiEWRqCRm/xFSSTrJQ4xxQMCAwLGEnM3oayFL6mbKorieeZh+4+OoP7kS3gaspSKWPSnSZ3qmBpK4B4MbsogLgWV2VhHA5mWk658zrCCBTPaB9gWvNUmR3XrzE2H8m2hVzc2Adm3W8AGGMQGSDjpzg+IFfn3npz1L9BB2s8n+s06qqOe/dXwBcJk6rTxVgoiel27bOYQiTcbDI88iqhuR7f58eUkXwW65uIa51DhNs7JnSnttkvfes3c59oyrovgNpeHchdqryRHludhGD/Szr8J5wWcjV+YhEf+B95yzBsuPaE7plT99L1PXWc9J5eBNNPbKb5V923EyjjphQPu0q0X4yC8f2K7pGlTpw2knKWyNlB8Ge+d6ZUgooh7bGnwZtSLxuPJYhnueW1IZFixEeDKeR+53fZVdBu2pr4mihlDMPge6yH1TSjKjZw7Qe0ZcH9x3D F8nEauC+ SVDA96R0zKePzd07kzESj+XAgZkpSNsR8c7WOkxJEAiE3Q9e4OqSNKbum4K7ajy8vHYjk0RXfqq8ZBqMyUDZmnqwMJ9oTnZN1szXff4614rCxEmVxnAH7mA/rIfvkz85bvN1otq1F+oMAwwFms20saoJI/O7NCARqTG/0laZuPV40S8tRdY8siHYHLspR4ospVx1bNEmOCuGq3FA2trPJa/KXDUBIf3IE19gAWQk8rHDP+ZDIQqnSzJWQm6dYCzoUitrJ6fFitkBWUQwC7hEUQFW8V18GFRC7Adob9InjowqsU0pGsFR7ug6fmj4f79zFA6b5fOLwXC+sGTY/tq0+ctFqdn7FkWBLmUk5ZkdAj/3Cxn/GP0gLIQ+zsQwvTVfabuF3Y/XO2gBG2/sPwlIuvCMoJC979nxCBOmmRowy1mXvtp2jtUJYLal+b9QTkVVjnocw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 06:06:57PM -0600, Nico Pache wrote: > Update the NR_BALLOON_PAGES counter when pages are added to or > removed from the virtio balloon. > > Signed-off-by: Nico Pache > --- > drivers/virtio/virtio_balloon.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 89da052f4f68..406414dbb477 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -274,6 +274,8 @@ static unsigned int fill_balloon(struct virtio_balloon *vb, size_t num) > > set_page_pfns(vb, vb->pfns + vb->num_pfns, page); > vb->num_pages += VIRTIO_BALLOON_PAGES_PER_PAGE; > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > + VIRTIO_BALLOON_PAGES_PER_PAGE); > if (!virtio_has_feature(vb->vdev, > VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) > adjust_managed_page_count(page, -1); This means the counter is in virtio balloon page units, which runs counter to the declared goal of making the interface hypervisor-agnostic. > @@ -324,6 +326,8 @@ static unsigned int leak_balloon(struct virtio_balloon *vb, size_t num) > set_page_pfns(vb, vb->pfns + vb->num_pfns, page); > list_add(&page->lru, &pages); > vb->num_pages -= VIRTIO_BALLOON_PAGES_PER_PAGE; > + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, > + -VIRTIO_BALLOON_PAGES_PER_PAGE); Same. Thanks, > } > > num_freed_pages = vb->num_pfns; > -- > 2.48.1