From: jeffxu@chromium.org
To: akpm@linux-foundation.org, vbabka@suse.cz,
lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com,
broonie@kernel.org, skhan@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
jorgelo@chromium.org, keescook@chromium.org,
pedro.falcato@gmail.com, rdunlap@infradead.org, jannh@google.com,
Jeff Xu <jeffxu@chromium.org>
Subject: [RFC PATCH v1 1/2] selftests/mm: mseal_test: avoid using no-op mprotect
Date: Wed, 12 Mar 2025 00:21:16 +0000 [thread overview]
Message-ID: <20250312002117.2556240-2-jeffxu@google.com> (raw)
In-Reply-To: <20250312002117.2556240-1-jeffxu@google.com>
From: Jeff Xu <jeffxu@chromium.org>
Modify mseal_tests to avoid using no-op mprotect.
The no-op mprotect shall be allowed.
Signed-off-by: Jeff Xu <jeffxu@chromium.org>
Fixes: 4a2dd02b0916 ("mm/mprotect: replace can_modify_mm with can_modify_vma")
---
tools/testing/selftests/mm/mseal_test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index ad17005521a8..0d4e5d8aeefb 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -677,7 +677,7 @@ static void test_seal_mprotect_two_vma(bool seal)
FAIL_TEST_IF_FALSE(!ret);
}
- ret = sys_mprotect(ptr, page_size * 2, PROT_READ | PROT_WRITE);
+ ret = sys_mprotect(ptr, page_size * 2, PROT_READ);
if (seal)
FAIL_TEST_IF_FALSE(ret < 0);
else
@@ -718,7 +718,7 @@ static void test_seal_mprotect_two_vma_with_split(bool seal)
FAIL_TEST_IF_FALSE(!ret);
/* the second page is sealed. */
- ret = sys_mprotect(ptr + page_size, page_size, PROT_READ | PROT_WRITE);
+ ret = sys_mprotect(ptr + page_size, page_size, PROT_READ);
if (seal)
FAIL_TEST_IF_FALSE(ret < 0);
else
@@ -873,7 +873,7 @@ static void test_seal_mprotect_split(bool seal)
FAIL_TEST_IF_FALSE(!ret);
- ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_READ);
+ ret = sys_mprotect(ptr + 2 * page_size, 2 * page_size, PROT_WRITE);
if (seal)
FAIL_TEST_IF_FALSE(ret < 0);
else
--
2.49.0.rc0.332.g42c0ae87b1-goog
next prev parent reply other threads:[~2025-03-12 0:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 0:21 [RFC PATCH v1 0/2] mseal: allow noop mprotect jeffxu
2025-03-12 0:21 ` jeffxu [this message]
2025-03-12 0:21 ` [RFC PATCH v1 2/2] " jeffxu
2025-03-12 13:49 ` Lorenzo Stoakes
2025-03-12 15:27 ` Kees Cook
2025-03-12 15:48 ` Pedro Falcato
2025-03-12 15:50 ` Lorenzo Stoakes
2025-03-12 16:45 ` Kees Cook
2025-03-12 23:29 ` Jeff Xu
2025-03-13 5:29 ` Lorenzo Stoakes
2025-03-13 22:50 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312002117.2556240-2-jeffxu@google.com \
--to=jeffxu@chromium.org \
--cc=Liam.Howlett@Oracle.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jannh@google.com \
--cc=jorgelo@chromium.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pedro.falcato@gmail.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox