From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C340AC282EC for ; Tue, 11 Mar 2025 21:03:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F147280005; Tue, 11 Mar 2025 17:03:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69FFE280001; Tue, 11 Mar 2025 17:03:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5900E280005; Tue, 11 Mar 2025 17:03:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3ACF8280001 for ; Tue, 11 Mar 2025 17:03:30 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8F8CDC069D for ; Tue, 11 Mar 2025 21:03:31 +0000 (UTC) X-FDA: 83210496222.29.DEAE805 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id D97C080007 for ; Tue, 11 Mar 2025 21:03:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="VG9an/u6"; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741727009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WP4tR5pTuSEUN+X9e05K8YSSdgrflw3inlpj1fh5KIU=; b=hWMJcrBEgygHhRWmDge5/C+BozclHyuA42C0JIrNl7ctAxWtkQER/edCIaDIqb8OE52RZQ xuTsIDDIt3JJnyMmvEokkQ+H+pXDjpEGH5L/0LBK4j4LAcxpcvbuHoDL+iSL14yGwOnHdV vB4xokyNjqme6vZoPaQ/uD3Y38NbkaI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="VG9an/u6"; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741727009; a=rsa-sha256; cv=none; b=nRsZLHDgWfdJ6PdUcTO79PV7FVlpQdYnGDnJ2zfaSPw6rGJ7eZl+6t4tA4vVfyURQ2cj1Y DNNquKZqXjiNXQkE5nxFfrSdKGguETEQxghtHj2WWJsJsKT3tbJjh5225MroY1xVxs1Jgf sE3ypLuzjZOtbqeEtYfFfxmDwhOr1H0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3E9DA5C5B87; Tue, 11 Mar 2025 21:01:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AC0CC4CEE9; Tue, 11 Mar 2025 21:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741727008; bh=s9tR6nZeVVojY6KvUwD1l+egtg49JohWo9DDH5W6I2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VG9an/u6VOWdNVuBbI8PXIYU60rcz47713Xas41H21yYPzyLBVmegAaQyN99aRFGv tdDHR03l6gtg5xax/NYkSxu3/W3Ri8ZjeR9eXREpYBRurQ3GZ0zJcys7Yy6mG2cLSv ma7amIPz4d8KuxbyTgl9Uq8W3uNxirHGq7ilqpD3AVM3sOyYJMLwpVL2jiO9yxhL1r HqqVJsR4cFzhpjE/fAqVxn7VKHWBiUHABVOr2dLcDWvxfCqd80rCvf0ldranITSwHQ qOA9Uu78CYQWJSaT36ssAwAdxBLvyU/k4AhG6gXigFncvASgy/QP42MJgL1WHL4VpZ iiQsRTNzCtjyQ== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/9] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE Date: Tue, 11 Mar 2025 14:03:26 -0700 Message-Id: <20250311210326.85632-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <0f90d56e-5960-4478-803e-1054696c0cde@lucifer.local> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: D97C080007 X-Rspamd-Server: rspam03 X-Stat-Signature: qh3snxahdq4au1jo3pcha87dgoobnha4 X-HE-Tag: 1741727009-170460 X-HE-Meta: U2FsdGVkX18q8t8JM9Lcw88dViPgsRzv7mADL8dYSg1HgDkxTO8HXJ9kAhHRLKB5lhCQ+NkWyLn9NiupIeftg3hO2FFYM47/fS2df+K/2egvE6UIFrgQb+eUhxxdQLe0FZEkhsUQTEuhwkALs9yl+vYKQ6jAOsUIvBFul6d3P2WKALps17nTKc4Kykp9TFeEi6Tz1tkrx1oad4rkUFr5q+1Ujf5nKR/vFp7+OAxUCjZk1BVv2qTqUc54w+XBAizbLF4clxyCt4CZcBmgsufTA281A31nXSWdOMBdovEs9V+13q/JEsDOHfBUpEW6UXxmIUZWE8XyNpBrYQbKH87PIU877nkeRTD4WtPSDIdkhyVgGGkOoxgRQ5cdq9l8Z5JJjnPph9f9ko29tDHkkS8w1SWqPSlrlA6hz6xFeOJKvUT0amebN/TknUEoAfiP0KZErXAfFB3S41wfqBufKtdXo32jja/zwrZG8rFJndkfw3jkyhqtvioIlWe4olHa3+DZ6zSMEbewor6QQ1AaCMzboR4Y3fqI+H9rPKq/1GVErxna9qTD2+FyWvrJs0LBYVWo2alLUKA0KRGAHZQ92p3H1tIhNVK0DOzmrwG6nn/EQf7FVKGuf+826usDTMWZ/a0WekI15TiNgDeiy6nZVoQLOOwnYKdaa6JQGeAUzb1f6l3e8/vwVdpPjwTZ3CPHqgitQHaTPwR3UJ8La8xFGSF3V85Apb2tdBOYQgP3I5lSR3xSEpOs8XI6hPari4QT7tLISJkBS17tYqFA6QFSNZPAnryBz1lIPV+tBlWQo5jaHjJ5kwmwjQnf92qp00raaftXMcABd6ADjDXtbDctvn4xCJYt27Wfsox1WMQlz3FzoWjLPOxBfUeJzDsSDxno0NhwQ0zKHj7g7T87JynIj5NcO+/tq5LZ2iaQlgWEhYijG/u3vHBFUTBcos3JRNFdxmfMhSDxMcXLngcsUVROq9g ucUwmKc3 PJMM9nZYq7v6npxqfTZKxC4THkww3LH/YSbq/RrW4IKHSUk+It78eAEBSqTDHxbfNtHuRVbBbpA6lGNkFmgZRYPw35UIA8EqyuJ5ihqDIwv6D33lKVQv+kX3YZ2KtbZHWXi9arfaW7226IHc41zKtqNMm5WTVLIrT1rZI8DZNM+9D+yxfr1/Hbp3C+R4U9TbQgUYOCZ/0FTti6WLQFoiraA3MKX2sna/1NV9F2lv3fn6E3xg0uA1op+7mAM9BQ8il5FSnHOH2NqQQjxc/RhR9g4ecaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Mar 2025 12:49:38 +0000 Lorenzo Stoakes wrote: > The below commit message talks about tlb bits, but you spend a lot of this > series refactoring mm/madvise.c. > > Can we just separate out the two into separate series please? > > I am doing the same kind of thing with mremap() at the moment, but sent the > refactor _first_ before the work that builds upon it :) > > Your refactoring is great, so I want to be able to take that (and Andrew's > objections obviously don't apply there), and then we can address tlb stuff > separately and in a more focused way. Thank you for the nice suggestion and I agree. I will separate those in the next spin. Thanks, SJ [...]