From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC96C282EC for ; Tue, 11 Mar 2025 21:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3AAA280004; Tue, 11 Mar 2025 17:02:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9B0280001; Tue, 11 Mar 2025 17:02:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB378280004; Tue, 11 Mar 2025 17:02:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5D54280001 for ; Tue, 11 Mar 2025 17:02:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10577C06A3 for ; Tue, 11 Mar 2025 21:02:17 +0000 (UTC) X-FDA: 83210493114.11.D5D70DB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id 63BBDA001A for ; Tue, 11 Mar 2025 21:02:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lpvoTqWR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741726935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J9ZBd9Mydg4o7CF59VSSdSH0gX+kV8EW9pPZ63+jcok=; b=Q5CbCmh1Ld6ElCnWQl6HC0/mJIkSoGlN67Uw7GCA1EDNu2qx4mVq5PpyQSKbvdkJxyQQeJ hnGy60yZ9eVnmW5vXdSPd/QXU+z+Bx3OaPqVGvsiB3T3zsFMV4wIuzJLgqUxas5s8PYzoW a6NTULnBXs4Yf/QzMJDBL8ttbNQ7lfI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741726935; a=rsa-sha256; cv=none; b=tG2olGmuKlbwUJ3//vC+wtG6dXsjPLCBXwj2RnzEzgnXqPczPnTSD8iWRQi6U4vrVXShSK RB4codOjSuq9+B5A7JXiFLEnTAqSRv8k9IqN/c9o9OwIH7f3KdekEjvJLB/20iBdcpUh4/ pJIR8VDNnYpowZ0BiPLZ2GK99HjRRB0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lpvoTqWR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B955BA45CF3; Tue, 11 Mar 2025 20:56:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 433F6C4CEE9; Tue, 11 Mar 2025 21:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741726934; bh=bqNgkQjOZTpB7bd8OVx7GHW4g2rvXGrtTW5DxlB6vS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lpvoTqWRVQEy0nY1+hZjcU5w99s4/5imhn/5d59d3+ftN2SvFCwZZTZFnt4iR/mzj tGP0sr0rSvnytBWCaXEAmBJKF/N9IpqVVFoR6Anal7g3iE1AfQ2z5wCOrCcz8bY/qp PJBv2vlFQxLWLeoSV51uFVdAo0syB9gMd8VGZEgyfbyx3Cc8Etx1Se5DEhiiBZ1+jY rYFJ6S4ocW8u6G4v+NHvVsVUS1qOj/r2G46mptWBENYDQz93vu7YMELDQ7a7Q61SQW JMdCM77hzDWvWphfhnDQUVvGrIO4c/ve9hgv9px8g1w3gq40NVarKAgU6jtV0mwmGo NVmglbTLZFqHg== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 9/9] mm/madvise: remove !tlb support from madvise_{dontneed,free}_single_vma() Date: Tue, 11 Mar 2025 14:02:11 -0700 Message-Id: <20250311210211.85566-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <246b547e-d7ad-44c7-9652-6f5a72828b26@lucifer.local> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 63BBDA001A X-Stat-Signature: 6t61j6wt9mz4f1c6tg7ejfdydgse6wod X-HE-Tag: 1741726935-480805 X-HE-Meta: U2FsdGVkX19NjAvSzQ4fRsKP7xVLp66/5IpzH6H+rql62mSjyDqnkQrwdYpIWJ2iG5MzB34ProDf8/nzwfMf/sloSJXbsDji8tlfH7EkGsqUF6YyEe/3aX7RpQ+AQ+6zJSaNWFrl/CAPGViVvq9He5GUCKckiQ5s8d1jYw4FPYcXJan/paJG6tjAQd7IMj+kiWRCqZloPtjjqGNSJoxQNX0amscXkRn5HjTfubX4GbtfE9bXy0kVQmgJlnIvxzh3j247HXDU6Pjio0dJKTFwME0oipRvb1dW/p5Ve7yyRSOxeZHG2LAjUSi1TbVJY2AVe1GV699eslJLSGktHrsMRWE0qjgb6s4IXIrWw+EtPv4kmdHgQpNpKUUEgu9HGXVlJM9p9rgMsM1T8EcfzCXoZK3/jNd69lsyC9LJu0F9pQ3V82uaMq/aTDfcDdD4TkApPxJ93KM+Rth93Y0qDipyzhVNLdtU89jCWjjOsZjCUCvtO7ur0nPJo03a/S9YluIvXXcpWlf/pCcpT2v45Ne5EUaMEXJnFTCc5x5wGTPmMa9QyNryf5xLfWm7cRjrEI/y/wr+E9ahdWovWhDc9XJE5gFbeA1eGT4uf/OxlhqDwiSkP2kx3SdP5HuyaOimDLfaEEi667qjYmcrbYG6RV/hexbQuVn8c97jRRXxz/18n8iGlRDJoCaOPFcC5vnxT0Ixis3ygcXLOI7iOu2Qo+s79Vo67mxScNsH9xT9zPIk7uXQedUFE7dM0xlSDfg/YBwqZg1e4BYzDcUbIUpupkvUjkbosSTzbYkZIwnsxBW3/dAT2QYlpvhfKmrXgRe/fCU1gpejYtPMRrXGlbh5tu4T9/jjEyFN9primcKY1sa+9zFOqPaPrN34VesDsau6Jx9KotMgS3R9LAA4Ok0z5CmIwOiqwo4Y83efzQLhVZqZ6rh9tBz7cURyKucF7pupK7kH4teWhzawou9yYSFQFhP I3h65eb4 v9NMErgEtinPZhmiDoq708S2tsgjzrZ7g1blTiuNEr1RHoSkvkml7/Vi0SaPy/Lp1dycUUaN9gKoj27I6Ys0PRshSExT13mT5WJpKZTl5bw/kG8U5vzwOuhEDUFa0RBkSAAxOJYJ1Q5UMiNM3XuewAeYcIySuVOjFlcc1jvbAkejnhumk5B0f8ZytEOzL2gQMYmbHByXo/ychy+GZqAsT1C1YjBAiIixqLCBshTWRn1UIHRDccwPvQyMZLEu3kmncmRo59slXf1aywKvWqPl+3ErLHdbZZA1DGinqprB01ajv5Wg7CQ/Hr5K4+Zd48V5bqnxQsR9Ffo8Xnxj2SzJMmJIqQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000968, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Mar 2025 14:01:20 +0000 Lorenzo Stoakes wrote: > On Mon, Mar 10, 2025 at 10:23:18AM -0700, SeongJae Park wrote: > > madvise_dontneed_single_vma() and madvise_free_single_vma() support both > > batched tlb flushes and unbatched tlb flushes use cases depending on > > received tlb parameter's value. The supports were for safe and fine > > transition of the usages from the unbatched flushes to the batched ones. > > Now the transition is done, and therefore there is no real unbatched tlb > > flushes use case. Remove the code for supporting the no more being used > > cases. > > > > Signed-off-by: SeongJae Park > > Obviously I support this based on previous preview :) but I wonder if we > can avoid this horrid caller_tlb pattern in the first instance. I will try, though I have no good idea for that for now. Maybe we could simply squash patches 7-9. I'm bit concerned if it makes changes unnecessariy mixed and not small, but I have no strong opinion about it. Please feel free to let me know if you want that. > > FWIW: > > Reviewed-by: Lorenzo Stoakes Appreciate your reviews! Thanks, SJ [...]