From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6A1C282EC for ; Tue, 11 Mar 2025 12:59:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A36B280003; Tue, 11 Mar 2025 08:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45321280001; Tue, 11 Mar 2025 08:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31B2B280003; Tue, 11 Mar 2025 08:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1369B280001 for ; Tue, 11 Mar 2025 08:59:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0A950121E8C for ; Tue, 11 Mar 2025 12:59:27 +0000 (UTC) X-FDA: 83209276374.07.D9412F7 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 3B4ED18000D for ; Tue, 11 Mar 2025 12:59:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=3I4jb67p; dkim=pass header.d=linutronix.de header.s=2020e header.b=+kLjVgNe; spf=pass (imf16.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741697965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mqrVsWAlbMJNJgk2uSMgNDQZC0XfWOKSi6T6DcyzAp0=; b=A9su7BMFE31MdTeLak3xSDBqxd+KHbbUXuW2jv3OlaIrLIRjx/ARC4TOzM0xe27RW1s3U5 A0OgfB8zIVn4jEby684tQy6lrxSyEjnc4Ljn9L7q4BiIN+vRHOejslmvlTU78Unt9e6Mca sVaWyWYdcaEioDubpowBfDWxujmXSvE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=3I4jb67p; dkim=pass header.d=linutronix.de header.s=2020e header.b=+kLjVgNe; spf=pass (imf16.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741697965; a=rsa-sha256; cv=none; b=o8QhOPSTxKArBsn11o1GLXGXf3NNOIN7d0qJQgz4u8U9zDJSO3vSb6wGM48cEY6M6er5wq 5htUOPFzpKUDwzGmqbIpjepjyyi2bCwVuMi1VdNZcF4Lo1G1dQl6JSbv8+gCqcE/9fnZnQ k602PNbvf+pbGmWUIk5N52jjC3tSess= Date: Tue, 11 Mar 2025 13:59:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1741697963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mqrVsWAlbMJNJgk2uSMgNDQZC0XfWOKSi6T6DcyzAp0=; b=3I4jb67p12pbZXlW5wsZxfRszIQiN+eZiTk7Ww8zV2EbdB7itO8rJQHn0bSmkEGbZeO3vJ XmXEWhHwGPXxbq8bEUA+I3seKxHDOp/3ypelg92IX8oAvPwQg9s8v39T5/Qr0A83QQXgPp GOqqXKiAVOL5bbbRPwXiwgKxVWxJU1/xUxzOmH8dCOelp5nZLnLP1zNHVJtm/tY4JsnLF/ L7Ia7LoayWT93P0QoScJ06lheO6/dod2SSYpZ1T6f9mchiPWIDtmKy2dPt4YUmHoQdtpov TzcbDOrl3Il6FC4504Z7IOQEizEM/PcvFf8iqgyvFpvls4BXcVyiRrfW+Xou5g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1741697963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mqrVsWAlbMJNJgk2uSMgNDQZC0XfWOKSi6T6DcyzAp0=; b=+kLjVgNeFywidxNYfTtOLCrRLemJQEw0Fklqsgsyv7GQc3P+pSJj14uutJRtGCGWnB4TeB qL64bP9jmsO8UMBA== From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Heiko Carstens Cc: Andrew Morton , Jeff Xu , Lorenzo Stoakes , "Liam R . Howlett" , Kees Cook , Alexander Gordeev , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH mm-unstable 1/2] mseal sysmap: generic vdso vvar mapping Message-ID: <20250311135542-574f3a8a-525f-4e84-9f04-c9d1ded0deef@linutronix.de> References: <20250311123326.2686682-1-hca@linux.ibm.com> <20250311123326.2686682-2-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250311123326.2686682-2-hca@linux.ibm.com> X-Rspam-User: X-Rspamd-Queue-Id: 3B4ED18000D X-Rspamd-Server: rspam03 X-Stat-Signature: foiwiwf1ifx97bj694eb55k4c8fbr6h8 X-HE-Tag: 1741697964-51703 X-HE-Meta: U2FsdGVkX193QKOSIHRJjsaWRRCNaadM26ZHOMmfkMAB+rziEG0xaX7fhNjDtaLSfOExIVAZTQ0Z48g6hYhxHV7Lok+OmkierqYqSy/9iKFMxMPXfQVNb/9E3LEoQptFLrFJFe0cWEpEEbuIiKqEtM04Jr/PoubluD1IEdWap8oFxGyhWsZSKOEvYT5jxXbmDj7rikFK/RQpJj+Ihh8/m4LzI5jU+oSVtJorkH9BT/+Ws4A8yPBwvvaJRz/d7SkQVtEHbNOzT0gHoztYQJJ8qucQjBSi9xIZU06rFvrdYKidjATzGJJm0FlCTm/PUi8CvM6eN7HJUhvmxUGlkgdO7QoVFYKt7tF6CWaJ5QKqvocoQm6CJCOqb05Jlzkb9PVDCb3WTnOMJzvVep9Esh6XW0f3RmoQMNrFhcvEF3dxnYl54ppALaD80kI1i6xaY36sZnIPWWCVcTQcP74xVyvrv5PDQbjcpp+xdzr9OR2OsAgyy/XOUvPp0beHOIhZ8qZACupZc06HTK7aS+SEiUjXLiA9AnCKE9j21Qc5KE6gL5JlVF5jDSONc2tsKvXI8/zrIq150xzwEdaszAC+KgLZoW+Kt4MZ1BZIxmDfl9pQZdcqWcMZQ12ui6BVBcaZD3gmz8BbaR4O1m3krgT/81CSl/lxv4u2JuwpLRmCf731QeqWLGTaspNHG0iehzBv/NWxoo43tq7opCXphC9dBRmoq6cwNGBLilATu4UydN8O1K39M024GS8J47/x0uoC+AsH0/nXGIVl5Mbn+UIxPriy/SSKhon09qVEKQ5DUXsFY6qv9qggJKPoW/jZN9iMM8IjmsRJs49kNiw6f3MmvgWvgOiKMFrR8AA0RuJm9toMWDhJ18sGU+QKErFVdu2gDL0AZgVvef0CGf5WtjfmfmabJOddgCf3A3jd0x5lgk0GSaoygtBA9X8mYzolWDq8kfwlzemgwVbayGelTC5Sm5z eV8N2NRU 9GaK4DkwObKd3HA3m3r5HIY92qlywlBLpe4DXOXGASQaw9k2mkQvttFTSdCOX7l7GcXLaPfPnftVCVCmixXccNTlNNTAtsplfpip/G5D2tvJyzUH0UrdFC5yk9ec/rM6WDSQNh6RnxyaMNTcZmHlDilMVvDRwr6fLBa2jaCKfoQFOcuMf/NnsLKlsgtUOEy4Pi2wk1xT+kb1iAy097NQQS7CYsScMG5LUitJ4sbnC1C3wOkVNU5OHrDFGD+TOR3VM/lguvnTeQG2w2d8KpNKgJarfbPxXjiUOuIvHilVDOJmgXi3Q4SbPmvGGa8B1gdxM1ZHi4av0XbgN5HO9gGv6SCbBKqb+9XkDSDv3mx3aWIDGUFX7ONEGVV4ius80lAd+BWar6lI+c/p2EqidcWWzJjK8oE8RHRYekwXVUuoBjZaOKDqJfe938S+e0WxWnTPpl7dGWhOYZbOXUJ9sHARwZCsiQ41yBZ5konbozo+8CEP14/YLTl9w5Vu2B3EmMBY0rPcywc04CoqHtIjVP08N93z4Pqs0HBVmuBCp X-Bogosity: Ham, tests=bogofilter, spamicity=0.005070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Heiko, On Tue, Mar 11, 2025 at 01:33:25PM +0100, Heiko Carstens wrote: > With the introduction of the generic vdso data storage the VM_SEALED_SYSMAP > vm flag must be moved from the architecture specific > _install_special_mapping() call [1] [2] which maps the vvar mapping to > generic code. I think this change should be part of the merge commit between the trees carrying the generic vdso data storage and mseal for system mappings. https://lore.kernel.org/lkml/20250307151426.5f3c0c39@canb.auug.org.au/ https://lore.kernel.org/lkml/20250311150847.5a63db36@canb.auug.org.au/ > [1] https://lkml.kernel.org/r/20250305021711.3867874-4-jeffxu@google.com > [2] https://lkml.kernel.org/r/20250305021711.3867874-5-jeffxu@google.com > > Signed-off-by: Heiko Carstens > --- > lib/vdso/datastore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/vdso/datastore.c b/lib/vdso/datastore.c > index e227fbbcb796..b7c7386c98a9 100644 > --- a/lib/vdso/datastore.c > +++ b/lib/vdso/datastore.c > @@ -99,7 +99,8 @@ const struct vm_special_mapping vdso_vvar_mapping = { > struct vm_area_struct *vdso_install_vvar_mapping(struct mm_struct *mm, unsigned long addr) > { > return _install_special_mapping(mm, addr, VDSO_NR_PAGES * PAGE_SIZE, > - VM_READ | VM_MAYREAD | VM_IO | VM_DONTDUMP | VM_PFNMAP, > + VM_READ | VM_MAYREAD | VM_IO | VM_DONTDUMP | > + VM_PFNMAP | VM_SEALED_SYSMAP, > &vdso_vvar_mapping); > } > > -- > 2.45.2 >