From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917C8C282EC for ; Tue, 11 Mar 2025 13:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6C8280004; Tue, 11 Mar 2025 09:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 355BD280001; Tue, 11 Mar 2025 09:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6F3280004; Tue, 11 Mar 2025 09:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00FAE280001 for ; Tue, 11 Mar 2025 09:37:48 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8F7641CD306 for ; Tue, 11 Mar 2025 13:37:49 +0000 (UTC) X-FDA: 83209373058.21.BB0E6A5 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id 7658040007 for ; Tue, 11 Mar 2025 13:37:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PvaCAfVG; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741700267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJMEVRMgBysG/rCdU5xkas/lYQi1X1Or+Niq8x80GmQ=; b=Riflym9/sFf/ermlAreelt/H4j2Ha9vm56be7hZQcTQtwqHoRCg3+1WePGk9KE1hHrLg2X wFvtZzASELqz4eeS9tmQHCWxh+wZ6ReP+dONN8j2zg8I3sSgnEekP5Vt7kJxsku39i0aHR GqV2kl70b9GxILDJ6ffz5KUqLqTagPA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741700267; a=rsa-sha256; cv=none; b=b1CK7mL8oSs44ZBtbzRF58FhwoQxfm7oR/pqydrqFKQOqUeEWDWb2K8WBK7BlUx6icdDZi Ux3zfeTdr9cV8fqz/vri0P3fNG2F0YFDK55AYstypLk4bk3Yz0HlPtpFlsuKSA/idcD0Gs IRXf7GiuHlF1/X1PEBpHqz31+H9o2+I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=PvaCAfVG; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52B9O9BJ026567; Tue, 11 Mar 2025 13:37:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=JJMEVRMgBysG/rCdU5xkas/lYQi1X1 Or+Niq8x80GmQ=; b=PvaCAfVGCIetcTtPsGzyClf2gkop1ZbF8debTPYGGmoCa/ zE3CFkUWcEWZqMKckJ66vWFVxBkGV490JtjrbA6mR0zg2TznGxRSMn31K304Lxmy /22kc//XQzcPDKa4xrq7hYQQCImktbO/c05jqTGSHpkRDBGDjRM6vrYS7JxURmY7 iJRXOmYyGgCUDyC+AkSRhNLdlpnYPxYft6pHStMEdG0Y/y2dWEnnyaFlF2G841wW W9asmSZ7csJRoGyrMKNuLGakc6Xf/BRgSi0UoZsA3BT3/rsias/Tu516Kb0c7NRW MSHR66chT8+yJGgF0xcI16hrnlkrslFH7U+nz90Q== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a7a1c4ny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 13:37:42 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52BCBJrY006957; Tue, 11 Mar 2025 13:37:41 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 45907t4m2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 13:37:41 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52BDbcEp50659614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 13:37:38 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CFAC20043; Tue, 11 Mar 2025 13:37:38 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9ACE520040; Tue, 11 Mar 2025 13:37:37 +0000 (GMT) Received: from osiris (unknown [9.179.21.35]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 11 Mar 2025 13:37:37 +0000 (GMT) Date: Tue, 11 Mar 2025 14:37:36 +0100 From: Heiko Carstens To: Lorenzo Stoakes Cc: Andrew Morton , Jeff Xu , "Liam R . Howlett" , Kees Cook , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Alexander Gordeev , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH mm-unstable 0/2] mseal system mappings fix + s390 enablement Message-ID: <20250311133736.12846D42-hca@linux.ibm.com> References: <20250311123326.2686682-1-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZhUvvsniQwUCumfJ9wijChu1grlkgigb X-Proofpoint-GUID: ZhUvvsniQwUCumfJ9wijChu1grlkgigb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-11_03,2025-03-11_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=2 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxlogscore=181 malwarescore=0 clxscore=1015 mlxscore=2 impostorscore=0 bulkscore=0 spamscore=2 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503110086 X-Rspam-User: X-Rspamd-Queue-Id: 7658040007 X-Rspamd-Server: rspam08 X-Stat-Signature: srj4uznemkdtoknnqset34cthjpmj387 X-HE-Tag: 1741700267-963929 X-HE-Meta: U2FsdGVkX1/aMds99y1tW8Nsb+CRFkjwqSVYaA/gKGSbPPrK1x51f3v+BXA1AW72xK/W3hTOvHSjRZNMG6F2zEMqNGlFp5+W1mjkI5CRCyIZJuK9yUNyyC9GxxPR0K7KeGy2jPZvjSPIrXiDDpP34nYhay+J0H1DeBEN1jpMnPnbogrmBOGHaj4+HcIPyhlETdguwzI3lDjVEWtj5qie0aYl+Ydmk6t/WYp9sUu808KjN7KzzznesehBq/wR6UrrMclyDHR1sh6aWS/y66OtIy/i+FSGoKVz3dqiBJkeau2kSArsKYDoMN2RAvJzDWYe2VbIqbsN70/VLHmKVgLy4+DUeo82miljasrlOK92C6yzE4MPzWeN5D5Z+Yt14thTQDKHwOwThBo2I/pDge05I01mF41D0b8YMp5ARBVJfWuBjY+lqjB2/Wf1tnve3ivSG4yE6DWTXEXou5mGBUrcqOlcQ+cEIGDXg8RgNfLI4gI9xmP9Pz9ZqspaOz1WZl46VWt4tsPfIG5O8dDmBBTtRPxdq6GEW54DnqiD5jVWxjAzIheZBvgka2h+5Pe/hxxaFcaliy9eolC8/qCGx7MsYwpcS9TuVfs86CXVXB+mzn/tlrvTDPmioLi0kcfqZS/X+UQkZUdl4hW6fZLmys+EjTPTD+QLE1x8MaKSuqrtTD9R7kX/Hzg8WqnNVR4LfpLTdvdKvwUyH/FFx42uafAdhcYIJJKlTpwACE/RPTPkppyaEwpiEDZ6mLZNNQ1i6a6qhwcUT52IqLXl4UkvG1j+XAJsP9Fe3+uxY1u6CzX9TPRzTp9sxibLijmIIHVmxhDP7bxuLD5ZXFtiAb0BG15ApPrsyxBazDFZrLDBKVBEgEWsr7aSrz3z/PgB9+ObyvU+eVaf852MuTX2JvNAIeNC/zeZR6uM+hzcjErKQLqeUE1cjbrq1ySJzIOrsYW3QV30U/jAqQafTHtWGXxa3xl i4vV+W7A j/Cm5xwXJGhysrhX8657xsf9QFdP7mb0EGWe4VfQaCrG+klqLzpd9aKcIeJQQptLteHZq3AwdX2xLgaBv2h9nlqAKrrPxy+LT8hr/pYkRdOM5aInZlvgy0ReG8t0sS/YFP+2RrZXuphY+/BbZoL7tc8ToXQTxaM5+fXDjm3ToUc8RPRaswoZHSSwqFhxtfPRhTyEywKJJpna6nxqy3WYkJfjx5X6RqVcxTgAq3ru7J4w5MqV4z7BiJqWz19JZfJ670pcPHMFTKHzK7fLhXwVmi0fAkKBLJPTV7bXoopXU/DSICDSuF8Qsw+6aswEDvKFyHQqNVJt1WqLjxyqkJ88+ZrIEwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003495, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 01:02:47PM +0000, Lorenzo Stoakes wrote: > On Tue, Mar 11, 2025 at 01:33:24PM +0100, Heiko Carstens wrote: > > When rebasing the mseal series on top of the generic vdso data storage > > the VM_SEALED_SYSMAP vm flag for the vvar mapping got lost. Add that again. > > I'm confused by this? Some merge patch resolution thing? See my other mail. > > Also add s390 support for MSEAL_SYSTEM_MAPPINGS. > > 'Also' = the whole thing this series does? > > Can you confirm that s390 absolutely does not rely upon > moving/manipulating/etc. the VDSO, VVAR, etc. mappings? > > You should say that here. Just like for arm64, and x86_64 the s390 part is just adding the new vm flag to the _install_mappings() call in vdso code. Otherwise there is nothing to be considered.