From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F353C28B2E for ; Tue, 11 Mar 2025 04:03:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73EBA280003; Tue, 11 Mar 2025 00:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ED76280001; Tue, 11 Mar 2025 00:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B8FC280003; Tue, 11 Mar 2025 00:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3FD2A280001 for ; Tue, 11 Mar 2025 00:02:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A56121618C8 for ; Tue, 11 Mar 2025 04:02:59 +0000 (UTC) X-FDA: 83207924478.05.CE53D0A Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf28.hostedemail.com (Postfix) with ESMTP id 2F8E6C0004 for ; Tue, 11 Mar 2025 04:02:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741665777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irm2qMR+E49Bx12z5wWVn4QDdGQWk9iIRcSOjWU6oJY=; b=MGlsbLOmfPne8fu6dvhs7uvQARElr65qFr9TA9vsQmaHriIrKgbL1pHmGqS4TrUh+xYiaS kon7qZRaeaXZhrQy8LZo4YKbjNfG8TZqtFMLxEgmCybhPOrYn/3mu8GTm+PwoSMgF3n7WD 2AOG5YiJS5CptltCHjaP4LxnW4kzOXA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741665777; a=rsa-sha256; cv=none; b=EDTlcBuKr0RdM9awPLhPWQP67gzVDUVNfTKR11vDceBXy3OT2T9RD1mUxLe+fvZ4stpgqd xt6RHuUgjK3kjoKm53l7S9/QhJaR1yU3Tn6GckKdy2MLrYerNC4GffBNJW58bHcG4E1zEd X66j1M2AyYUbGx62x3Zcd8YBIPozoWQ= X-AuditID: a67dfc5b-3c9ff7000001d7ae-56-67cfb5eed2d1 From: Yunjeong Mun To: Gregory Price Cc: kernel_team@skhynix.com, Joshua Hahn , harry.yoo@oracle.com, ying.huang@linux.alibaba.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, Honggyu Kim Subject: Re: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Date: Tue, 11 Mar 2025 13:02:07 +0900 Message-ID: <20250311040252.425-1-yunjeong.mun@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsXC9ZZnke67refTDfa9tbSYs34Nm8X0qRcY LU7cbGSz+Hn3OLtF8+L1bBarN/la3F/2jMXidv85VotVC6+xWRzfOo/dYt9FoIadD9+yWSzf 189ocXnXHDaLe2v+s1rM/TKV2WL1mgwHQY/Db94ze+ycdZfdo7vtMrtHy5G3rB6L97xk8ti0 qpPNY9OnSeweJ2b8ZvHY+dDSY2HDVGaP/XPXsHucu1jh8fHpLRaPz5vkAviiuGxSUnMyy1KL 9O0SuDJ2LJvOVHDUrKJnyQaWBsY+1S5GTg4JAROJrmM72GHsQ3PngtlsAhoSBw+dZO5i5OAQ EVCVaLvi3sXIxcEs0MYicfPVYkaQGmGBCIlzj06zgNgsQDXfH79mA7F5Bcwkvm84xgQxU1Oi 4dI9MJsTKL7g6ExWEFtIgEfi1Yb9jBD1ghInZz4Bm8MsIC/RvHU2M8gyCYFt7BJT7m1lhRgk KXFwxQ2WCYz8s5D0zELSs4CRaRWjUGZeWW5iZo6JXkZlXmaFXnJ+7iZGYJQtq/0TvYPx04Xg Q4wCHIxKPLwBj86lC7EmlhVX5h5ilOBgVhLhPXgFKMSbklhZlVqUH19UmpNafIhRmoNFSZzX 6Ft5ipBAemJJanZqakFqEUyWiYNTqoHRJ6T4z5VtEU/uXpJl+K8jVzhjU2jf5X+3i8+VWM89 3j5rp7F8St3GqXuu+EwPNHDXuFz7UuZW2TID1x9HWmyDNC/LSsjc/yzpf+z/o9hbp2yTzih1 2O3Yl6CSK1m4OOjSaev0DQzruaQvNMmE1bU9WrWwTF5f82lhkcdkjVd3U+Qz/qheX+GpxFKc kWioxVxUnAgAQ6OLYq4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsXCNUNWR/fd1vPpBq9e6ljMWb+GzWL61AuM FiduNrJZ/Lx7nN2iefF6NovVm3wt7i97xmLx+dlrZovb/edYLVYtvMZmcXzrPHaLfReBug7P PclqsfPhWzaL5fv6GS0u75rDZnFvzX9Wi7lfpjJbHLr2nNVi9ZoMBxGPw2/eM3vsnHWX3aO7 7TK7R8uRt6wei/e8ZPLYtKqTzWPTp0nsHidm/Gbx2PnQ0mNhw1Rmj/1z17B7nLtY4fHx6S0W j2+3PTwWv/jA5PF5k1yAQBSXTUpqTmZZapG+XQJXxo5l05kKjppV9CzZwNLA2KfaxcjJISFg InFo7lx2EJtNQEPi4KGTzF2MHBwiAqoSbVfcuxi5OJgF2lgkbr5azAhSIywQIXHu0WkWEJsF qOb749dsIDavgJnE9w3HmCBmako0XLoHZnMCxRccnckKYgsJ8Ei82rCfEaJeUOLkzCdgc5gF 5CWat85mnsDIMwtJahaS1AJGplWMIpl5ZbmJmTmmesXZGZV5mRV6yfm5mxiB8bSs9s/EHYxf LrsfYhTgYFTi4Q14dC5diDWxrLgy9xCjBAezkgjvwStAId6UxMqq1KL8+KLSnNTiQ4zSHCxK 4rxe4akJQgLpiSWp2ampBalFMFkmDk6pBsYLAlvPaTRv/rLX3fuKcHhNAtfBJJWkk2uitnSG Zei/enTKjStu6ZauvhXaH2cUyVc6bn7HdsNf48zULB+/7vW5dx+WmRmcevY797wtm6R07mvT mHVHXY877dwRF73YbH7Z1PNMy57+6Ildui+qyvnmtAdeMmWv38te1t73Y/I295ba7vNLPyor sRRnJBpqMRcVJwIApvCxRaMCAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2F8E6C0004 X-Stat-Signature: mnhysp8w9qukijk5j7r5q4imiwkphkjn X-Rspam-User: X-HE-Tag: 1741665776-284203 X-HE-Meta: U2FsdGVkX18XqFmTjqWroEHuZu1l+5xBOIPqoKtRLIOb2VfFnvAlXToz3ZbXXzbR907dMzTujN8TQq7BPfc7DkUuarLK3r3z4c34gGej4nD+7i2+51KG/ji2dkLUUvR79MOdTo2g70S8dt4oNvQmj6Ni0jUNZZNhxO7B6zexPID/D/BUNlvBlt0Lf5rBv4zAsJ1lxYuPU5MGTz7uJ7yTbPtT7YtsF5Uit0K9jSNX4TY2vhYdFpZB3741tFGO9Q8/6qp452UvS9iOffiReWzYCVnNXzIXOh6nd7cCI7LjnGHFA+6d8Jr6ldroxTnOXmFs7Ch4hWGOdhqPGweHHDp9D47qGk+NRTk5dFuMRhgkpm8/a9lNbvGoXexdmQ06DT21V4HcxlirYZH1xGJLlDcX8KEKbpMD8PW4hUb/P2bVWrXpABXS6Ergvm9l1Ds9C/xvIN+YJDMdqGvYfuhh6PCtx8V5lNzd45SL/MAYLIQqU/cwgdWmOoxaml4z1D5ZUMn7Z176VLVjNH8S/lUbBOxPFIg6CEiq0WveHCVSOpfzk1Q9cX2xzkj0bvoC/FmgbeyHaM8IE5ZezXgcJ5DM7n5Y2ojOAs3NJ1NHCVuwkDy2CHECpGL1bVfEoBekiWPW5Oo1bH0OBWx1uGNOVE/1EWp7xAgC1HKqusEHxwr93lzQMSKYWAkl9I6l8zEcbt4eiHfoSbv3JdmUrUhSskTtIzz2NlGkIkyqOMS7Iy8tCjp6ycGd9bczRRT1RS383q2YXMZRhVqmQdz+Iuz3DEFgHswuQ3cJttjkmDDoq+AqBeCIhnLehnICdywor0NzJDS0siY2WnlcQseEuUmMdlA3LY0/3YDD4f9RPSzqeOCEQUJWFv/PQUNA7Glf/nDLdLw2/g98mhIMLcXOuzEgRy3W0nqhOCHCz89mYaSwMv6vFYvPBzOrCSWjRJ0QxKnfCT80OgTgBZmRicZE5ZGPPuUEEsj Afn54duu OJiwj5/LkTAF/SdYIJV0GkYejowbdPxFXo1ft0jaCx0iwdlxc9bgE80OVmYV3L8zMq1/kFeS8YJhAVhwxyPcWpu3NdBf+E1pgP9dzZQLV9uF1ANHECnMAKZ+RA6J4X2HqqLdtBnAcS0rHlkbv2vZOD1phUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Gregory, On Mon, 10 Mar 2025 22:42:52 -0400 Gregory Price wrote: > On Tue, Mar 11, 2025 at 11:07:27AM +0900, Yunjeong Mun wrote: > > Hi Gregory, > > > > In my understanding, both SRAT and CFMWS have the above device and interleave setup. > > > > and below are the CFMWS configurations (with some unnecessary lines removed): > > > > [0A4h 0164 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] > > [0ACh 0172 008h] Window base address : 0000002080000000 <- Memory region > > [0B4h 0180 008h] Window size : 0000032780000000 > > [0BCh 0188 001h] Interleave Members : 01 <-- 2-way interleave > > [0BDh 0189 001h] Interleave Arithmetic : 01 > > [0C8h 0200 004h] First Target : 00000043 <-- host bridge id > > [0CCh 0204 004h] Next Target : 00000053 <-- host bridge id > > > > ... > > > > [170h 0368 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] > > [178h 0376 008h] Window base address : 0000064F80000000 > > [180h 0384 008h] Window size : 0000033000000000 > > [188h 0392 001h] Interleave Members : 01 <-- 2-way interleave > > [189h 0393 001h] Interleave Arithmetic : 01 > > [194h 0404 004h] First Target : 00000143 <-- host bridge id > > [198h 0408 004h] Next Target : 00000153 <-- host bridge id > > > > Are you able to share all CXL Fixed Memory Window Structures in the > CEDT? Just want to confirm some suspicions here about why we're seeing > 12 NUMA nodes. This explains 2 and suggests there's at least 4 host > bridges - but not the other 8. > Ok, there are 10 CFMWS entries and 4 host bridges in cedt.dsl. Below is the information for all CFMWS entries and host bridge in the CEDT: [024h 0036 001h] Subtable Type : 00 [CXL Host Bridge Structure] [028h 0040 004h] Associated host bridge : 00000043 [044h 0068 001h] Subtable Type : 00 [CXL Host Bridge Structure] [048h 0072 004h] Associated host bridge : 00000053 [064h 0100 001h] Subtable Type : 00 [CXL Host Bridge Structure] [068h 0104 004h] Associated host bridge : 00000143 [084h 0132 001h] Subtable Type : 00 [CXL Host Bridge Structure] [088h 0136 004h] Associated host bridge : 00000153 [0A4h 0164 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [0ACh 0172 008h] Window base address : 0000002080000000 [0B4h 0180 008h] Window size : 0000032780000000 [0BCh 0188 001h] Interleave Members : 01 [0BDh 0189 001h] Interleave Arithmetic : 01 [0C8h 0200 004h] First Target : 00000043 [0CCh 0204 004h] Next Target : 00000053 [0D0h 0208 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [0D8h 0216 008h] Window base address : 0000034800000000 [0E0h 0224 008h] Window size : 00000163C0000000 [0E8h 0232 001h] Interleave Members : 00 [0F4h 0244 004h] First Target : 00000043 [0F8h 0248 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [100h 0256 008h] Window base address : 000004ABC0000000 [108h 0264 008h] Window size : 00000163C0000000 [110h 0272 001h] Interleave Members : 00 [111h 0273 001h] Interleave Arithmetic : 00 [11Ch 0284 004h] First Target : 00000053 [120h 0288 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [128h 0296 008h] Window base address : 00000C2F80000000 [130h 0304 008h] Window size : 000002F840000000 [138h 0312 001h] Interleave Members : 00 [139h 0313 001h] Interleave Arithmetic : 00 [144h 0324 004h] First Target : 00000043 [148h 0328 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [150h 0336 008h] Window base address : 00000F27C0000000 [158h 0344 008h] Window size : 000002F840000000 [160h 0352 001h] Interleave Members : 00 [161h 0353 001h] Interleave Arithmetic : 00 [16Ch 0364 004h] First Target : 00000053 [170h 0368 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [178h 0376 008h] Window base address : 0000064F80000000 [180h 0384 008h] Window size : 0000033000000000 [188h 0392 001h] Interleave Members : 01 [189h 0393 001h] Interleave Arithmetic : 01 [194h 0404 004h] First Target : 00000143 [198h 0408 004h] Next Target : 00000153 [19Ch 0412 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [1A4h 0420 008h] Window base address : 0000097F80000000 [1ACh 0428 008h] Window size : 0000015800000000 [1B4h 0436 001h] Interleave Members : 00 [1B5h 0437 001h] Interleave Arithmetic : 00 [1C0h 0448 004h] First Target : 00000143 [1C4h 0452 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [1CCh 0460 008h] Window base address : 00000AD780000000 [1D4h 0468 008h] Window size : 0000015800000000 [1DCh 0476 001h] Interleave Members : 00 [1DDh 0477 001h] Interleave Arithmetic : 00 [1E8h 0488 004h] First Target : 00000153 [1ECh 0492 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [1F4h 0500 008h] Window base address : 0000122000000000 [1FCh 0508 008h] Window size : 000002F000000000 [204h 0516 001h] Interleave Members : 00 [205h 0517 001h] Interleave Arithmetic : 00 [210h 0528 004h] First Target : 00000143 [214h 0532 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [21Ch 0540 008h] Window base address : 0000151000000000 [224h 0548 008h] Window size : 000002F000000000 [22Ch 0556 001h] Interleave Members : 00 [22Dh 0557 001h] Interleave Arithmetic : 00 [238h 0568 004h] First Target : 00000153 In my understanding, the reason we are seeing 12 NUMA node is because it loops through node_states[N_POSSIBLE] and its value is 4095 (twelves ones) in the code [1] below: for_each_node_state(nid, N_POSSIBLE) { err = add_weight_node(nid, wi_kobj); if (err) { pr_err("failed to add sysfs [node%d]\n", nid); break; } } Since I'm not familiar with the CEDT, I'm wondering if you mean that N_POSSIBLE is associated with the number of CFMWS. [1] https://github.com/torvalds/linux/blob/v6.14-rc6/mm/mempolicy.c#L3508-L3514 > ~Gregory > Best regrads, Yunjeong