From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198FBC2BA1B for ; Tue, 11 Mar 2025 02:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CEE1280002; Mon, 10 Mar 2025 22:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87E4A280001; Mon, 10 Mar 2025 22:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74607280002; Mon, 10 Mar 2025 22:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5729B280001 for ; Mon, 10 Mar 2025 22:08:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F060D1617DB for ; Tue, 11 Mar 2025 02:08:14 +0000 (UTC) X-FDA: 83207635308.14.829E33C Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf06.hostedemail.com (Postfix) with ESMTP id 9B975180008 for ; Tue, 11 Mar 2025 02:08:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741658893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWwQICf9jYZvs/QMOcHLFKDGxieLL7rUnE3E1F07yS8=; b=XsqmKyW7gX/0dsAgcqxvHqwP8miliJJtieaN3yhOzfVAiqQ0sVMsrRf7TGktt0OojbRlEq rkNj3XtGSas/cRYsJgya1ptzGzNUw/H3GIVh8vaho93kjx0uaQm1kDWBatrtzw9s9q7Myl Qhx3CGcO1mcCZi09llVbJdof49WJ5rE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741658893; a=rsa-sha256; cv=none; b=UXogd9uYpgFM6Ex4uMW+6VsAwHex5TsG2fEmnXxlpcGDoy+8sh8bTajJWME6sGKKmjvtOQ S2RLAqExe8YGO2s7ntZEmaz8bcUpoXt7SBLsNJHE3p5ZF8KwUYg9t4cQPRBsjuBMncpTGS ilDypkgl/6T8n+MkK2sEqbdPfTYxCMQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of yunjeong.mun@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=yunjeong.mun@sk.com X-AuditID: a67dfc5b-3e1ff7000001d7ae-e9-67cf9b085d26 From: Yunjeong Mun To: Gregory Price Cc: kernel_team@skhynix.com, Joshua Hahn , harry.yoo@oracle.com, ying.huang@linux.alibaba.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, yunjeong.mun@sk.com, Honggyu Kim Subject: Re: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Date: Tue, 11 Mar 2025 11:07:27 +0900 Message-ID: <20250311020806.404-1-yunjeong.mun@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsXC9ZZnkS7H7PPpBl+ey1vMWb+GzWL61AuM FiduNrJZ/Lx7nN2iefF6NovVm3wt7i97xmJxu/8cq8WqhdfYLI5vncduse8iUMPOh2/ZLJbv 62e0uLxrDpvFvTX/WS3mfpnKbLF6TYaDoMfhN++ZPXbOusvu0d12md2j5chbVo/Fe14yeWxa 1cnmsenTJHaPEzN+s3jsfGjpsbBhKrPH/rlr2D3OXazw+Pj0FovH501yAXxRXDYpqTmZZalF +nYJXBkXb5xmLlgmW9G65gtzA+N9kS5GTg4JAROJmTsuMcPYF3fvZQSx2QQ0JA4eOgkU5+AQ EVCVaLvi3sXIxcEsMJdF4tyuhWwgNcICERLnHp1mAalhAap5tUEDJMwrYCbR0XiKFWKkpkTD pXtMICWcQPFLx2NBwkICPEDV+xkhygUlTs58wgJiMwvISzRvnQ11zS52idnTayFsSYmDK26w TGDkn4WkZRaSlgWMTKsYhTLzynITM3NM9DIq8zIr9JLzczcxAuNrWe2f6B2Mny4EH2IU4GBU 4uENeHQuXYg1say4MvcQowQHs5II78ErQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8Rt/KU4QE 0hNLUrNTUwtSi2CyTBycUg2MM2uzbnV8/uC3UNw76J2pBfPZAm7TfYymWsfYCtuj3rguFjX/ uNeXPaZN6F52pP2fzgm/r67hmSsxIb2k6J4MW8d2nsq3095a9UVds89Zwt797dIur4Dm7wcf 1pj8CpvQor9dm1943xymRs7XceoSx4oTF+n98pyqK7f/rNx/+Zlf5jR/W1inxFKckWioxVxU nAgA1eYo9KsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsXCNUNWR5dj9vl0gyPfhS3mrF/DZjF96gVG ixM3G9ksft49zm7RvHg9m8XqTb4W95c9Y7H4/Ow1s8Xt/nOsFqsWXmOzOL51HrvFvotAXYfn nmS12PnwLZvF8n39jBaXd81hs7i35j+rxdwvU5ktDl17zmqxek2Gxe9tK9gcRD0Ov3nP7LFz 1l12j+62y+weLUfesnos3vOSyWPTqk42j02fJrF7nJjxm8Vj50NLj4UNU5k99s9dw+5x7mKF x8ent1g8vt328Fj84gOTx+dNcgECUVw2Kak5mWWpRfp2CVwZF2+cZi5YJlvRuuYLcwPjfZEu Rk4OCQETiYu79zKC2GwCGhIHD51k7mLk4BARUJVou+LexcjFwSwwl0Xi3K6FbCA1wgIREuce nWYBqWEBqnm1QQMkzCtgJtHReIoVYqSmRMOle0wgJZxA8UvHY0HCQgI8QNX7GSHKBSVOznzC AmIzC8hLNG+dzTyBkWcWktQsJKkFjEyrGEUy88pyEzNzTPWKszMq8zIr9JLzczcxAqNqWe2f iTsYv1x2P8QowMGoxMMb8OhcuhBrYllxZe4hRgkOZiUR3oNXgEK8KYmVValF+fFFpTmpxYcY pTlYlMR5vcJTE4QE0hNLUrNTUwtSi2CyTBycUg2MFrM9nJw+XJBXWJkXuMF4l/WKC3l3ihdo HXjU3lCW8uWZQ+Q7z12mC5JNQiKFFB9vvvpV6YfWFe3Fm0+EWzPdrD12/1PNbvG0vxPWneK+ dmHNiejyq8oT5OXlrj56dNdqFmur5v+L7yzuHOc4NetSfI5V1GSnzNn617meSq3+eMfd4n2d aSeTmhJLcUaioRZzUXEiAAEEaYmmAgAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 9B975180008 X-Rspamd-Server: rspam08 X-Stat-Signature: i1e41fduxiffptn4b6hyo9u3icupmg54 X-HE-Tag: 1741658892-13811 X-HE-Meta: U2FsdGVkX18M2NwmYdA0C43RJ28FoNT2NJUvTzhM/evT3PRThSqte2mPVy+OCSa0VRm8WMS5XfkdyeT584SZ52GzjQR2dONEIcWfrjNdoBnSxzTeEaCKq8GL0aI04z8mXe+7sxpyR0Naf0c7lBYuK9mDILnaHBWtd46BfJYv574TGxz9FuDHZkugxKKfaYm4eRxQltjoA+w1wr82Z+TfW7BlUjblRLpFM22ohJcUrVtjp7b4IOuy5Ppa/u60IJKkicctoIjhrPJ8HwYRWJ7SutKGZ6N8/ew9jrkkY6X34LS2V/RUrANoRlhgWl8DrJ54ShrJAotZBwnQ1jJ6I0smxf6rouXc+2uT9wwJ+l+f0kn7FFaMeAoOthW21ljJouqp0DPj75dZF3n5/gFrx1o7ptj8oUb8Tnr3xwYv4Q3ZhB/3Ho4CsKJKHZMOIcrqk1FkIh7jJX3cvTmb+HcTZB08zRcRj+lhmn1ea6zVADlq2AOmPBbCD+USvNtD7mtrRyRyAJ/cQ+pGFFW7ImvTVbHzdtTR1vcVeZM6bAFU2dTI9MCjyIDrzFvDmOJbuJCmX+6pTzLAtPcGBPL3ZibQaZ8/yKtLLZLd06oqyqqGzIRbsJhqj7yBYFHATEnwSbDb+JJbgGKs2UtRm3KQ2D1+xd6HP4FT7NtSjy/fAzpvyOAdx+I+9itpNohXPOJf+KEM+L1KLA4uz3yYfn42sjML61Cm+gtvL9zYZUYI1xiKIq41VJIz5+6r5lt7tZ/hTSNKquGgYHusF+hLz9psNk74kenz3i0NfRwTYGyYIcJHrK9PmvCoYo2V5ISwpcIU8yAk9zqFBAFQMneSBF6oUkO9ZpYthhPguAjmrI0i6Bq9jiGCugyz1sBmCxmg3l6aHKszWhCwnSuPC/3YlHl+AwoKQ0dxmeuMrI8SLTOvR66JOIQuwZHGyr/4raD8izKggHfNiTAYzaHe8iuYX4Jvh9P32Va JLamBOJj oig/sCHisXz3KlM1OOAFtD+093R2BaPXz50JY65Tbpt6wl4IjpYUsWFH2utlC3z8ag+cVElWIclQzoVJNxcFOsWafMBrafqVPdBnZ+l2IiUXV2HOdlQxdysLbDLCa2BGZnv5B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Gregory, On Mon, 10 Mar 2025 10:22:11 -0400 Gregory Price wrote: > On Mon, Mar 10, 2025 at 09:26:48PM +0900, Honggyu Kim wrote: > > Yeah, the proximity domain detects the node correctly as follows in dmesg. > > > > [ 0.009915] ACPI: SRAT: Node 0 PXM 0 [mem 0x00000000-0x7fffffff] > > [ 0.009917] ACPI: SRAT: Node 0 PXM 0 [mem 0x100000000-0x207fffffff] > > [ 0.009919] ACPI: SRAT: Node 1 PXM 1 [mem 0x60f80000000-0x64f7fffffff] > > [ 0.009924] ACPI: SRAT: Node 2 PXM 6 [mem 0x2080000000-0x807fffffff] hotplug > > [ 0.009925] ACPI: SRAT: Node 3 PXM 7 [mem 0x64f80000000-0x6cf7fffffff] hotplug > > > > It is printed even before CXL detection. > > > > I wrote a some documentation on some example configurations last friday > > https://lore.kernel.org/linux-mm/Z226PG9t-Ih7fJDL@gourry-fedora-PF4VCD3F/T/#m2780e47df7f0962a79182502afc99843bb046205 > I've checked our CFMWS configurations using the information from this link and wrote them below. > This isn't exhaustive, but as I said with Rakie, I think your > configuration is probably ok - if slightly confusing. > I wonder if the below data is sufficient for your review in Rakies's email [1]. Please let me know. > What I'm going to guess is happening is you have 1 CFMWS per device that > do not have matching SRAT entries, and then the CFMWS covering these: > > > [ 0.009924] ACPI: SRAT: Node 2 PXM 6 [mem 0x2080000000-0x807fffffff] hotplug > > [ 0.009925] ACPI: SRAT: Node 3 PXM 7 [mem 0x64f80000000-0x6cf7fffffff] hotplug > > have interleave set up > In my understanding, both SRAT and CFMWS have the above device and interleave setup. Below are the SRAT entries (with some unnecessary lines removed) : [A128h 41256 001h] Subtable Type : 01 [Memory Affinity] [A12Ah 41258 004h] Proximity Domain : 00000006 [A130h 41264 008h] Base Address : 0000002080000000 [A138h 41272 008h] Address Length : 0000006000000000 Enabled : 1 Hot Pluggable : 1 ... [A150h 41296 001h] Subtable Type : 01 [Memory Affinity] [A152h 41298 004h] Proximity Domain : 00000007 [A158h 41304 008h] Base Address : 0000064F80000000 [A160h 41312 008h] Address Length : 0000008000000000 Enabled : 1 Hot Pluggable : 1 and below are the CFMWS configurations (with some unnecessary lines removed): [0A4h 0164 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [0ACh 0172 008h] Window base address : 0000002080000000 <- Memory region [0B4h 0180 008h] Window size : 0000032780000000 [0BCh 0188 001h] Interleave Members : 01 <-- 2-way interleave [0BDh 0189 001h] Interleave Arithmetic : 01 [0C8h 0200 004h] First Target : 00000043 <-- host bridge id [0CCh 0204 004h] Next Target : 00000053 <-- host bridge id ... [170h 0368 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] [178h 0376 008h] Window base address : 0000064F80000000 [180h 0384 008h] Window size : 0000033000000000 [188h 0392 001h] Interleave Members : 01 <-- 2-way interleave [189h 0393 001h] Interleave Arithmetic : 01 [194h 0404 004h] First Target : 00000143 <-- host bridge id [198h 0408 004h] Next Target : 00000153 <-- host bridge id [1] https://lore.kernel.org/linux-mm/Z87zpg3TLRReikgu@gourry-fedora-PF4VCD3F/ Best regards, Yunjeong