From: Gavin Shan <gshan@redhat.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, david@redhat.com,
osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org,
dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com
Subject: [PATCH v2 2/3] drivers/base/memory: Improve add_boot_memory_block()
Date: Tue, 11 Mar 2025 10:46:56 +1000 [thread overview]
Message-ID: <20250311004657.82985-3-gshan@redhat.com> (raw)
In-Reply-To: <20250311004657.82985-1-gshan@redhat.com>
It's unnecessary to count the present sections for the specified
block since the block will be added if any section in the block
is present. Besides, for_each_present_section_nr() can be reused
as Andrew Morton suggested.
Improve by using for_each_present_section_nr() and dropping the
unnecessary @section_count.
No functional changes intended.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
drivers/base/memory.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 348c5dbbfa68..f66e9d537c12 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -822,18 +822,17 @@ static int add_memory_block(unsigned long block_id, unsigned long state,
static int __init add_boot_memory_block(unsigned long base_section_nr)
{
- int section_count = 0;
unsigned long nr;
- for (nr = base_section_nr; nr < base_section_nr + sections_per_block;
- nr++)
- if (present_section_nr(nr))
- section_count++;
+ for_each_present_section_nr(base_section_nr, nr) {
+ if (nr >= (base_section_nr + sections_per_block))
+ break;
- if (section_count == 0)
- return 0;
- return add_memory_block(memory_block_id(base_section_nr),
- MEM_ONLINE, NULL, NULL);
+ return add_memory_block(memory_block_id(base_section_nr),
+ MEM_ONLINE, NULL, NULL);
+ }
+
+ return 0;
}
static int add_hotplug_memory_block(unsigned long block_id,
--
2.48.1
next prev parent reply other threads:[~2025-03-11 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 0:46 [PATCH v2 0/3] drivers/base/memory: Two cleanups Gavin Shan
2025-03-11 0:46 ` [PATCH v2 1/3] mm/sparse: Expose for_each_present_section_nr() Gavin Shan
2025-03-11 9:31 ` David Hildenbrand
2025-03-11 11:52 ` Gavin Shan
2025-03-11 15:26 ` Oscar Salvador
2025-03-11 23:37 ` Gavin Shan
2025-03-11 0:46 ` Gavin Shan [this message]
2025-03-11 9:34 ` [PATCH v2 2/3] drivers/base/memory: Improve add_boot_memory_block() David Hildenbrand
2025-03-11 15:24 ` Oscar Salvador
2025-03-11 0:46 ` [PATCH v2 3/3] drivers/base/memory: Correct the field name in the header Gavin Shan
2025-03-11 15:17 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311004657.82985-3-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox