From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Brendan Jackman <jackmanb@google.com>
Subject: [PATCH v4 02/12] selftests/mm: Skip uffd-stress if userfaultfd not available
Date: Tue, 11 Mar 2025 13:18:13 +0000 [thread overview]
Message-ID: <20250311-mm-selftests-v4-2-dec210a658f5@google.com> (raw)
In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com>
It's pretty obvious that the test wouldn't work if you don't have the
feature enabled. But, it's still useful to SKIP instead of failing so
the reader can immediately tell that this is the reason why.
Reviewed-by: Dev Jain <dev.jain@arm.com>
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
tools/testing/selftests/mm/uffd-stress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c
index 944d559ade21f255404eb38557660e54e81d46b8..91174e9425cde2500b459db78cb27adda6647b55 100644
--- a/tools/testing/selftests/mm/uffd-stress.c
+++ b/tools/testing/selftests/mm/uffd-stress.c
@@ -412,8 +412,8 @@ static void parse_test_type_arg(const char *raw_type)
* feature.
*/
- if (uffd_get_features(&features))
- err("failed to get available features");
+ if (uffd_get_features(&features) && errno == ENOENT)
+ ksft_exit_skip("failed to get available features (%d)\n", errno);
test_uffdio_wp = test_uffdio_wp &&
(features & UFFD_FEATURE_PAGEFAULT_FLAG_WP);
--
2.49.0.rc0.332.g42c0ae87b1-goog
next prev parent reply other threads:[~2025-03-11 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:18 [PATCH v4 00/12] selftests/mm: Some cleanups from trying to run them Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 01/12] selftests/mm: Report errno when things fail in gup_longterm Brendan Jackman
2025-03-11 13:18 ` Brendan Jackman [this message]
2025-03-11 13:18 ` [PATCH v4 03/12] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 04/12] selftests/mm/uffd: Rename nr_cpus -> nr_parallel Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 05/12] selftests/mm: Print some details when uffd-stress gets bad params Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 06/12] selftests/mm: Don't fail uffd-stress if too many CPUs Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 07/12] selftests/mm: Skip map_populate on weird filesystems Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 08/12] selftests/mm: Skip gup_longterm tests " Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 10/12] selftests/mm: Ensure uffd-wp-mremap gets pages of each size Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 11/12] selftests/mm: Skip mlock tests if nobody user can't read it Brendan Jackman
2025-03-11 13:18 ` [PATCH v4 12/12] selftests/mm/mlock: Print error on failure Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311-mm-selftests-v4-2-dec210a658f5@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox