From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B83C282DE for ; Mon, 10 Mar 2025 16:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D214D280005; Mon, 10 Mar 2025 12:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF67280004; Mon, 10 Mar 2025 12:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7159280005; Mon, 10 Mar 2025 12:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8FFEB280004 for ; Mon, 10 Mar 2025 12:18:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6AA53812A6 for ; Mon, 10 Mar 2025 16:18:04 +0000 (UTC) X-FDA: 83206148088.17.7768D1C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id C4CD140006 for ; Mon, 10 Mar 2025 16:18:02 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lybZ1lzJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741623482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x9suYFaOq6zi/9CGdBQMifylaI3cHawL54Zce3fuTtw=; b=cvGPBUO3/TWV6BAr7A8QofAGp93Aan5sHd/kSLJ1NR26DzxUaNfdHlGGmgZ5Eq2TB3xOec rIm9Q806l/Hhss5E3QOPAXGQ1q6wNa+IWpBSd4D8HS7+IQuBwygT4n1OjH2+47MfUcHCPv FxXuWbHXqRw4UUzwWuf3f5PJ0bNDdQI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741623482; a=rsa-sha256; cv=none; b=dEOm82ib75C2TBgezUSLSkbIBSQuMfpmBxr6FnDkkeYKiL4pLXvsuKnC4HgBge5J7EmqhI HsEAjRJbc1HSs3YgojW9Bs0qnAVUNUg7jQ+AU3bdHixnjDPyG8qPDoCdlvpGB4OkbW52u6 7bmVu5nAvOBsIT/+IYk8duC4uDWKW2U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lybZ1lzJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C26BBA40FBE; Mon, 10 Mar 2025 16:12:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 797DEC4CEE5; Mon, 10 Mar 2025 16:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741623481; bh=vq8ygBaZQ4+MXV/G1y5C9vDL0QOR/iHg4KIzBe0wSdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lybZ1lzJ1UWUQ+Fc95kJ/jhbkAY6gbiJIDrAM4I0jGXoM8p83jI91Exwra0bZ6grM Nfs0HAtcT57d5YMr3cERPy9ACb+1LIbuey7cyNhcPhPhetI51NKDV5qvcHZ5+gf3QF RA+b0BY7jmSvGG5aRNcL2xFLqLv1mRg0K1pyP/+Ow9k+ImO17zjhJrwEgMgS0E5/Xa Vkt3fXSfyhdDNXeLPAFJ3AVT+/9ILHcugkQmn08oDXbovUmuGQcbkB+mIC5o+wK6Wx lAlthK2NmkIxRChEd4v+gAMRPWq0oiUvqAAdmQw2KgwxYWc0oXkeMvFR6brxdWIxfA EeJZNwczHvr3Q== From: SeongJae Park To: Arnd Bergmann Cc: SeongJae Park , Andrew Morton , Arnd Bergmann , Hyeongtak Ji , Honggyu Kim , Usama Arif , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs-schemes: avoid Wformat-security warning Date: Mon, 10 Mar 2025 09:17:58 -0700 Message-Id: <20250310161758.606151-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250310135142.4176976-1-arnd@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: C4CD140006 X-Rspamd-Server: rspam08 X-Stat-Signature: 8qjts65ea49jh8tkdxqcbbgcei8zfwm8 X-HE-Tag: 1741623482-178533 X-HE-Meta: U2FsdGVkX1+g2cpIvAlQLxzF/rRJ5wnnmUfIFMgKL4CNccDWSsohITCVXm1T+D+xAvfXA0fmE/GekfkUpA3EwgAS/3qkjmrk3Kqw173YP2Zo4qjp0KXIt+FJXp1FgaMKvpuqeTbiNq80wBUtlfXx+OobnVv592JguwT9OEgNa9NaaaYPyuwSQpgAtFUULyWWmCjeY5cxgtshg9q5HkqmiJTYqhg/sFfr+VtDkJNhBvxg4IXyc/xwdKD/TKUwX1WYv2z9xyc2g+CNitHGR1khvnxwdIF+gd1z6tv+3YaEFCWoWdNb8VNqgPWLcA2Eilb2sCQZXm8XyJgwSzF7zY0r6rnKZzFzEKrgfmI9M0H/63WNVvLvTZ91e/dqicvG4VBqFnmRW0dCbaNZ8W9RwZhAQ7EB/BCYGU43JOdA0oGIlYb5Tlzz38PPbjC57WT84VLPH/+YtlFe8eslWFgNk41ZYOK1yHomQbf+cehqyqvVlu0aOWMn3oxJVJcRHiiIm5Icn1ve6MCG/6wipsL46PSnYJT0N3X23yU3135wM+8tj9bFzsKjW8kXZA+8nwLpazWa99AFl7PwOnwVNaS9V82VEPNbMl+J+XovS32Kz+zwxjH2mRLZiCj+1qrBrFOmMRp4W+nAGZnPg/+4ZsQLW9VcC6D4t7CacWTCYCmD7woLaJ7vb32fvM+ZhzWXJuu3nqbFSFzo3IkaE5aM2oe9FhsRj5SmekrX1IeZjuDTeb0vanGZkjBFFP0qpQEe8xINAmOLUOdpFYsqaqOLlNLmNy6/fGMEXUbMuzKVxi4acyizyDC9Rlcpjts9CYTSzOUDZX9eEn1eH9sX2+uKpi6ELM42a8oO1vg0fdFI66dS8jedrwkTduayqUegCl4+hXmdnEInmNg5MCAY7SoCG1TGdUKLcjeJs/3ATbB72eP7h/12lL/yo2icAmT9hPp+Ka+Ki3DfxTH/SCjM+cg/VjoCskq RBfYCQF2 MYym1t1tcTaILZuoDoxwJVDd/E6IeszH3savHFqgcbxhm2yGmRX0mXehAPKOc+8B2ga2800ny/rblDzr4KWTq4v0sD5bCFhMd91EZYppXKBnlBKpZELyYgf4Qgw5vt2IWz+K9AfX3+kQfwJYBTx3136xxC1kSzKYJtREyOGklApqNn7kpQhvvK/1lH6aGZxea1DFeHbrTpQZ33setfH6W4XdprTtTA8xKMd/Tk5fYvbiOQU0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 10 Mar 2025 14:51:37 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > This warning is for potentially user-defined format strings: > > mm/damon/sysfs-schemes.c:1664:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > 1664 | name); > > Change this to use "%s" as the format and the name as the argument. Thank you for this patch! > > Fixes: 92bc039dd72e ("mm/damon/sysfs-schemes: let damon_sysfs_scheme_set_filters() be used for different named directories") > Signed-off-by: Arnd Bergmann Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs-schemes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 50e6907515e6..23ac98dd6451 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -1661,7 +1661,7 @@ static int damon_sysfs_scheme_set_filters(struct damon_sysfs_scheme *scheme, > return -ENOMEM; > err = kobject_init_and_add(&filters->kobj, > &damon_sysfs_scheme_filters_ktype, &scheme->kobj, > - name); > + "%s", name); > if (err) > kobject_put(&filters->kobj); > else > -- > 2.39.5