From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CEBC28B2E for ; Mon, 10 Mar 2025 12:44:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89438280002; Mon, 10 Mar 2025 08:44:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840C6280001; Mon, 10 Mar 2025 08:44:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E390280002; Mon, 10 Mar 2025 08:44:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4F1ED280001 for ; Mon, 10 Mar 2025 08:44:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6F2F7B7364 for ; Mon, 10 Mar 2025 12:44:24 +0000 (UTC) X-FDA: 83205609648.13.E82686F Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf13.hostedemail.com (Postfix) with ESMTP id 254B120003 for ; Mon, 10 Mar 2025 12:44:21 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741610662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXgEuvBpeVSYxC5HkiCmY0pKcMEX2DmcWWVrsIpgGXg=; b=lXFpi9yqBJbqEQ6v6oMIAETdFZ/00jsRcAehedSqd/gvm/56R3WNURnEnU7u+uOygcifir W8QOxGIyepP4Jyk+cTrwyXFCbL0j22I3GuWOXFdwO3/5rYGr2cfVffc0JyFNR3xaa81qHs gJIv6Y3LWLTh0xMX5hF5COeS7Z+hwIc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741610662; a=rsa-sha256; cv=none; b=MRPA0+lEf0shp2nzYBiLD3/rG8fssz7u2VlU6olHXlUqENDLcFx5i1Bq0QTPRXMPi3MEky 3F5Nenun1+Ujhp01a9FZpvokIwTfMd/7BmlVC8DUXM8o2rVlWlNY6InwBL62rvFegpeO/H ythebW7ZbLeFDzdjw/qZEDG4miOncDI= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZBGj534jzz67Ldy; Mon, 10 Mar 2025 20:41:13 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id AC6691405E3; Mon, 10 Mar 2025 20:44:18 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 10 Mar 2025 13:44:17 +0100 Date: Mon, 10 Mar 2025 12:44:15 +0000 From: Jonathan Cameron To: Shiju Jose , "dferguson@amperecomputing.com" CC: "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "linux-cxl@vger.kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: Re: [PATCH v2 2/3] ACPI:RAS2: Add ACPI RAS2 driver Message-ID: <20250310124415.0000710a@huawei.com> In-Reply-To: References: <20250305180225.1226-1-shiju.jose@huawei.com> <20250305180225.1226-3-shiju.jose@huawei.com> <20250306171925.00002721@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100012.china.huawei.com (7.191.174.184) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspam-User: X-Rspamd-Queue-Id: 254B120003 X-Stat-Signature: gh5i8eqn37abqkoheihidwjbtxgb6w5u X-Rspamd-Server: rspam09 X-HE-Tag: 1741610661-783713 X-HE-Meta: U2FsdGVkX18lmCpyEXDUXWDGagnxyMXWy16CR7hxrCVSx3pbe3QlbhUf+qL2oqVXxliXJca+PYg6ICEL77kSBC6oPE8kWug0SSv1VamMMMQSsCjbT40ogW8DnBkwIQZ0bhdby/+3rS1Jh6hS67OIqBD2ywuH55EZiiFI2Iom6n2vjU1D+p09yeHwu6uWGDlvaeCnKpzyPuYujHfTyuVl7eJ6gGQPeQzKlpJXLpFeD8i2w0XOORn/M/VQHTVRsia3EdAYOPYlx0HOK6rseBYmeN02n5KkHJ4VDqF80pWlN+OyQZOORs5lspiDytbUS0t0RosjU6P6Lg01JcBoNtOjeXBFspOohltfeLznddf8yWi2E7EyGB4N8pugLMevdPkVZXT9OdwBuOjGSs6FulsuJzwQk/77fjgdXMqu/vxZRfnxWdx1yV9EuMQ1/Wl6e74qkO+7HztMoQYLEVlA2ymRb6bNZXPtx43cqGt7wLZheM58yKW2lNjoqspROl0SiAhNRyiSXQM4rnKivMLQX9QNTrykbnFpQg/HEiN5ELN66BQ4mRWPA8RqS8oi0vVY2ovaIZ6cfPAMMcIWSELXdfNsdY1kKq0laHon7TG1JLhHErJ8k25oJXc/T0WfHMkUXkwk2TwUb7aTY1MeIULGmk2fyQHg2AL9xOGVPWMAkhaUy3NSsf14/lOUEAXQPuc25ciM1kz+X5OlV4bMZt6tWo5YS3+Q+tC95x4iVX1qgClV4wrdynaVinXBGXjBgZ8AsAEAN6LZWnR9bwS78ngq4xXwQWZ8J/KbizqMi1+6eEKCoDr1jaTeZA/C0hk1RinklySM8nqK1Zxa6SmA/X//zWY2M3dqZgemZ2IphAjSXMetGDJXfpUTCWmfwt7ujR0/Sw6NMVBDzY/xjInrAUx/5wHCvMNrOlol1Gxsw/gmo3OroOBOtFLTQBGdJ+6e7hnOy+BvWOpwxKmC4ARwAxuxiyt 4Uaiaj+c 6XWDRn4u4+OtU5Xa1TB+f9lcsA6SfCuWInBG7lmduy5nGsFb3KfMQcP/8bOz5blWsN6VZceECZRKzcA9P/z6AAbREjiZsArbvwwXg7/PgkB4xRONEI3MP8tG3J4w9x8BpUhmb+F6L4fUnkymuCfRb93ujAqLZtvJ0RtndkjtpUDuUT1aaw3q7/qNwAr5BZIyQUQIhLC7R86eBK7Iy71ji01aPat68mNxd3QDE5SVpKyyieHhfntflnZ/G202EGD3PTINRIUZOFbYHhjhWEYmFct0ndA4jke/awKnY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > >> +#define RAS2_PCC_CMD_COMPLETE BIT(0) > >> +#define RAS2_PCC_CMD_ERROR BIT(2) > >> + > >I think these bits are from table 14.11 and > >generic to all PCC status registers? Should these > >have more generic names rather than ras2 specific ones? > Yes. > Instead will use PCC_STATUS_CMD_ COMPLETE and PCC_STATUS_ ERROR > from include/acpi/pcc.h. > > > > >> +/* RAS2 specific PCC commands */ > >> +#define RAS2_PCC_CMD_EXEC 0x01 > >Are we mixing commands and field definitions both > >with prefix RAS2_PCC_CMD_ ? That is somewhat > >confusing. > Will add Table 5.82: .. here in the comment and > Is rename to PCC_CMD_ EXEC_RAS2 better? That seems OK to me. For things you agree with feel free to just crop out that bit of the email so it is easier to spot the remaining questions. Thanks, Jonathan