From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F3EC282DE for ; Mon, 10 Mar 2025 09:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 863E7280002; Mon, 10 Mar 2025 05:51:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 813A8280001; Mon, 10 Mar 2025 05:51:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B626280002; Mon, 10 Mar 2025 05:51:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4DA3C280001 for ; Mon, 10 Mar 2025 05:51:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 15A2EB7A48 for ; Mon, 10 Mar 2025 09:51:38 +0000 (UTC) X-FDA: 83205174276.24.4A7B40C Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf23.hostedemail.com (Postfix) with ESMTP id D0628140008 for ; Mon, 10 Mar 2025 09:51:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IyvS0WwS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741600295; a=rsa-sha256; cv=none; b=gAs/FmcuJZOBCJ08teI5+BCTB5oFTI9SBdQhSbSdZvKgvItX8dEZiJdEr//GzttaTKcJ6K A2JS4JvmdyOJh/f0i4fwfkGL4W8nRN19ZKAqEBfm/fLtMLYVqoUqLxnTn/eAlHnrcyx7t3 XxQtoYkbNKhzcefvhrffIYXIE1FUEC4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IyvS0WwS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741600295; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7fIk/wLn8siLSomZZskx1hmM4iyC641S3xGJlKKijlM=; b=oekwGCSbi6qTVN/j4madD5WCVFjZjJkGuTSMId29maVg1mBAUacFBzp6f2DMGghzZ16IWF iFBwlV1G28f70zRMzrgVLYNFRzkAQJMJbbe+j0JGxRCOktyDuScrhJq2WjCiNLu4EvdfBo XdKHDD5jyB6BtN4metB8GvR+crpojIc= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ac2ae81dd81so53665366b.0 for ; Mon, 10 Mar 2025 02:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741600294; x=1742205094; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7fIk/wLn8siLSomZZskx1hmM4iyC641S3xGJlKKijlM=; b=IyvS0WwSc1JOkmz/rnuxGtXbnDW/m0FHeVoVB+Qg2+pkYCFmIrdQkdsHluhb0egdgp 7eS/brdjIHiS6l3/tWOej7AlupYkxOWN6vkhCBE43abo57qQhDXJUzv/z+X7IjHSpgjx GuqFzjju6cG894oZYVhgm/KxJCz/WX7GfuUt3ITwH+4O6rn/M+yoKaEGO1p+CK8ykOW3 J0nNBnUQ6svFEj+/amYaQRpEqj9I53/z+UOAHTmLfu1m7NdW/qMt42qKiIsIcVa+O4VE F8xgF6yqjX35euo5a6Gh0OGd2YdvcrGmTFplhpNSs8QRy5JpshS8Y4OlcF8scetYepAz xwxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741600294; x=1742205094; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7fIk/wLn8siLSomZZskx1hmM4iyC641S3xGJlKKijlM=; b=J8ntbMdFJ8ViqK1HYutpRA18i32wkJLiQij/2Kl/JZotEJLCUIpnN51TzII475yyq0 NdQBd+A3Nilq1xBAAuvyIZs9bsKHxK8wJ90zXLlAwrS/R8s8CNGxb5D6rhPwHlcB4rnI UkE525RFFDMfRiH2TE/efYTxdlJbdcCQmhPsiTvtxwZ3RYu5bFvUF93RjEQkEWoLUux7 nmD51n7NkMj89JbeKbpPSyvL1SthWWh6pDkw0bcXKaHcvpxskbtomEsvbINju527GJPh DO8jwn6KI3PVB/nSGKLLqtasIxjhmazkCD5kBv40Nc+A5q3VDf3bVYJyvs5/mVRvV+p/ kwbQ== X-Forwarded-Encrypted: i=1; AJvYcCVU+nnOl8iY0UlFUYbwKUBPNg+MjAO8idXbBhg7tEybxDhT8XVoTn8C808GnW5kgVWZJUk5v2ICRw==@kvack.org X-Gm-Message-State: AOJu0YxPp2mwK1Nb2Zj7AKsEG6p5RxvScxCn5FxhJfO7dk5MVWMAXDMh DAh/D/QPXuMWJ+auo1gDYBI08x4pXl/CH36URqT5sexdvHBYacRn X-Gm-Gg: ASbGncsvaLEp94BDXwHw9AUpmtzZOMvqD7ha/OdybOKod7MIvDwoLzEoFCn3mghXRo7 sWpL5AU8trU0V04gMRhkGSc+2GZv12KpSSM5KfRfaqKciEswJA+syZ7pR1umJwFwmk8eAJ4E0nn ym3eExoFd7alGVzPHXMzJqmHO6itIBCVcqKj3Ppcl/RVyjzB33DTM5GjSaZAgfbAkUxeCBgl/kI +Vd6Mkr1ngfuGW8nPWUapf+UlyBg8LEcbc843Y6j+KZmh4z6J1SwskoYH35r+IbHzkNcq1Gi6MB XZJOMyOVyHJZ8E1/3ti7HDfsY3IpeWXfH7Q+uqLLxMZiHly7/qc8qKw= X-Google-Smtp-Source: AGHT+IEnsaBC89bibOD1BqC+ZZ1kovv3JGu+umNRENY/jx8wzQl9KTymklI/3Rp6DH54iA+FTxPRUw== X-Received: by 2002:a17:907:3f2a:b0:abf:5fa3:cf96 with SMTP id a640c23a62f3a-ac252a879d7mr1234111666b.14.1741600293920; Mon, 10 Mar 2025 02:51:33 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac255589a30sm594247266b.107.2025.03.10.02.51.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 02:51:25 -0700 (PDT) Date: Mon, 10 Mar 2025 09:51:24 +0000 From: Wei Yang To: Wei Yang Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag Message-ID: <20250310095124.pa7dwgqhxglqrfes@master> Reply-To: Wei Yang References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-3-rppt@kernel.org> <20250218155004.n53fcuj2lrl5rxll@master> <20250223002229.xuk6xlp23zr72hkc@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250223002229.xuk6xlp23zr72hkc@master> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: D0628140008 X-Stat-Signature: sazoosqebt71qmxw5wyzcyj7mxejwdqc X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1741600295-978396 X-HE-Meta: U2FsdGVkX18MeOGTc1+lo6ZeaCH+v5m5QAWNcwGX8yk/imJwnG1p61TfhI9Devup6gbn4As8h8QX5DXOWPuMTCaSP4VexkAo4siiJIrEZjoalXheUsg1lsSsVhLpcBwMVcYGHUsIL2BRXz6/d3x3g+LR2rXeJgKUOkAx5g6SbIe+iECPmOKUpQwFwFNLODLFMB1lT5FRkRjdlvr98uNvZx9nWrhu/pCy5C/r2Lik6Jt5GKvgkBdUKMNsPuPOGNJAUiA4JcgdtZm+HsdUMdcZNVrrmFLp3lRkNphunc6w6ffUys81VjbSBG/+oIKGEm8As1Yj389eNbTSJngEVRwPepl0Th0WLoePjnXs0Qybb1zeLI6TAjOwtYnle/52tD0D/Aq2F31psEFao/kZOtwTMqALgb0X0q0NkxOCr0OOJWaHZMA7tqeQ0I6srRxrMya90ht58qVwF2YaUpAsVrI65ueHp/aE2sUm/YX9Lufgxq/JhHf0chv0oj3GehKomA8hGT15BrQjGMJuXgDxC1kTA5IBT3sKqSw1gBM1gG6K+28MHyF8hEotJqYbkBl7heJuhJca9fgZB0+KIUzdadWuLSl8r3rDQpJw0qEOtVq/dPuKNxs793TbjGcJT3a9IDfy0l2C6aDAyuK+THM09Crc7426FZ/jFIhDN9+RsVKxKYwNjbjWqJqtkGq8UryG3iKnn8oW64Vra/L2yPWTK8+qaZT9K58/hlL1fZmRNNoZB6VCDbZjL0kQ6GUYR+2ce3nRS0bFzjQcuaufMgnqcPLLOYH4qB/RzHIlje9SrldExhtTNdemRxQz2YJhJTGwVvMfTNYYr1xofQMbuQwvi7n9BTEKcmADz8m+Bzdqq0gdiQeJWZjijHW60rtHBQZxzUebpjB5av9+bxH+20kzW5UXK9ynhgF1D+jHEd/Lmduwe47U2OLiuxWApgyGYkLcUoHS8nDKY2bXhaV0I/pqLJX Z+TEWIJc BrbfmQnQBUQPcZ6gS/PY6jTYpdKuY7DUcmViepi9j6XPYUC5+MycXxLfdm00pEPZbMDT8ejojBfXov6Pn2cCVmzmnDID0aYD1Ln6hRyC9Ag4VH5azYxdNtdatu5rrlADl4R1nCjdfGd5TbE4IH95KEJ/wAS5UJrQ2HG7U6/kdPgcqX0KGnfadCijU604HBLgcAoXj0tL26i4IYCkQU+MgYSn1D0ZKrpUZ8Qr6WIQe26XsxbiW6+UW53JiP0ycq1ivHvU9Y1T6jsrW08so8Y8A9LtOXwB8ru+wneeiD0XTvhwQhcw8JLAYdFGWMiPSmp4vKeq1lyf/Rbh/vVQdbMWWIN5oo3tyvU6YakWLz1DyKDfaXfwekEXyeQW0/fIsU/dHt6jI9EKKpUc+cGhIOahRqmwjRCUWWpMuZyKEQ+ToWe8Br0Lq083bG/zcHvmR7rzHMvhgHAsHcAltS+lx4KXk7rLTnYZSPz5JDCzElK5FxDifLbpbjB5eq4DELtS6vQVi/wBYbtgPViqLVScGlrBbyBG8VEoPuqNVG0EOgh7up0JUexNzceX0eQns6nMGADEq2lhCSa0rk9/xdanWVx84N7TxYTYlarisMEuY7diPcRNxJ3/bXdtvhkY2uKyTduG4kKMa8G6GFaUYRiKOqvhJskFdDeE12Xo/aiBS0KrJIZBjTlDQP0tkdaZf4YYpSQcn/VZf4aCNZN4QPevoBLBMhjL2gvrZnCLDpN8SVSCUuf7YApTo3F5Z62erqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 23, 2025 at 12:22:29AM +0000, Wei Yang wrote: >On Wed, Feb 19, 2025 at 09:24:31AM +0200, Mike Rapoport wrote: >>Hi, >> >>On Tue, Feb 18, 2025 at 03:50:04PM +0000, Wei Yang wrote: >>> On Thu, Feb 06, 2025 at 03:27:42PM +0200, Mike Rapoport wrote: >>> >From: "Mike Rapoport (Microsoft)" >>> > >>> >to denote areas that were reserved for kernel use either directly with >>> >memblock_reserve_kern() or via memblock allocations. >>> > >>> >Signed-off-by: Mike Rapoport (Microsoft) >>> >--- >>> > include/linux/memblock.h | 16 +++++++++++++++- >>> > mm/memblock.c | 32 ++++++++++++++++++++++++-------- >>> > 2 files changed, 39 insertions(+), 9 deletions(-) >>> > >>> >diff --git a/include/linux/memblock.h b/include/linux/memblock.h >>> >index e79eb6ac516f..65e274550f5d 100644 >>> >--- a/include/linux/memblock.h >>> >+++ b/include/linux/memblock.h >>> >@@ -50,6 +50,7 @@ enum memblock_flags { >>> > MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ >>> > MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ >>> > MEMBLOCK_RSRV_NOINIT = 0x10, /* don't initialize struct pages */ >>> >+ MEMBLOCK_RSRV_KERN = 0x20, /* memory reserved for kernel use */ >>> >>> Above memblock_flags, there are comments on explaining those flags. >>> >>> Seems we miss it for MEMBLOCK_RSRV_KERN. >> >>Right, thanks! >> >>> > >>> > #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP >>> >@@ -1459,14 +1460,14 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, >>> > again: >>> > found = memblock_find_in_range_node(size, align, start, end, nid, >>> > flags); >>> >- if (found && !memblock_reserve(found, size)) >>> >+ if (found && !__memblock_reserve(found, size, nid, MEMBLOCK_RSRV_KERN)) >>> >>> Maybe we could use memblock_reserve_kern() directly. If my understanding is >>> correct, the reserved region's nid is not used. >> >>We use nid of reserved regions in reserve_bootmem_region() (commit >>61167ad5fecd ("mm: pass nid to reserve_bootmem_region()")) but KHO needs to >>know the distribution of reserved memory among the nodes before >>memmap_init_reserved_pages(). >> > >I took another look into this commit. There maybe a very corner case in which >will leave a reserved region with no nid set. > >memmap_init_reserved_pages() > for_each_mem_region() { > ... > memblock_set_node(start, end, &memblock.reserved, nid); > } > >We leverage the iteration here to set nid to all regions in memblock.reserved. >But memblock_set_node() may call memblock_double_array() to expand the array, >which may get a range before current start. So we would miss to set the >correct nid to the new reserved region. > >I have tried to create a case in memblock test. This would happen when there >are 126 memblock.reserved regions. And the last region is across the last two >node. > >One way to fix this is compare type->max in memblock_set_node(). Then check >this return value in memmap_init_reserved_pages(). If we found the size >changes, repeat the iteration. > >But this is a very trivial one, not sure it worth fix. > Hi, Mike I have done a user space test which shows we may have a chance to leave a region with non-nid set. Not sure you are ok with my approach of fixing. -- Wei Yang Help you, Help me