From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBFBC282DE for ; Mon, 10 Mar 2025 09:42:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32BA9280002; Mon, 10 Mar 2025 05:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DCC1280001; Mon, 10 Mar 2025 05:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17C0C280002; Mon, 10 Mar 2025 05:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF1BB280001 for ; Mon, 10 Mar 2025 05:42:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9277A92C9 for ; Mon, 10 Mar 2025 09:42:45 +0000 (UTC) X-FDA: 83205151890.04.3F256F3 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf07.hostedemail.com (Postfix) with ESMTP id A13E340006 for ; Mon, 10 Mar 2025 09:42:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jdLc/6IW"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741599763; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tMClGTb/xowiN+wUj5f6h9i/suU0YoMn0juoJl6ktWM=; b=ZE+P/aeZbYmwgKYKMcOTV9g0wr5w7g/42jyu97CmZqCfSeFIL9q1wcuP0SVfqbtxzzaLiF n1aXmq7upwHoGRtz8oTcRdji3blHLRZ9m94yEueKx+RTTveJCV13PIyU+dOH4gohC3YmoD 3WaeahmYmmB20vCWUzkPg3QLYu+tn/4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741599763; a=rsa-sha256; cv=none; b=Jle9wWncNXjJ+XSKNVt4DpsAYRrJwONM3Qy1W1kjaf48vMtaYqbyDwYp5E9B07T2jQyoqH YzvBNTT2YjA5VTyshmnki4vmF57wT1vq/iaTV0ab7TG0pkSf1aa5gjHfJEA/H7J8NB7m7J Pdm5L/JuvK/yxnHGQBbqYxZDEUsMZyI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jdLc/6IW"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ac2902f7c2aso178992966b.1 for ; Mon, 10 Mar 2025 02:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741599762; x=1742204562; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tMClGTb/xowiN+wUj5f6h9i/suU0YoMn0juoJl6ktWM=; b=jdLc/6IWwvPQEAu0dLMmJihjyq3zvgWr85k1B9CGZ3EPSal1jKB5TbB2TiykdzKvao kDm95cAZaQIn6UeRvNugoTDsMbcdolQ0m6r08+e2gyyMpo0LZhaWraXh8FNXME5Wkq1u tbohmXxeFkrvstHYB33nM6uE2Huh9+W/+S7s9YXCOKzvSyRkorfaVu6oDqoRssBo8Tre HJUHCpyZ0giPYAS0nlbWMx1AIds83KjanGA/DNuoF9uDKycyVNRF+Skae/hXhjgKpvn2 p06dWmHTtqgh+k9cPls0fW4GUveQEsg9fALDawwhajZ0fEpNYbevkgOz8lVQ5V9Tn8bm bxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741599762; x=1742204562; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tMClGTb/xowiN+wUj5f6h9i/suU0YoMn0juoJl6ktWM=; b=AR++zw1aTUFXPbU7RjYw/yztN8ViPKqNmBlp0fkTqvD7gTZVpY80XmOqpEgHgp2lhR i2QrnQUQ56d8XQTV9mNwNdXLVn8VtgG8O315aQ5rcBdIdJTQyQsdyJfvrMa3TFiz9+H2 PIieZpcpZVmOdIqwMQnBlk1iO++riSK2bGAelwYOqpnwSblaRjCLbbpwGMn9LTt7Hl9O MeciR/YsDPKeW5T/QZeSO2rEva78eKm1K/XXyZDPi0j2UK8r8Hmf2O4XUUZWBeBvJujK 8BH54QgW3Tudw8hvBnAU84EgC1mkAB1VGsHAG3eyA1pzKBcidGZnniY0wIn27k2Toh18 7JHA== X-Forwarded-Encrypted: i=1; AJvYcCXOV4DRHDs90DkcUjJ+mVw2BpPx5JC8U1xlODaj9M5TDqnyZKf6q9eCPzyC6gEVfescTl3+4hTo2g==@kvack.org X-Gm-Message-State: AOJu0YyEMtMi6b7Uw/AEyVfAIEGsuBTXErqidAe8pW3ah6YehEiQYvQy Ht4Y/PyQD4rkwbx3jpN0IwYpyJzXsFn7LnHWg7LVi+DrGO1Pr/c3 X-Gm-Gg: ASbGnctcfqCrg1po6XfZqAznwrnMwa3sl51MzReSpr+ZvfFEwqg+dHo0aUYUSdla/oH Cvll7rJsHwhlwiXmJeP7HqXtvIMYwoxibzMS0PFhHNhazNWVggm8j4UdB82SCSxOhattg/U4TxU 8qOaGtGs8ufiMNk2d2Mrp+ug1RWHMR5jKhf0SLDEUmXWY5PNgkHexN8Uloc4SmfCPu1T/efGLCl CyLXzSLfChySN1BpfboToPUyP+XceugrHvuEIfQAvL4ijrxocwHfHC3KfOqejUkzEBbm00cgIHX l/N8SAWR83JwCaleFkIv9ZKMaFE6RD8apy8cQtI27Z2S X-Google-Smtp-Source: AGHT+IGr1BXamH0TMzryWGEFJPRvklcDIRXonoj2fHuOVeIPkUnC7Qwd3/v9Pu02iEAlM/2ZB1tn9g== X-Received: by 2002:a17:907:3f96:b0:abf:62a4:14ef with SMTP id a640c23a62f3a-ac25274a051mr1561659766b.9.1741599761642; Mon, 10 Mar 2025 02:42:41 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac2b0daaa0asm28863966b.38.2025.03.10.02.42.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 02:42:40 -0700 (PDT) Date: Mon, 10 Mar 2025 09:42:38 +0000 From: Wei Yang To: Mike Rapoport Cc: Wei Yang , linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag Message-ID: <20250310094238.lgsiyqci3aqdzrhj@master> Reply-To: Wei Yang References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-3-rppt@kernel.org> <20250218155004.n53fcuj2lrl5rxll@master> <20250224013131.fzz552bn7fs64umq@master> <20250226020915.ytxusrrl7rv4g64l@master> <20250310075627.5hettrn2j2ien5bj@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: A13E340006 X-Rspamd-Server: rspam08 X-Stat-Signature: 9gsszkugd9x5geusp37na9dqehh74zum X-HE-Tag: 1741599763-786473 X-HE-Meta: U2FsdGVkX1+W3NPCnfmz7CN2VVmqb/ECb8spj7ZPlnR9JuO0jGJvMUaSYF6Qd6XbuALFV9thcnLg6IpkxON9u+rBfasuoZXxyqm7VE6+qJjN0Mcb5QssSgNybMpyX4UKGeN5bOJrntJs7QDqZyEXsnDWWHEWBn716drBHpP52y6R6KVJmicoRKX6kcnxLtIVN65qUABHOY6aX15lSYCEuuNO0c4UVRNfD6pnhNZzPzCg9x3B28GsXF+HOcSlFtzNOAeLg0fPi+d+EgRhoT+T1F2Tk/xkoKT5Dqt+NxNXTC1Uvdl1MJSNiMVGFA1iYA0EEuVA85xI2Xgo0iKoPfX6b1of3JrQOpUR4kLVcGFMoiTLIr55QAoAYewYA7A9MR3qTUnvsEz1zcY+/seIixopspxX8Npx3wZn1/45w0G2km2u0XmXIVRDd/DPo9no3qXHQlfooZw8CzSWilXLcUXLxysqsG5eXn11z09ht5HA8KHXTQaT+SmCA97IbeedyTNU+FVCQ742jTygGcdt7lYce8MlTSLQaAuneIs/x9WKikfTvQCnyxFLN8T77Ki4uLwrkPLaR1wGb9bLjn8WKMT25047PIVbWNLgQKCLXYnPpzD0eNGDHp9jf08TfNkjLauLPisfa34sc82WBRVctkE4Ds50ztmz0BwlOnr4LNhA+qZ8+3/kYV1uqexwnZ5LaLQkhgCcq67ImlRv57xIG1nEPgekbUqEzm6BktZZ5tshPtY6XETRa+DrTDNt33sMmjSRx/Ud0VV80zrsZ8nPmTOQSKGUrFEpwGBCkzmFMsEVBnKr2r0sLyf0K13inuFVTvu+3Ed+YoTUhSE2vemnlmCX3PKHhnZ/yh7ttfLIcj9a7xsBMA5rhUUuTHRqBA7S/CNLDyFbAa/0+rhZZYs5TpqgQaKIsa52nCqmzSdWJxjZLPXkBej5QjtFaqKdhllhCmTJQIyDxm/gEQPD9bGHJ/L shV7i0nx 2OhJddcbdEXx5LkAYdb89jAIEumtXXB+mMyN/UsdckqiQqV9+tJn6sEOmDiPk5qfzxA+Bv3HNcg2YS4a8jAKMfMO7AOOleEBYjq3A2S/IFp8httpjziYnItkxtXxKbajVCPUVnVruWuL9xY5yJfk5cBe6HK34ymBULHwP4OuxI7AF0xgeV7JVhyQK6nfLkULXcOKczrDK6rWAQsRYQE/P98IPnqSW8q4GAHX1CbY4Pby+xtsnH1IJn34UgKlbzsvvocw7lQa1FH+9LnWxIITk/TnffeEo/PqmwTw9xHc9eOblWt3Qzn+t4/Hi3qSPPVoPaMUP/+y+drszHoYlBE8vjfjP94hPplVduJ8VCVU6aAVW/E9XUrqCrDwxpl5CTCoJlx+56t9MC70Z8k8mwMx8Q71NHRopVSyYx/iccb5nWSCKd7RUPeHPC1MMA02NhfSqxWrYWcfrAXojD90JeoUeFNjYHkN6c9Dps0Eln35KAiIl6IVuQwHhf2F12IbT3nuXhPPS/IiyqSTElI68vOU89SRDB7vGFJ6jGkKkir9gyrtWdfDOb8OjXMgzn5LHMChQL71s1OQtLbHoTsHQqexWyiyuYrKESDaYGUYqDeUoJ+Qpyie4i0npB8nVrVKiykGkaXoRmL0ZRMNq5ng3ustXXGz3J5zPRui42Z+5aWPL9m4Y1xpadGvOJWYFx57ryS+KzkwDrnlSNhcd/9BTchdXR5DiJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 10:28:02AM +0200, Mike Rapoport wrote: >Hi Wei, > >On Mon, Mar 10, 2025 at 07:56:27AM +0000, Wei Yang wrote: >> On Wed, Feb 26, 2025 at 02:09:15AM +0000, Wei Yang wrote: >> >>> >> >>> From the above call flow and background, there are three cases when >> >>> memblock_alloc_range_nid() would be called: >> >>> >> >>> * If it is called before (1), memblock.reserved's nid would be adjusted correctly. >> >>> * If it is called after (2), we don't touch memblock.reserved. >> >>> * If it happens between (1) and (2), it looks would break the consistency of >> >>> nid information in memblock.reserved. Because when we use >> >>> memblock_reserve_kern(), NUMA_NO_NODE would be stored in region. >> >>> >> >>> So my question is if the third case happens, would it introduce a bug? If it >> >>> won't happen, seems we don't need to specify the nid here? >> >> >> >>We don't really care about proper assignment of nodes between (1) and (2) >> >>from one side and the third case does not happen on the other side. Nothing >> >>should call membloc_alloc() after memblock_free_all(). >> >> >> > >> >My point is if no one would call memblock_alloc() after memblock_free_all(), >> >which set nid in memblock.reserved properly, it seems not necessary to do >> >__memblock_reserve() with exact nid during memblock_alloc()? >> > >> >As you did __memblock_reserve(found, size, nid, MEMBLOCK_RSRV_KERN) in this >> >patch. >> > >> >> Hi, Mike >> >> Do you think my understanding is reasonable? > >Without KHO it is indeed not strictly necessary to set nid during memblock_alloc(). >But since we anyway have nid parameter in memblock_alloc_range_nid() and it >anyway propagates to memblock_add_range(), I think it's easier and cleaner >to pass nid to __memblock_reserve() there. > >And for KHO estimation of scratch size it is important to have nid assigned to >the reserved areas before memblock_free_all(), at least for the allocations >that request particular nid explicitly. Thanks, I see your point. > >> -- >> Wei Yang >> Help you, Help me > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me