From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8040BC28B2E for ; Mon, 10 Mar 2025 07:56:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E48C280009; Mon, 10 Mar 2025 03:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59337280002; Mon, 10 Mar 2025 03:56:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40DC0280009; Mon, 10 Mar 2025 03:56:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2062C280002 for ; Mon, 10 Mar 2025 03:56:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5232B120BEF for ; Mon, 10 Mar 2025 07:56:32 +0000 (UTC) X-FDA: 83204884224.18.54BB09E Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf01.hostedemail.com (Postfix) with ESMTP id 3DF2940009 for ; Mon, 10 Mar 2025 07:56:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QNhZC3dF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741593390; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJwceBGDF2wkWgWu1pdO+uwWw+syZobUsImQSfkS6Tw=; b=Ur3huP5WWR4nOlzvVH5fqvwhjat/0FYBDZswG8qAC3WBymTFQReIBv2NAQnglZetM5cUT4 kGbuSF57pjb/NBG6UAl1sUiuExBqxtWClFVuU1PpNwTCHFglgvn/3uGfCyr0kCRSDzEoMs 7L579ALEMA4Lp7/O5qjXr3qsZOz9z7Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741593390; a=rsa-sha256; cv=none; b=7z4LIVrXNtHGWR+5gOI4ZMdrvOZ0IUBqtGowTp6eW2tM9El454ZRNqplJ9oDi4IenzptGs 8ePcBo/7chedf7GuR+M382bzthjPZ2cmEm1o4ZM1/kbgMHcel0hq2KTRxzqmP8GmlfpSs8 g0YuPBOJjYAbrtZMKjNZCbFSSn8cW7s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QNhZC3dF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-abfe7b5fbe8so574975766b.0 for ; Mon, 10 Mar 2025 00:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741593389; x=1742198189; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FJwceBGDF2wkWgWu1pdO+uwWw+syZobUsImQSfkS6Tw=; b=QNhZC3dFI6YHvbgceCrggmeOT+aImPYDXimcznIeDUduJj6mM62wGyLzdOzuLagUlg AQPDZoIyccfnkRwtqY+4md15HQBTVGQO6QrOVScLvdl0ojKPx8K6+d3WzdjxPB0o9Bq2 8SEdZwUZ12/XSDVGFxdttBynRNaTQ93ujOwG5GRSPZFDRV2vEvGsieRRZ+ae09SbjTOk bzcXADA/1SbHas8J491QjBpFJ2LbluYfPyGYyDKPoTw7OGvYO/GAnD6X+RArotgt0dk9 WchhHzdrvMozV/yilUVH1lSGREFZ1SatnSZoRpp9s9VewtDBvrrs5XCqhuzjQNx0RV4l 73vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741593389; x=1742198189; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FJwceBGDF2wkWgWu1pdO+uwWw+syZobUsImQSfkS6Tw=; b=w6pSqZfroTrAmxmmbfyslIA7pM6PYroWnX2iEG0G9J6zUAQVYJ/KIcE7d7Ul9x+PIi YEh62HcJ9u6X6yQSGN4lsOjts62adYwrLAvsm/pt4FMS35+1oEdUBLUDyPZYu0c3s4Rf 57psWu/+wdmtj6jL6kPNjVHTpeu7apk5i0Gd8OrxQv1UIgE3d88J8hA5Sxavo6b2LGRD SQ4OJ1Vzzj99biHZpUvxVuGKsBlrX/EkcK2kDoyj92BwsdkhNxJZvzuBX650n1vbLXd+ OADymAAPslltJCkcndkYQc6/Mgj3dluxaUh3RtYkGxpV+2VAfvgCOkGUMcDSNVETmxLo FY3g== X-Forwarded-Encrypted: i=1; AJvYcCXJHRqmvwvdUoiksOuOTkx1kYBXleBC6tijBNL5DLniwxESPA4CqAHY8CSrPcYNkJiB+ZIhJqysDw==@kvack.org X-Gm-Message-State: AOJu0YzJ/Xe6ffdA+MAPAsDlU1z6LyimCGNysqmo2PJr6e29d8aBB6oh G7sXd/ONCz1Az9NLPfADtkWwodbp9/zettNGPyz4nUCMAonQyHXr X-Gm-Gg: ASbGncvYG8laAIfYc5s99q1B41JoRh+ijHk4WJB/yjQraXjoU8k/3yINJL+O053U2LL JQK/oz1916U3xPn01v125lXYd2Z7NXoVoUvNyupnlHOvAMDbqilXbEDaIfjQVxUlsf7aXHRHJoG 5rxNYrGlqskEjXirnjPyg+t7uXPLgNfa/LF9fWUPbjX46shQAvouTYXZhAmGJhmRgQ5aTNjyfZw bE/g5Kw0z5xRvJRA2FbmPKwFWPaSqFXd6uj/rui8UNHJV+yAwNXlKQVhrxleUH1IWGns317yy3S CXcaMW+3HKoMrmz/BCk9ZyyjdmXpKnFVNyZhHw+rghnD X-Google-Smtp-Source: AGHT+IEQ2uBHwcOdkgr7aGqLMWG+rbjuDIjMsdHGAG+hCMaeoXtOhIX4RmiolWfrWI8fpuA/uaZyUw== X-Received: by 2002:a05:6402:268a:b0:5e0:49e4:2180 with SMTP id 4fb4d7f45d1cf-5e5e24688d1mr34122496a12.25.1741593388499; Mon, 10 Mar 2025 00:56:28 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac279b3e463sm371805666b.72.2025.03.10.00.56.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Mar 2025 00:56:28 -0700 (PDT) Date: Mon, 10 Mar 2025 07:56:27 +0000 From: Wei Yang To: Wei Yang Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag Message-ID: <20250310075627.5hettrn2j2ien5bj@master> Reply-To: Wei Yang References: <20250206132754.2596694-1-rppt@kernel.org> <20250206132754.2596694-3-rppt@kernel.org> <20250218155004.n53fcuj2lrl5rxll@master> <20250224013131.fzz552bn7fs64umq@master> <20250226020915.ytxusrrl7rv4g64l@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226020915.ytxusrrl7rv4g64l@master> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Queue-Id: 3DF2940009 X-Rspamd-Server: rspam08 X-Stat-Signature: hhstybb9nic646ed7qa4zpikjc51jbgx X-HE-Tag: 1741593390-434881 X-HE-Meta: U2FsdGVkX182Iy5Mcn6yC/hagcv4waP2yjdjyuJRcY4LkWncKpJUjv1ENUqhjRfqXoct6L/zLpsbaOer14xPJntJuTz0DtNh0yb0F8cxfFfZxMpXmzRmN9jLMxAG9L6fXqvwICCGRLI2UzIfNBrpKtbiXqneoLXAG/9CANJIvnF9/S8jI9IYsq2l4sQ0iO1x2vobznm7Tqq1QtA2/V08B/IYLjIWoF6ceSW8KLx8hpHVaj3/tHrgkFrTolOlN92ZaBAH8YG6REsOqHYciwexc4//ArZKwMCWt4PGItOhKfXKtPBDVuU+TKZWIRMFI/bFNjU7KTB/GHRkiXAzby6c+QwjsEb8AaxyjVSDj0xLtWjusnir3egdrjvBigJjCyD8kKko19YTXGOVnVbZbYY1u400GbhJqeHB+gBU3zjHMATJMUAdtP+MoYrHglbt8bER1XqQbjhDQL6GX4xEXfccs0LrerP/eJTb3S5fw8SEKwmwm4oQ395VFJfNgHPgQe/QkrTpJ3xHmc7+HHZbcICAl+k19u2NqKDAhLHZYIlblG2ZEq3F1J/MHpWgdB2geQSE+4/YT6ncNwujvsu5VXP3IbrHgoPbMcVIdiRo14QaBP+vLFILaQ8VxBhelhyxgzlwErxV79kO21X4lhKrZa8ATA0KnNr4wDUqePN/qsvSZCGF1sBc2mDg5NHicnC1oHuyQJsy0yQ9kfIBWo+j8sd232fhsvnAsaUEZEs4P8xaZf7tjwrmLrsuiG9c/XTgNXseu+GdfgQ3T3jmiX+G35GCJIughhFpom4/oYoHr0zaOUJKpmWJWngdstkWGzC2/HOZ8zrN8u6tN6oK8umWop3aROkAg69+lclWWLQiE1e2zd6DF+57+6DIeVkX4y+pujjNV6Y4kbRXClzNTaOIBjLLEsAh/w7GsfW9HG+vRwJxrwGdd3fXzW4DthUOAaSS7IB4seuZ2LfBXsS+c/nOyRw r17G2ZbA sSEcyHWuI0bjvPEfBQRJ+4id6AARiankp+BDmjF5Ty78Mweww+xl9anKCF9HJxLeUcKNUBbVQB5Z/JYgFQz4TUH5xeKycZ+xV7KOgBMU54nkPoAZl+YKRjxMZUlORUBCkq9ilbvqx+GX6csL8JAu+H7YCScyI32+ytK5FpDGqxhZHl4q4LkqAoYf6Cgs3X1F5e5D/kS+LWApYms6hGEABAPNf1FxWzCVL0wnmdCIEXSyOiC41VfH/qP07w3StaHl50gj+N0B+jcMbcjsTwGpNkX3Oc0IxXSJhinb3xHbXrQMra3kHPXoToSjTES4Wr4yDORvq0+3IjmAGqFvC2Lk+REsrHbp96/AIgTD7zZ2Gmx287/xvyn4BoUcI/Vw8bABkII4mfgSWOnkg9TToOUdHclJ0lJbXaIOyq+JuHTMkBudy+Hl6Fjz9VOr4pLH2RqQpAndLdTkWaPTEwp6ulYuNIBeoc70ZeRqG6vZQLHBQrm6sg/R/OGPkOcqbrJhNbOfGQDrTjS9CDYSTMvyjzpt9aUYixe/1Lh5qz3RUMefuWQjBOJihE/MswXTVMG3JzlBJiBmZjM5WTj/++OWrcUR8nclfITNo9itURWzoRCseSb/AfU0a4CzlNOzJdahEjd4/4eHDyQ2ZP+e1yEAjlSXacTfaTCw9oWLMNGSnZp+cKCiQZ2oaGCWdL+TJXoaDBlN3MZZu+YFGSsFeOFITHG+v6gQ2I7PC7hAO0vRO1ooKBxqHwp0c/HQgqfJlMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 02:09:15AM +0000, Wei Yang wrote: >On Tue, Feb 25, 2025 at 09:46:28AM +0200, Mike Rapoport wrote: >>On Mon, Feb 24, 2025 at 01:31:31AM +0000, Wei Yang wrote: >>> On Wed, Feb 19, 2025 at 09:24:31AM +0200, Mike Rapoport wrote: >>> >Hi, >>> > >>> >On Tue, Feb 18, 2025 at 03:50:04PM +0000, Wei Yang wrote: >>> >> On Thu, Feb 06, 2025 at 03:27:42PM +0200, Mike Rapoport wrote: >>> >> >From: "Mike Rapoport (Microsoft)" >>> >> > >>> >> >to denote areas that were reserved for kernel use either directly with >>> >> >memblock_reserve_kern() or via memblock allocations. >>> >> > >>> >> >Signed-off-by: Mike Rapoport (Microsoft) >>> >> >--- >>> >> > include/linux/memblock.h | 16 +++++++++++++++- >>> >> > mm/memblock.c | 32 ++++++++++++++++++++++++-------- >>> >> > 2 files changed, 39 insertions(+), 9 deletions(-) >>> >> > >>> >> >diff --git a/include/linux/memblock.h b/include/linux/memblock.h >>> >> >index e79eb6ac516f..65e274550f5d 100644 >>> >> >--- a/include/linux/memblock.h >>> >> >+++ b/include/linux/memblock.h >>> >> >@@ -50,6 +50,7 @@ enum memblock_flags { >>> >> > MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ >>> >> > MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ >>> >> > MEMBLOCK_RSRV_NOINIT = 0x10, /* don't initialize struct pages */ >>> >> >+ MEMBLOCK_RSRV_KERN = 0x20, /* memory reserved for kernel use */ >>> >> >>> >> Above memblock_flags, there are comments on explaining those flags. >>> >> >>> >> Seems we miss it for MEMBLOCK_RSRV_KERN. >>> > >>> >Right, thanks! >>> > >>> >> > >>> >> > #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP >>> >> >@@ -1459,14 +1460,14 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, >>> >> > again: >>> >> > found = memblock_find_in_range_node(size, align, start, end, nid, >>> >> > flags); >>> >> >- if (found && !memblock_reserve(found, size)) >>> >> >+ if (found && !__memblock_reserve(found, size, nid, MEMBLOCK_RSRV_KERN)) >>> >> >>> >> Maybe we could use memblock_reserve_kern() directly. If my understanding is >>> >> correct, the reserved region's nid is not used. >>> > >>> >We use nid of reserved regions in reserve_bootmem_region() (commit >>> >61167ad5fecd ("mm: pass nid to reserve_bootmem_region()")) but KHO needs to >>> >know the distribution of reserved memory among the nodes before >>> >memmap_init_reserved_pages(). >>> > >>> >> BTW, one question here. How we handle concurrent memblock allocation? If two >>> >> threads find the same available range and do the reservation, it seems to be a >>> >> problem to me. Or I missed something? >>> > >>> >memblock allocations end before smp_init(), there is no possible concurrency. >>> > >>> >>> Thanks, I still have one question here. >>> >>> Below is a simplified call flow. >>> >>> mm_core_init() >>> mem_init() >>> memblock_free_all() >>> free_low_memory_core_early() >>> memmap_init_reserved_pages() >>> memblock_set_node(..., memblock.reserved, ) --- (1) >>> __free_memory_core() >>> kmem_cache_init() >>> slab_state = UP; --- (2) >>> >>> And memblock_allloc_range_nid() is not supposed to be called after >>> slab_is_available(). Even someone do dose it, it will get memory from slab >>> instead of reserve region in memblock. >>> >>> From the above call flow and background, there are three cases when >>> memblock_alloc_range_nid() would be called: >>> >>> * If it is called before (1), memblock.reserved's nid would be adjusted correctly. >>> * If it is called after (2), we don't touch memblock.reserved. >>> * If it happens between (1) and (2), it looks would break the consistency of >>> nid information in memblock.reserved. Because when we use >>> memblock_reserve_kern(), NUMA_NO_NODE would be stored in region. >>> >>> So my question is if the third case happens, would it introduce a bug? If it >>> won't happen, seems we don't need to specify the nid here? >> >>We don't really care about proper assignment of nodes between (1) and (2) >>from one side and the third case does not happen on the other side. Nothing >>should call membloc_alloc() after memblock_free_all(). >> > >My point is if no one would call memblock_alloc() after memblock_free_all(), >which set nid in memblock.reserved properly, it seems not necessary to do >__memblock_reserve() with exact nid during memblock_alloc()? > >As you did __memblock_reserve(found, size, nid, MEMBLOCK_RSRV_KERN) in this >patch. > Hi, Mike Do you think my understanding is reasonable? -- Wei Yang Help you, Help me