From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841BEC282D1 for ; Sun, 9 Mar 2025 04:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D68F96B0082; Sat, 8 Mar 2025 23:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D168F6B0083; Sat, 8 Mar 2025 23:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C05256B0085; Sat, 8 Mar 2025 23:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A99606B0082 for ; Sat, 8 Mar 2025 23:12:26 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 83B141A2232 for ; Sun, 9 Mar 2025 04:12:27 +0000 (UTC) X-FDA: 83200690734.22.907DC8D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id DDF40140004 for ; Sun, 9 Mar 2025 04:12:25 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bhrHLNpV; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741493546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7uS8isePwFiOggFuY3D2AN46OBQCKIfr2fHiZF1Ouk=; b=IRjHs6Q2u1/eWQkmrp1Z7ZC5BA3yML6AJrupjBAlf28zPgoesq/d9BhxEkkKk1rtAm3Uap T9E6uSaoUz1EwzRg6C1tdy/hXh06IppTqN6ZlwP4CBYgFrH4zK6G2YnMocyIUFjbDnxXDh 67zhshIJuDS6XkcBBWC0jyrIAKXPsCM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741493546; a=rsa-sha256; cv=none; b=Q/7s+PXbPEN28GrqxLllo99081eaOk9dI4YOBjALEIFnTn2G99QQYJ3GndcasXQwu8HXQr YkjWqeS1EhsZ+itMkCdwxg7AgudlQHWqvot/CE0mL23Fi9hqwdLd1aZmAoT4mjVVNcOZij KoMlmG5BPp3khCvqAuV+yzo3noy1hJE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bhrHLNpV; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A7F77A45AEC; Sun, 9 Mar 2025 04:06:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6854DC4CED1; Sun, 9 Mar 2025 04:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741493544; bh=HmPHWvgmQ4b/6G06nA39wWxm/hFo6anedjn2X/FgW4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bhrHLNpVUTX/aD/xEp5/b3/dAfBdY/Xcv0O7ldZ5Fnqui9JO/TZeKat0Yr0dcYeBJ tNuE4Hjx+QygwPdUL/nRQ1DBo4FcgTgzdiP1YkB1a0pTjQ9AKaU9lWjjBtTNprAd6A 33/GSuS6Iln3ekOPpFtZyBJBtngM+w1Pm5eIVhYc= Date: Sat, 8 Mar 2025 20:12:23 -0800 From: Andrew Morton To: Zi Yan Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Baolin Wang Subject: Re: [akpm-mm:mm-unstable 481/507] lib/xarray.c:1251:14: error: redefinition of 'xas_try_split_min_order' Message-Id: <20250308201223.3462273207d0086da22e2044@linux-foundation.org> In-Reply-To: <07CB0079-5D7C-4438-A9EE-03A72904CD12@nvidia.com> References: <202503091121.RktXlKnp-lkp@intel.com> <07CB0079-5D7C-4438-A9EE-03A72904CD12@nvidia.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspam-User: X-Rspamd-Queue-Id: DDF40140004 X-Stat-Signature: sa5w9hk8fcbchmix96tcjffq4491n39c X-HE-Tag: 1741493545-513598 X-HE-Meta: U2FsdGVkX1+s7q8lX+ADs/sko+3Dm4vimPAzCXVTBXzbt9AYtCxYJqclDiM6erGCel4/Sxidq2Dqj+2Q7BWDIiIeKVF1zFFdARm5YF/iynJw5rIAdhyvS6tZg/sebz6AgEGOqn8LwfW7tyvuYetnEiXW6nYk6SoLQl9C6Q6vf2OwXu9r+HmdDCxv28jWphlkDgHN6UbCyuQo773Di2UnH3BdULeDzMKT7cxTqLyN5CtsCo5VRDdNIdQVVUKHX7WkHOrM6H5VlaGKOqTV99LsRAtIARnjHA3dkCcCPEsqPyiHypL2PAOeBtPH3VyQ7t5NfXfwd2dPmC9m1pf7dSrrnuETkWwTT+2lNZtRcx1TrgXLNn6LyzN+NV6592sM26L0MKvZdjo1tg1EjHIbjFOii8rRE/2DC5gQfpaOb6nJztV9TPJQssouM4/dSBX9UQEoRWaCCYVzRvQhBOnSuWS9zRAHmFE4ex7T7SnG+dVdGqlZFJo2QZjoufvpHlMSrnrrwBGQm3yck8TKe42j7/pyrVsO2oQnA09h1ZeZ7fdFHOKtL2yAMl9Hh8kfaAFZjDaRse4XivIyysgO3zPmTNJK6kBbkUp9lbwNyO3aJX4fK0OeRJCd2IT/lrL3g5vL8BkdxDy+HuSKOsi8FzTERpJqziicTH7yKpRp4d2ijMshZinFbOcTceqqJGwgqrwcRt/uhwhDDdwJwQl6k2/pIDjTGPdcGNGLFXvafOk3WsAJUEMvmJ2vBUDroJZM75EdbBuyOt2xx42XwNr/PVrzX4dXxNt9erEPBDAdZcyOXSm0dADkn3xPi+D0ltndyZT1CsC3RhUC5nj67Xmc3UJOTxCyPpF1Q322u9M4rLxXpfRgUL2AXr8iBaLAK1lJueJiKcqgNEWlyHpZopGyE98gWW3cT+VJTt4R+gARmmKkShvuBUWrVAyRkqSZ+X/b6d5gI2rjtVS03F2eLMGogCHzvLS DNywR5AC t+7KPwUgtv/Gh+VRjvOdR5pziKHoZuyeLVSAnyK2MPO05aCqD1XmduYKl0qqnYLXFNPJ2vz6xZ69ArEeAOnWobUIUltFy/1h+jrgoSq+DBI4CKGU6EpvO0EszahlR4MhIzN6PnOUfDBc5TtRPxg3W2GUJnF1YBSFIMtzN9q+QmtCqE0EJGA8SiXsn9IfiAy3cBwqel6uPPVDIfvFLLFewKGsTetRt2SK1Y/oU/YsHZPWA7jilA/I5qIvmsEwiGq3apN1bzzcSkwa/FzLjUW6XfFSzMrsxKYI1Ve/wXmDyV3NOx9Ckarj81FBVRxAjJnuWdo0oFgQ7F0kIy5TOkeTYKk8jENMwiNuhpF4SSyRvG1hzRAiWXBObZVMVM3ozBazhb3qwtFx3e+WEzP2JSqlfGx3D5RVXRVJsbptngLLa29Q+VYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 08 Mar 2025 23:00:31 -0500 Zi Yan wrote: > On 8 Mar 2025, at 22:52, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > > head: 2f0c87542d97822659e81f55ae5e5cc1994f3339 > > commit: 835714732ae42a4b4f590316b06d06826bff2483 [481/507] mm/filemap: use xas_try_split() in __filemap_add_folio() > > config: i386-buildonly-randconfig-003-20250309 (https://download.01.org/0day-ci/archive/20250309/202503091121.RktXlKnp-lkp@intel.com/config) > > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503091121.RktXlKnp-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202503091121.RktXlKnp-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > >>> lib/xarray.c:1251:14: error: redefinition of 'xas_try_split_min_order' > > 1251 | unsigned int xas_try_split_min_order(unsigned int order) > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from lib/xarray.c:13: > > include/linux/xarray.h:1587:28: note: previous definition of 'xas_try_split_min_order' with type 'unsigned int(unsigned int)' > > 1587 | static inline unsigned int xas_try_split_min_order(unsigned int order) > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > > It seems that something went wrong when the patch is applied. > xas_try_split_min_order() is not included in the CONFIG_XARRAY_MULTI guard, > whereas the original patch does. Moving it back fixed the issue. > See: https://lore.kernel.org/linux-mm/20250308213400.10220-1-sj@kernel.org/ This series took a lot of damage as "Buddy allocator like (or non-uniform) folio split" was added, dropped, added, dropped... I have just dropped the series "Minimize xa_node allocation during xarry split". Please leave it a few days then resend against mm-unstable.