From: Andrew Morton <akpm@linux-foundation.org>
To: Zi Yan <ziy@nvidia.com>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>
Subject: Re: [akpm-mm:mm-unstable 481/507] lib/xarray.c:1251:14: error: redefinition of 'xas_try_split_min_order'
Date: Sat, 8 Mar 2025 20:12:23 -0800 [thread overview]
Message-ID: <20250308201223.3462273207d0086da22e2044@linux-foundation.org> (raw)
In-Reply-To: <07CB0079-5D7C-4438-A9EE-03A72904CD12@nvidia.com>
On Sat, 08 Mar 2025 23:00:31 -0500 Zi Yan <ziy@nvidia.com> wrote:
> On 8 Mar 2025, at 22:52, kernel test robot wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> > head: 2f0c87542d97822659e81f55ae5e5cc1994f3339
> > commit: 835714732ae42a4b4f590316b06d06826bff2483 [481/507] mm/filemap: use xas_try_split() in __filemap_add_folio()
> > config: i386-buildonly-randconfig-003-20250309 (https://download.01.org/0day-ci/archive/20250309/202503091121.RktXlKnp-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503091121.RktXlKnp-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202503091121.RktXlKnp-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >>> lib/xarray.c:1251:14: error: redefinition of 'xas_try_split_min_order'
> > 1251 | unsigned int xas_try_split_min_order(unsigned int order)
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> > In file included from lib/xarray.c:13:
> > include/linux/xarray.h:1587:28: note: previous definition of 'xas_try_split_min_order' with type 'unsigned int(unsigned int)'
> > 1587 | static inline unsigned int xas_try_split_min_order(unsigned int order)
> > | ^~~~~~~~~~~~~~~~~~~~~~~
> >
>
> It seems that something went wrong when the patch is applied.
> xas_try_split_min_order() is not included in the CONFIG_XARRAY_MULTI guard,
> whereas the original patch does. Moving it back fixed the issue.
> See: https://lore.kernel.org/linux-mm/20250308213400.10220-1-sj@kernel.org/
This series took a lot of damage as "Buddy allocator like (or
non-uniform) folio split" was added, dropped, added, dropped...
I have just dropped the series "Minimize xa_node allocation during
xarry split". Please leave it a few days then resend against
mm-unstable.
next prev parent reply other threads:[~2025-03-09 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 3:52 kernel test robot
2025-03-09 4:00 ` Zi Yan
2025-03-09 4:12 ` Andrew Morton [this message]
2025-03-09 17:20 ` Zi Yan
2025-03-09 17:38 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308201223.3462273207d0086da22e2044@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox