From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303EEC282DE for ; Fri, 7 Mar 2025 23:23:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 673B3280001; Fri, 7 Mar 2025 18:23:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC9E6B0092; Fri, 7 Mar 2025 18:23:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47717280001; Fri, 7 Mar 2025 18:23:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A8406B008C for ; Fri, 7 Mar 2025 18:23:05 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EADC35662F for ; Fri, 7 Mar 2025 23:23:05 +0000 (UTC) X-FDA: 83196332730.19.1898C6D Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf16.hostedemail.com (Postfix) with ESMTP id E4A7618000A for ; Fri, 7 Mar 2025 23:23:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Tu8aooUW; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741389784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wGVPAUm3Qc/F7uwCHOkqJSNfQnzu0aCNZGr8H8HENwI=; b=LBl1GYRKyR/bq+NP0fryTBzeknS6+IQBwgYo2rpBp5IkdCluDP5e1N6NCWD7ikzGCLkNfj nm0jLvmmmCRAS39KlocogJpR8eihy8UtwdqyVyo99eLatlMC8cZwT5Qoa63WGaPZQxep92 NfK9e+6A/gKEpW13t2ojZzV3vmYAvmA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741389784; a=rsa-sha256; cv=none; b=MlFkqSFzA4IDpa5OZomtBsAe92tsjGXg0j5lQJUEN3MhGC1gqAsYln/I+jbYkuatBXM3N3 oHfM7zl+yccOrbvHRTi4ekqeOMLujuEDbSdXWDfLrieBWTW+wVjz1aJBxe2hjRGMPKkSjl 4gSCKW9qysV7/ADTcVC3GnnVsPAvBLg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Tu8aooUW; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf16.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AAD5440E0214; Fri, 7 Mar 2025 23:23:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id h6sG7pYvhxPJ; Fri, 7 Mar 2025 23:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1741389775; bh=wGVPAUm3Qc/F7uwCHOkqJSNfQnzu0aCNZGr8H8HENwI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tu8aooUW9vK0UyLhWBbazvOuzUyemT2UWN0TvRam0qdEfDDmGxQ4dSmND5fsqRqSM H9/6Eh/MThLEDfkO5MLPPhYS5iosM1OYoBu4SqdlWkBvzNlOnQqyCaQi2a/Wh+xXGA ZNRBLnu1Vnakh5m0/4GIYCP9arX0BUKpRfCR+j6o6oduGWioXwRx0641br4JRfLMbH RnUQ7i4U6BLKAB/3SrNHsdaG5LtA1kqRS38rpqM79JferqtTAqE0txJlPzYBuDg9gR BAslESc6lz67x2V4RcziroNi8WFIjczvbUz9k674g/KFvfxxO9gD37We7zPdlGuEcB llw1/OGGzbK95suyJ1VFKZPGx8Xf9JMn8snmdGVKjirWX11ysvr7ukNoefBLexEiye dIzRSVNsCcDDFLK5quhAx0oZUcoog1dqosnrYzK/ceGbEsgH0Q6BmrLaULe3BP6CJa 0pLPv5JsCoL4Zjy1yYiQbFUhVsDC+tYaQapEuGawLnmkeZoycfcXxrx+suQ6QstCbT Mz/SvIUplte6GMl3eeoRVZKX7H1NQ18/ynFANVEhLF1Memwn3UgJhUH4PX0glBArbX Tea/7Ogy7dJ4PkmqNzNWxSuhuVHYbcUILv0XIJCdCLKLwHPaiZyePHOJ8/yFT8jWJ4 R++D1jBK7l7Jfkql26Llqf5w= Received: from zn.tnic (pd95303ce.dip0.t-ipconnect.de [217.83.3.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4BC9B40E016E; Fri, 7 Mar 2025 23:22:36 +0000 (UTC) Date: Sat, 8 Mar 2025 00:22:30 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Shuai Xue , "peterz@infradead.org" , "catalin.marinas@arm.com" , "yazen.ghannam@amd.com" , "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "nao.horiguchi@gmail.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "jpoimboe@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" Subject: Re: [PATCH v4 1/3] x86/mce: Use is_copy_from_user() to determine copy-from-user context Message-ID: <20250307232230.GMZ8t_tja324AQqYME@fat_crate.local> References: <20250307054404.73877-1-xueshuai@linux.alibaba.com> <20250307054404.73877-2-xueshuai@linux.alibaba.com> <20250307204018.GAZ8tZstt11Y4KFprC@fat_crate.local> <20250307224645.GKZ8t3VX5a5FhqNyZG@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8sxuwcgrz9dy6g7hjuewjrngkfpiy4tp X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: E4A7618000A X-HE-Tag: 1741389783-619206 X-HE-Meta: U2FsdGVkX18YGgy6Yx68RHEA+dm7SSee6k2noIlylEpAjKnZOSaK6DWICJo164IP75vr1l8R8sfvaTtvlIMEv/5j4yM/AknCzhTxVlFJp6YBX1p1qt99lFeMaHDafJMfs3ORWUMSxXK2o89ttjluM+BOVzUsCbg0Z4wv0Qz0hRw7SynTUjupevL7NXhwI5igg+m5ccu8RN7m1pW7W073gKyYWG39M3ZsxmLpzh4AJNs50itB4D5cjy8c5xwJX9A/fErxvl+33gV8u4ChMCZuIlyQODYeXdAb3/h2Nws4Lh2bF2PSUa9SBPDm2xThz0IXjbzM4RBgV2M5KPPRVTZQNcaml/avSFH1cPuR8cdXX9BPhUA1bTnMsCFsCAKn0tEUr//xhXeq4rD1bv6gJzz9nApWU+s0IGuSMa3HAsQgA09broMeczrr/piN8lZm7/2Yt1CC+m3mAI7xiWgR7n7G/Y5Fwg1jRIkxuNSPvmIDOzLPXMD09Q+A2PQHfBbIMPlR6nyrxHu3AUgg9qXujE0hL1D0sIWMkH7RCkPI25OaNNoybiE9zJXYlmFmCunb++O0LdCdOjBCSvl1DznsYHZsfzA5K+VFzwXSQVJ9HQspJ/ySL1dSHiW/SWSIbUmViwb6NhtxhMhtzd9hClByDtiQzCAdXAk/rxDorGK5LuC39phj8uqemH6S7M7gVqoWbaEb/BgwKEupDaT70qe/+glyb24UjYcgdHZfU5nO40q7E4/QI9dIoumuPo5dPLNmWhNSesC8XHo7rRK/PX2YSCjqZObsQFG/rArNi1HhrjHM1ZhUxLuFRdtcF9zyse6IkKI5Rgd+RVyA6aw39EGnCvzEh/6RudFx4Lb/9CQFRdUbUNAzpsLh/sh7ogr7y7FSsrYR/ne6LduuQBvWK5/6IEp09tWeT3RUZbErDtV4L+SjExQXy1zFD4e3AmrvikEzjQgDMZkOLB3Lmza5jmFHW6L //N5YBvB Pt1XcFhwXjbxPyL4LK3W4bPjZPctmVb7LH7LVeU4Icml994fH8J2sU3ujJ6FVCw+aSBLCU11ENqF3xNZOjuxaoDd0D+HuS68tFo08mYDbZWjvYlQB99qgraFks+AmNi7LeoZMo67eOX4jIOqBJk0dc3CySy1nnt7rJL8qE8eVGksCRgMZyuYFZIRQWFB6Apx7ZItB0oZAN9MDDxoQb1PqfYZhJI8+vIH7QvcV5vtOyZdHTFU93HgmCMOEiGr4WwHndOV43VSRdkd13Cau+gwD2DnoLTExEp6nLWccBRrJnq1a45KHJAfrrD9auJQR78/0o1ObEN4B440tQWEBzSzmgA16E08X4I7dywJ7ymr6vNufFaYFCFuWCdDAUDAC3cdcSbhPoQX8WHO3sm5mL9NiBjcrQDho0YIM9wh1WYJsrGfdLqK+cg4mdZq2Lg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.031813, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 07, 2025 at 11:11:26PM +0000, Luck, Tony wrote: > As for "explicit markup" I don't think it would be better to decorate > every get_user() and copy_from_user() with some "this one can > recover from #MC" I don't mean every function - I mean what we had there with EX_TYPE_UACCESS. That is explicit and unambiguous. Proving that is_copy_from_user() is always correct is a lot harder. > Note also that "what we had recently" was fragile, broke, and resulted > in this regression. Because those exception types got renamed? Oh well, that should've been reverted actually but no one involved realized that MCE is using those. And I'm not saying this is the only way to solve this. We could do something like collecting all addresses on which an MCE can be recoverable, for example. We haven't considered it that important... yet. Looks like we're going to try this new is_copy_from_user() thing now and then see where it gets us. So, after the commit message has been fixed: Acked-by: Borislav Petkov (AMD) I'm presuming, this is going through akpm... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette