From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932E2C282EC for ; Sat, 8 Mar 2025 04:07:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01FAD6B0085; Fri, 7 Mar 2025 23:07:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F10EA6B0088; Fri, 7 Mar 2025 23:07:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E00076B0089; Fri, 7 Mar 2025 23:07:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C36896B0085 for ; Fri, 7 Mar 2025 23:07:07 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41A96141477 for ; Sat, 8 Mar 2025 04:07:08 +0000 (UTC) X-FDA: 83197048536.17.3318133 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id AA234120009 for ; Sat, 8 Mar 2025 04:07:06 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R/rx4imJ"; spf=pass (imf29.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741406826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B/vdXukViH7+I3J0f62TDOC+Ran1qVuy1fFnYoMv2dY=; b=sZIYhmaFjEoNLzu6CVAGlzEXmFi1IoCN5mhSj+B4MQ6+vtJhlJxcdkN5sni/Lx+7zsovPJ T3A4QDdoueUlvPK/uV115XRX/2mZP6NQdH8LCVEPvZybkEcJLVR4n4b/81Fk0ZWt1WmJD3 dKbwhsmhSU/tn750Ekjh9fDuTMw1g0U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741406826; a=rsa-sha256; cv=none; b=TbJHdwD/8t9UjQ4ESI4FNGgR1SpFYdezcC5xTPHWT+myVmK4T7gu+boi4bPFNdm3KVlBCy PIJt5pxgmvcR2ZFa71d/u3XswVFLjbFNMPyPEaQufmYvk+k08Ir084u+Ew3TlVEbBMOpcQ M0EgM2UeQAhCf3az70TLpeFRwB/pkq4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R/rx4imJ"; spf=pass (imf29.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 83726A458AA; Sat, 8 Mar 2025 04:01:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93A14C4CEE0; Sat, 8 Mar 2025 04:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741406825; bh=s41Kiihoo5v0OXthZUir9md3noNFobzwW/cnNSvrFAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/rx4imJ1i7ZDNHYHBA7H4lp7cojqNDgPdPaS3/7MnfFNfOeQYHcBYGV/HSyRxWjw ro+iHFi8ugniPknrC0uBQEZDnulTXvtX+ii9iun8nG8+Sy0MQin7yvaYPuN1myiZpz Y3nNe3NfYaZFmtk8evlnvGI3C+FmuT0Vs8+XDGeCODll4eZ6WMPIWdcgvcSfCfrbLz wTvnmPDFxc0DQO1o5Wrh/VS7EYyT8tmLAQs6k/e1tjXM6+1p/iHpEXV2hhzOMZlShI GYnZB5UMWjcyK19Rr+ypxthdY9rXRWwWac5+f71nwFRNXfRZRyZMW617G7SDGOPPG1 FGcVlNkfb+gYA== Date: Fri, 7 Mar 2025 20:07:01 -0800 From: Kees Cook To: Pedro Falcato Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, ebiederm@xmission.com, sunliming@linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sunliming@kylinos.cn, kernel test robot Subject: Re: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning Message-ID: <202503072006.B920348F@keescook> References: <20250308022754.75013-1-sunliming@linux.dev> <174140535640.1476341.8645731807830133176.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: AA234120009 X-Stat-Signature: as76s19rxzzi1961hbrrtsqehtwx53ra X-Rspamd-Server: rspam10 X-HE-Tag: 1741406826-197213 X-HE-Meta: U2FsdGVkX19MzPQT7G12XggWGG01YgqS3e33J4CniXX0rUHgvI5L3rqUmYvr0LJu/08f9x7WcCla0+X746oBCflE+9odWq8nl401O49aaQfqLxFjECK+k3uGQvRVUxs3/uk1WOycMO3O9m3PcqUqJQLR70hcpe7bVRwWgQC9Ps4lgkPFHXUNpVKnUNHUIFd3KpdtwdqCnCAwm5BjcJz/CbSbySl8CmEbI9xOJdq7aw++AeNkC3jXkLsFOp+4k/NvIPjq772mPrRoj57UEILX+I+YTM5GZjCKPM/rJ8Ib0+Z28eP3WeeKCyQHqryP2Q6AA9zhjzLUqDXdEDqCf2MESoOWmw8ZnTzzKBYShPrqZwKWxF+vI28LPDP5ni1UIMCdYWiOaJeAv/dlLEwToNm1JxH1JqJhuZvkKywlsNzSVJHcuxBqgRPhYQFO6S1Zp31got6xWnIn+tKBWoz5UpaHEoeoRT8skHcPiNH7VA/Uzeve66wHl/NYvDuTNHg/XWc44yR6RLMcH+rDFluf+z0hG+FuE4l6s+NKa00zL8AFbXcOMPOOHwQFzYUNRXqD+HEYZO9BR5MPVWIiaI2X33Y+7sDVtzEc+ghfpdKlD6ujHhKMk1MfoYWux67zBycdeZlHICJx2p+8JVAqnfuQLQslzQD//+IG8KzHIUoXTMV5ifIRPqttRWhjZoWcGDatqxY4pMymk+ASnuyazb+tVUoKtwDPqTOp0TFbCIG5dxN/W4uUaBrgr39sLVURotfvTKnAjdMPln4xBBDMk4v0d3uWQtAjoLk/O2qBe1KlTY0SLOBLFhaZ4hFiXsB9i5WMylyRFxMGDIlhNq3DzGV/es0lpxUUmDrOLTqTTKq3RbQzAc4XB6zjy2TLhM7dwT3/8rEtT/tH+ttPYhUeVHd1x7gYmPfpj5mjrCldNkbhoKQ6wY8rKsubwrrhQ7xXRfKcrt3EHszXiWE8fxxm6nJN53L G1qA0sCO sLJ96mpuPt/96ZgrYbe/tSDUjjjWH26WngI3UNEZUuUQv8GEu8pYkJqPiVLDNCBVctLCtAqT/vouHt60W6W/PaG4nlFwLbDzmQsrmRpPofxD0LYsAiq2auzRznuTJs8RARtehCee1BOdmoVGU1AbHt77Im/m0L9pyuq8FALqSt1K4yy2kSnqI0xXGo+m6GG7IBY1T6icaYKIkzAbfSTwujD4Mzrppz6q1vTFhN4n+lX2zyaOzdezID2zFihjvV25nNAxSnDcYB20Tw4KSZyqoMFO3yJCZN6YU/RrZQ0W80uD9+bLcRjo5qfE0V/CCN7xmErLIWWgrS3kpBY+kkxF2g3ZUQSh4x6Bm9JgV0YbOA0wQc2pTFbQwRe+qKPhiGxTFEZfVbqxtewhzbGl5GLmjPzMXW2Y4jCOL3ogP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 08, 2025 at 04:01:50AM +0000, Pedro Falcato wrote: > On Sat, Mar 8, 2025 at 3:45 AM Kees Cook wrote: > > > > On Sat, 08 Mar 2025 10:27:54 +0800, sunliming@linux.dev wrote: > > > Fix below kernel warning: > > > fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not > > > used [-Wunused-but-set-variable] > > > > > > > > > > Adjusted Subject for typos. > > > > Applied to for-next/execve, thanks! > > > > [1/1] binfmt_elf_fdpic: fix variable set but not used warning > > https://git.kernel.org/kees/c/7845fe65b33d > > > > FYI, there's a typo so this patch won't compile > > >+ unsiged long excess1 > >+ = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); > > s/unsiged/unsigned/ D'oh. Fixing in my tree.. -- Kees Cook