From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920BAC19F32 for ; Fri, 7 Mar 2025 03:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD927280002; Thu, 6 Mar 2025 22:40:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6163280001; Thu, 6 Mar 2025 22:40:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DCCC280002; Thu, 6 Mar 2025 22:40:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D1C5280001 for ; Thu, 6 Mar 2025 22:40:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 50A8C1C69E8 for ; Fri, 7 Mar 2025 03:40:26 +0000 (UTC) X-FDA: 83193352452.29.E84BF95 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf26.hostedemail.com (Postfix) with ESMTP id 91DBC140008 for ; Fri, 7 Mar 2025 03:40:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jGQ11JIi; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741318824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d+MzUcZgOlL3yYt5QXqc0TliUuSupjafeCeUTzsS4Ic=; b=THU2RGtE4uu5xWBEQ0q3Xuo7aiK6uJDlgdYFAt24pGDplMbv8byzOfRDED82ZgUFj9nmDo vybOeiffdwaQE80yMvDZh7ddcTkhX124cjDGyVWhtNL559T7DbnPcuu5ZAuY8sTTNwRK6H iBjWODoeB7e+U22EZl37S8owHUYX9PE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jGQ11JIi; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf26.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741318824; a=rsa-sha256; cv=none; b=ZEtwvAIP7sxLdq2hB4j+ogw+1za0e9g5Cru4cixFnrGgR9pHdqKn/MYnf6scGKZVgBn1X+ X86xk6riQJPB+XiiHtubXDUHva9afgK3VQ7W+JSk1pdS3e0uVj+cd/KnGxP1gXw1HUTLr3 gTR8XhWcRzCpNhrA/NwvBzQBwjDPkZk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741318825; x=1772854825; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iyS2daxFBTxrqZIFfDH3tFbe9as5X14QyKFI7+aIKb0=; b=jGQ11JIihct2MZZxzTVF4gCK++xgooNm5np9x126v29peJvA3BINwfX4 07KwBXu2WDQijK1aDqXV5rskdYCw74JF3DI5ug2JxjfKmK3zAnOZF2yDL hYRXJKrR9pzsBI7PD9gEHlTaGpTXaLRZdE6lJVfZRQi0l/GZtNUJ4BgmW R9sBp+if5jkDMHyN4vlLvXW4ciPKBeZtK4ESIC/zBKv+7P8Vpkd+EqLlE 4rayrSH+PhQcHJC7AMQoxRLOwKc57DXB4xx6XOMkQiiM0TX0qVrheBcDd VbRLdFV8zWib8YTnmWwSfJ8/sFAawC4DfBHvfFJvQ7fdm55/6t3M2nHGP g==; X-CSE-ConnectionGUID: w0oJx9PNRi2vMaIDOxja7w== X-CSE-MsgGUID: Oq+HWF4tTo60qIWpBd0Gqg== X-IronPort-AV: E=McAfee;i="6700,10204,11365"; a="53757024" X-IronPort-AV: E=Sophos;i="6.14,228,1736841600"; d="scan'208";a="53757024" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 19:40:22 -0800 X-CSE-ConnectionGUID: BtDtKb4QTOOuzJ7JXGGdUw== X-CSE-MsgGUID: doplWBhgTcKiYh8pnoHrMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,228,1736841600"; d="scan'208";a="124139557" Received: from lkp-server02.sh.intel.com (HELO 76cde6cc1f07) ([10.239.97.151]) by orviesa003.jf.intel.com with ESMTP; 06 Mar 2025 19:40:16 -0800 Received: from kbuild by 76cde6cc1f07 with local (Exim 4.96) (envelope-from ) id 1tqOZE-000OES-2Q; Fri, 07 Mar 2025 03:40:10 +0000 Date: Fri, 7 Mar 2025 11:39:03 +0800 From: kernel test robot To: Shuai Xue , tony.luck@intel.com, bp@alien8.de, peterz@infradead.org, catalin.marinas@arm.com, yazen.ghannam@amd.com, akpm@linux-foundation.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com Cc: oe-kbuild-all@lists.linux.dev, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: Re: [PATCH v3 1/3] x86/mce: Use is_copy_from_user() to determine copy-from-user context Message-ID: <202503071115.uNkoVksh-lkp@intel.com> References: <20250306021031.5538-2-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306021031.5538-2-xueshuai@linux.alibaba.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 91DBC140008 X-Rspam-User: X-Stat-Signature: zhc4siggkhjak6bmnkeiend8i7n1yk71 X-HE-Tag: 1741318823-657963 X-HE-Meta: U2FsdGVkX1/nzM+CP6HNLpILfM+j+MrDdg0ppxBDQZd1SfPRz3Xp7Gne+1EVQnWnvoP9lyn9KGgqiwGs6Sq9V+e8R5y8xwPNV7kEq2Z6Y51tQba2crNWP/dxekIATl/azJvdihS6I+/V5yZxtJro/8WeFkEINMGcmjitfzCoMl0lEX+j7rCcnleePmlf7TKvlugfYoenxAQwcZD/XzR8X+dS+lDWXAc/AYmRXQhZKzujwzhk2QGKQkWmjKJWrb/RCa/Jio4GPqzCKdKxe9fCIRmhajoYN1m9f5QHplx4y5jy9i2A7ff6sBQB+cuk/LkdmirFkugKpIRPqNef0apAXZJzCAqFCwv6MYQkCKp/F8SKP5156yCnhS6Plutzi2mRU3vDBZsVsJ1zuRlAgqvxe7nGEaIL4+KTQQGMy0Ggnu4rLElZFvSjpWBJMrlciHTLQm12zspUxv3rklu+u4fI+GgQDD9osc7zSoDyZjEIcFvflCXmvrdesmT5TbT08Rexm0CfgFmYGXbAm7ci28Lak9wKpNKIGOJI+rk6A778KBRYaL0wYFfdl4Z26JabkiWq6kazC7kSYHTgu/+wkqyFZaHq4DTKQKHMmj8NFC4sisMDh6I+e9WwTiOtxUYUL0b8WFQX1XpuF7dptt1Sf8Ia2JIbDfBaOTaWZHOp9xMRT5XQi1KUgmalKbUjUt4DOZz1T2UjMnP8Y8bp1wUn2eM1xf7yDy4BRSznOkWkLsMi75LceMPTXjKYyVEikFFhYOaSxyGst6FMvjU1Wm5jERRtWvVWs5AMK6127zIOCxdpkCRidVwvARi4aIh10kTb52xzNGXLYM6lauuDRm0HNbGVnrOThjlPguDmmBWcF3R6MZjeweDtlB6wX3LJR8TuC+bKPd8msekq6Tv9gjADfJfcPwnT1OK2qUyxUAyhmc0wiBB+Fvhy5eDDP4JrA/ZlE3jLzuwUR7Rb+uQBtu0mc36 MehVEBfH pYvB6hR11Wu1T5uIDno4X8gGtw9vJ2lcy1T+t95fZmSJBlEfur50NiUEXgmK47fMS+kWPp2SwCHejgunVbwXkviimQ7Akrjg+NsvS4Mwxqb72yHuJhR6jIxRheM1AN7P2jqG0Z0wZ1k2JVCxuiOhe8yZ52TdXqBIsq7krBMcin4aLPQ80Dt/F4wqwgems72U+/rFo3qrava2YCs7GZi1FXuUkwnSfeQdNE31aMTSjR4txbH+P3pcJ/RQa8ggxlHogKnWrGAMu5aKMnMEE61FRNA3cZLyucDN0RenRir1P3/wXglJ/iLCmx+90pEunJnHejv7iS5hmT4w3Qze0KDT8lK5C0oItuRhjXnQKp0qu5+FLXcv9s0Zalbjb7oX9HzKjN86rM1Et1DmVQc5hUZTLLFxZikx7+Liwi3nAYsDAPXVFyqU/zCP4Ec0P7EVIYbMLP8oV5P3gUSbjH/vfu8xScGxI0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shuai, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Xue/x86-mce-Use-is_copy_from_user-to-determine-copy-from-user-context/20250306-101505 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20250306021031.5538-2-xueshuai%40linux.alibaba.com patch subject: [PATCH v3 1/3] x86/mce: Use is_copy_from_user() to determine copy-from-user context config: i386-buildonly-randconfig-005-20250307 (https://download.01.org/0day-ci/archive/20250307/202503071115.uNkoVksh-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250307/202503071115.uNkoVksh-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202503071115.uNkoVksh-lkp@intel.com/ All errors (new ones prefixed by >>): arch/x86/kernel/cpu/mce/severity.c: In function 'error_context': >> arch/x86/kernel/cpu/mce/severity.c:305:39: error: expected ';' before '}' token 305 | return IN_KERNEL_RECOV | ^ | ; 306 | } | ~ vim +305 arch/x86/kernel/cpu/mce/severity.c 274 275 /* 276 * If mcgstatus indicated that ip/cs on the stack were 277 * no good, then "m->cs" will be zero and we will have 278 * to assume the worst case (IN_KERNEL) as we actually 279 * have no idea what we were executing when the machine 280 * check hit. 281 * If we do have a good "m->cs" (or a faked one in the 282 * case we were executing in VM86 mode) we can use it to 283 * distinguish an exception taken in user from from one 284 * taken in the kernel. 285 */ 286 static noinstr int error_context(struct mce *m, struct pt_regs *regs) 287 { 288 int fixup_type; 289 bool copy_user; 290 291 if ((m->cs & 3) == 3) 292 return IN_USER; 293 294 if (!mc_recoverable(m->mcgstatus)) 295 return IN_KERNEL; 296 297 /* Allow instrumentation around external facilities usage. */ 298 instrumentation_begin(); 299 fixup_type = ex_get_fixup_type(m->ip); 300 copy_user = is_copy_from_user(regs); 301 instrumentation_end(); 302 303 if (copy_user) { 304 m->kflags |= MCE_IN_KERNEL_COPYIN | MCE_IN_KERNEL_COPYIN; > 305 return IN_KERNEL_RECOV 306 } 307 308 switch (fixup_type) { 309 case EX_TYPE_FAULT_MCE_SAFE: 310 case EX_TYPE_DEFAULT_MCE_SAFE: 311 m->kflags |= MCE_IN_KERNEL_RECOV; 312 return IN_KERNEL_RECOV; 313 314 default: 315 return IN_KERNEL; 316 } 317 } 318 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki