From: Rakie Kim <rakie.kim@sk.com>
To: gourry@gourry.net
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
joshua.hahnjy@gmail.com, dan.j.williams@intel.com,
ying.huang@linux.alibaba.com, kernel_team@skhynix.com,
honggyu.kim@sk.com, yunjeong.mun@sk.com, rakie.kim@sk.com
Subject: [PATCH 2/4] mm/mempolicy: Enable sysfs support for memory hotplug in weighted interleave
Date: Fri, 7 Mar 2025 15:35:31 +0900 [thread overview]
Message-ID: <20250307063534.540-3-rakie.kim@sk.com> (raw)
In-Reply-To: <20250307063534.540-1-rakie.kim@sk.com>
Previously, sysfs entries for weighted interleave were only created during
initialization, preventing dynamically added memory nodes from being recognized.
This patch enables sysfs registration for nodes added via memory hotplug,
allowing weighted interleave settings to be updated as the system memory
configuration changes.
Signed-off-by: Rakie Kim <rakie.kim@sk.com>
---
mm/mempolicy.c | 51 +++++++++++++++++++++++++++++++-------------------
1 file changed, 32 insertions(+), 19 deletions(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 385607179ebd..fc10a9a4be86 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -3389,6 +3389,13 @@ struct iw_node_attr {
int nid;
};
+struct iw_node_group {
+ struct kobject *wi_kobj;
+ struct iw_node_attr **nattrs;
+};
+
+static struct iw_node_group *ngrp;
+
static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr,
char *buf)
{
@@ -3431,8 +3438,6 @@ static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr,
return count;
}
-static struct iw_node_attr **node_attrs;
-
static void sysfs_wi_node_release(struct iw_node_attr *node_attr,
struct kobject *parent)
{
@@ -3448,7 +3453,7 @@ static void sysfs_wi_release(struct kobject *wi_kobj)
int i;
for (i = 0; i < nr_node_ids; i++)
- sysfs_wi_node_release(node_attrs[i], wi_kobj);
+ sysfs_wi_node_release(ngrp->nattrs[i], wi_kobj);
kobject_put(wi_kobj);
}
@@ -3486,12 +3491,10 @@ static int add_weight_node(int nid, struct kobject *wi_kobj)
return -ENOMEM;
}
- node_attrs[nid] = node_attr;
+ ngrp->nattrs[nid] = node_attr;
return 0;
}
-struct kobject *wi_kobj;
-
static int wi_node_notifier(struct notifier_block *nb,
unsigned long action, void *data)
{
@@ -3504,10 +3507,10 @@ static int wi_node_notifier(struct notifier_block *nb,
switch(action) {
case MEM_ONLINE:
- err = add_weight_node(nid, wi_kobj);
+ err = add_weight_node(nid, ngrp->wi_kobj);
if (err) {
pr_err("failed to add sysfs [node%d]\n", nid);
- kobject_put(wi_kobj);
+ kobject_put(ngrp->wi_kobj);
return NOTIFY_BAD;
}
break;
@@ -3521,14 +3524,14 @@ static int add_weighted_interleave_group(struct kobject *root_kobj)
{
int nid, err;
- wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
- if (!wi_kobj)
+ ngrp->wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
+ if (!ngrp->wi_kobj)
return -ENOMEM;
- err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj,
+ err = kobject_init_and_add(ngrp->wi_kobj, &wi_ktype, root_kobj,
"weighted_interleave");
if (err) {
- kfree(wi_kobj);
+ kfree(ngrp->wi_kobj);
return err;
}
@@ -3536,7 +3539,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj)
if (!node_state(nid, N_MEMORY))
continue;
- err = add_weight_node(nid, wi_kobj);
+ err = add_weight_node(nid, ngrp->wi_kobj);
if (err) {
pr_err("failed to add sysfs [node%d]\n", nid);
goto err_out;
@@ -3547,7 +3550,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj)
return 0;
err_out:
- kobject_put(wi_kobj);
+ kobject_put(ngrp->wi_kobj);
return err;
}
@@ -3562,7 +3565,9 @@ static void mempolicy_kobj_release(struct kobject *kobj)
mutex_unlock(&iw_table_lock);
synchronize_rcu();
kfree(old);
- kfree(node_attrs);
+
+ kfree(ngrp->nattrs);
+ kfree(ngrp);
kfree(kobj);
}
@@ -3581,13 +3586,19 @@ static int __init mempolicy_sysfs_init(void)
goto err_out;
}
- node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *),
- GFP_KERNEL);
- if (!node_attrs) {
+ ngrp = kzalloc(sizeof(*ngrp), GFP_KERNEL);
+ if (!ngrp) {
err = -ENOMEM;
goto mempol_out;
}
+ ngrp->nattrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *),
+ GFP_KERNEL);
+ if (!ngrp->nattrs) {
+ err = -ENOMEM;
+ goto ngrp_out;
+ }
+
err = kobject_init_and_add(mempolicy_kobj, &mempolicy_ktype, mm_kobj,
"mempolicy");
if (err)
@@ -3602,7 +3613,9 @@ static int __init mempolicy_sysfs_init(void)
return err;
node_out:
- kfree(node_attrs);
+ kfree(ngrp->nattrs);
+ngrp_out:
+ kfree(ngrp);
mempol_out:
kfree(mempolicy_kobj);
err_out:
--
2.34.1
next prev parent reply other threads:[~2025-03-07 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 6:35 [PATCH 0/4] mm/mempolicy: Add memory hotplug support " Rakie Kim
2025-03-07 6:35 ` [PATCH 1/4] mm/mempolicy: Support memory hotplug " Rakie Kim
2025-03-07 6:35 ` Rakie Kim [this message]
2025-03-07 18:19 ` [PATCH 2/4] mm/mempolicy: Enable sysfs support for " Joshua Hahn
2025-03-10 8:28 ` Rakie Kim
2025-03-07 6:35 ` [PATCH 3/4] mm/mempolicy: Fix duplicate node addition in sysfs for " Rakie Kim
2025-03-07 6:35 ` [PATCH 4/4] mm/mempolicy: Fix memory leaks in mempolicy_sysfs_init() Rakie Kim
2025-03-07 15:23 ` Gregory Price
2025-03-10 8:23 ` Rakie Kim
2025-03-07 15:56 ` [PATCH 0/4] mm/mempolicy: Add memory hotplug support in weighted interleave Gregory Price
2025-03-07 21:55 ` Gregory Price
2025-03-10 9:03 ` Rakie Kim
2025-03-10 14:13 ` Gregory Price
2025-03-12 8:18 ` Rakie Kim
2025-03-10 9:03 ` Rakie Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307063534.540-3-rakie.kim@sk.com \
--to=rakie.kim@sk.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gourry@gourry.net \
--cc=honggyu.kim@sk.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel_team@skhynix.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ying.huang@linux.alibaba.com \
--cc=yunjeong.mun@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox