From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BCA4C282D1 for ; Fri, 7 Mar 2025 01:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA6F2280003; Thu, 6 Mar 2025 20:38:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C567A280001; Thu, 6 Mar 2025 20:38:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF728280003; Thu, 6 Mar 2025 20:38:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 901D7280001 for ; Thu, 6 Mar 2025 20:38:13 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 23E3D80254 for ; Fri, 7 Mar 2025 01:38:14 +0000 (UTC) X-FDA: 83193044508.19.FDD33C4 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf02.hostedemail.com (Postfix) with ESMTP id 44F5A80009 for ; Fri, 7 Mar 2025 01:38:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Qyzvw1os; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741311492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hnkwGAXDjAZ/3Sv4OxDh6yiqEm9a+SObOYwqvIotnsc=; b=uqSiZJxevFshIyuBhiDxIHCRgACyh08KLyYh1KYtIMMHdMC13u78qHQpqdkJ8fU4zTowIC dKsZcfsH9pY6FWlgBt3/Xf2u/4YV1tpWrdQ9+vKb3jIrazNOv1VS4UvW83bfRPFrO+2g+A RjCtQ0d2SP/wml99qofavnGR1YJVg8w= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Qyzvw1os; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741311492; a=rsa-sha256; cv=none; b=Ba9WOJwKT3j6QXoxMR4nmDFXQM9a2DkeZH8y6pUTnMTv3Tm3G6FXWwQuvgEwyVo5YY2cNx CcFxg9+JNGvqFvcUAVARxUdJZdBulSkiuapZWieF6FAhahS0Qbhu+Q6ijM84i4m9rhDb9K EoSlIYYt/5NeJ97lcOZhbVLZl4qeQgw= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-47521c604efso17366671cf.0 for ; Thu, 06 Mar 2025 17:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741311491; x=1741916291; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hnkwGAXDjAZ/3Sv4OxDh6yiqEm9a+SObOYwqvIotnsc=; b=Qyzvw1osTMU2SKo6/0WJyjTZhbtcFyJqLDto0mI6yNUbMWb3b38/xkZY2Y7PWsO2Xp yyV4gTCZ5nLHG0NfzqNieuV9VHYNTDGUkUcRtgF0i6zEwPTc49o1IJhQkQ/iOosf+cqD AseFqaWpb+SdJLrSbk8K1VMOjGZGa7ayzpJwNB/mbwsC8t0ok1kbUbWgITD1y77ffnZE k+5P9LwvAUqceGDZCuiS0iL2HWmYP2Fdm0KFZ1JYHfR53NLBqveuygSAA8kU6ZV2Jrsg CAi9w17jQ0/WUOUyaqL+G9838n0FGKFBUCbzSYFH6sJod9NEqYUDNYt/pIUWwGvO76uu esMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741311491; x=1741916291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hnkwGAXDjAZ/3Sv4OxDh6yiqEm9a+SObOYwqvIotnsc=; b=mfw+885vPz5eBT6pDQQ8tF4opyhfL2Z2J2UfXYV3EX6u8i4oySWAvleOdXRAWai3co 1IyjQW3xU2Zzp6ZHSnrT8snExO6Ra4mxhMWU5dDKSp7Zwemvy35PMwNXl6lmd066YiSC NZPg+gSZJI0xV9eCYh5nW0wlscfIiS/N4cVUY6lHJvDxKBnsp9QfHyxrvVMeqHq5gfLh X5mE9nIIMxGomluT36gaMPg3zWEgcO+VTe/Eo+VJTPKyoW5atVZhNEICcnSRBwA1CxoX 66mVDO5bxq21W1QCbAP/DOS0jlnoLA9EaAYreE7DEQUvUIVeesSWQ9cEdvNOWpdlFtFC kPXg== X-Forwarded-Encrypted: i=1; AJvYcCUY0t10V/tilwZgs15rartw/lv1O6qQyQg5sJXB2Xf4OUpaY28LLwTy2Otk5ySDD2hz2bJrWRDGPw==@kvack.org X-Gm-Message-State: AOJu0YyP7sEYLa7tbWOkpqNozk0o5ojbP1N2lgSJ799+OJMqifgofTVH H9yHpazgyDFdxyAkApjid3BZ6zvbZDq5MdAs5G+ED5/xeZ1+P8E9YcMLRpSgJ1s= X-Gm-Gg: ASbGncuwEIO7PW1L0Epmhkm2mQeGt9CyJD7flzfAzJh9b4HxPnh0e5lFfs1D2a4P88L TDlUIN8QVuIrrzpoHEzfbAHg/iSQABf0zCbgBpO39ZWp4CFX5/lrOUw2Oi11FwEYK3PKUhDV54t 1t9H5f8LtoBuXID/o6CF7iWv0LctE1mu5oq098hJraUmFYzjDykvtp2NK74rybFzMB8LQnKVMpr UVuQOrOHe/VLa3URj58xM1j5QjhXmw2RnHRB3jJgW98AXWKlA/uP61wwCV6ULd9MlAYTIZKazVj kAI1w5SIOCW37wWIYwehGHADfj0e9DCAUK5e8q14mKA= X-Google-Smtp-Source: AGHT+IEtJlC54ZdJ22zSGj3d/VEVRbhunui5bPlFtWGfHB7hXm1qfRGaLDRqCGuEB7XXlk8lmGoUUg== X-Received: by 2002:a05:622a:34a:b0:474:f1b5:519c with SMTP id d75a77b69052e-47611959438mr18239461cf.32.1741311491506; Thu, 06 Mar 2025 17:38:11 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-4751db2f139sm13981901cf.51.2025.03.06.17.38.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 17:38:10 -0800 (PST) Date: Thu, 6 Mar 2025 20:38:09 -0500 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, yosryahmed@google.com, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() Message-ID: <20250307013809.GB423735@cmpxchg.org> References: <20250306230015.1456794-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306230015.1456794-1-nphamcs@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 44F5A80009 X-Stat-Signature: 3nj33ka9pwseh8yjcyyzhbh988xecraj X-HE-Tag: 1741311492-43046 X-HE-Meta: U2FsdGVkX18CO4wXI2y7ikMLjQhMDSePj+H2UYYlYCLKIJSmvj7W5q3qjrFvsYc5crxe0dE1CdT9s3V8caikxRPiiX8lRFWkXpHzrRYAqscfzCdsIKKwIaeAn2M2i5CcwHWK444zCSpEzELucHqRD4FAxsyd+5rpY6MG/lTCZwyx9SUDvh6GIWe0N7yewcPNniRZLinC9sr4IUlY7UKl6qrNitZJkP4pKiED4DOHSShkS8tczuX/8RjZHFNceYEi1AnGw8ZBr5Aw1+Xx06uq1wlROG9yQCTAk8acf062O5rFr+Rg3IPH8mPA/YQ4I438Fli6cNDXguR+q/QU4YKctDw8r34lJa+JLQ/4zDU7CvRWcAiSzTNJ4LwYMks2m6nJ6uFWxSZlnry1QDP9hSdqsL1TWq7Z7hzxrg5T3Usjb/2amPHr+6w9QCtrYSa7zgBI6suMnbKMipQiKLqK+J/05N0WqK6XMXX6ptoq2LYpu0Mp5Ntmd26d1Acxa7JVxGR/xekX59IyjKKmTxAjHPEIjFKHGvagCRYukvgKkBTQB0NLDhPvgjaeVam9o3w+sTuOEVypEvlXam9Cyt9m55SeCq1KS5FTokBKIk5SdFvDN+ZUZT7nFZwnhEykPvd09x9oCnnAf3xkvYkCjv/9RdlYKZ84CarmvJgSNo0CBbCSHqzpEXjyxzqvFu5BJV1JyLE95yOBaHKwqS0Cqx6N6rVrMSTs/GFbGr1o89zIvLNpaNlPXGF8+XEr33SqJUg/dKIBnE/n5j2C0O5nhvPkYZJ1hEHwM3KmdhURYWZX29O0ORWFdSXHx0SdrVREzl3kPQYNt23WjhUGf8kRNQowXLd071VgHtJoyB/gyOeKJLGwgaspUdZLC781nwKwlkInLL+e5nZixznWXc9DlHPsf7kPaM1bDsWhXdUd7kchqQ9HPpFeYJUJgQ5ekAPe9tBa30SryKq/S3IzJB1hhGYHrdc yQ4tyQaU BdHQBK6PY7AYBrlIrNfI6Hz31waimbH2uYxnD6CUEpSqQs4GK9f69BG+2piQRwIAvQ5Z3y5puOspu+l/u4Eyuy+/QsIxofy7JHr9HqePYX3keKQFF4rKmy83ssl5rim6aaVc8R94KttXNmPSxOFsvrZnjlkv3e9tCYQzF7ELOs4RyeGyb6F1lRQTRPGFotlx+P1jhQuq6s5dEEW7YU3GriAqgXXKTGGYuF3s2y+NG0jfImYB4XcFTOEdutECbb/UaOocbIFcCm7qv8fupJ1mTAjxIYwNO9ANXln15d7NlRoKoVHUaLJQPPvjaiYVRsAYvIGAELuVn+ndtqM4O0lSYWhUkCvWyeUsguJeA74lOx+kzDJwAPvlSxjpX9oyP5wOsOr6PPe6VP8Xns/2Dg4FIxmahDrJevaT7qeiE/tNo98fE6I3QzFnZFObd/RVzZqbznTlbB8VbhqX5y1lXL0XG7PWa5VVhoaK6tE9zeetzCNDI+1I7v44hMsg5B9tc2qelopw+SdzG5KpcuT/wtmhPEwmaDcHsMfY/W0KABnVwmI1Euu3bf01nnxHLHQ1qurQI1GaUuIih2SfDpIU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 03:00:15PM -0800, Nhat Pham wrote: > Similar to zswap_load(), also return proper error codes for > swap_read_folio_zeromap(): > > * 0 on success. The folio is unlocked and marked up-to-date. > * -ENOENT, if the folio is entirely not zeromapped. > * -EINVAL (with the follio unlocked but not marked to date), if the > folio is partially zeromapped. This is not supported, and will SIGBUS > the faulting process. > > This patch is purely a clean-up, and should not have any behavioral > change. It is based on (and should be applied on top of) [1]. > > [1]: https://lore.kernel.org/linux-mm/20250306205011.784787-1-nphamcs@gmail.com/ > > Suggested-by: Yosry Ahmed > Suggested-by: Johannes Weiner > Signed-off-by: Nhat Pham Nice! With Yosry's two suggestions: Acked-by: Johannes Weiner